On 1/26/2018 5:31 PM, Zielke, Julian, NLI wrote:
It will be marked as partial but not continuing and/or doing rotation. Also the xfer status won't be 1, because there were actual problems saving all files within the share. This is just to prevent BackupPC from running backups with xfer errors and doing rotation while some files in all series always were open during backup.
Julian, If I understood you correctly, you are trying to solve the following problem: If xfer errors occurred during a backup (files were open or whatever), the backup is inconsistent as it misses some files. In current implementation such a backup is considered successful despite xfer errors. The expiration algorithm dosen't take xfer errors in account as well. Here is a problem: under certain circumstances BackupPC expiration can leave errored backups, but expire consistent ones, so we will be unable to restore some files. That is the reason why I do daily checks for xfer errors and remove backups with xfer errors. Sure, the patch you are proposing will do it automatically, but it seem not a good solution to me. What if something happened with the host's data? In many cases a recent partial backup is better than nothing. But you've aborted it! More over you haven't saved the rest of shares on this host!!! https://github.com/backuppc/backuppc/blob/master/bin/BackupPC_dump#L1230 If some files always are open during backup, every backup will be aborted, so you will end up with no backups at all. If we mark the backup as partial instead of aborting it, the partial backup will be removed when the next successful backup completes, or if another full backup fails resulting in a newer partial backup. Advantages: files from partial backup can be restored, on the next backup we don't need to retransfer files already in the partial backup (for rsync, not for tar). The situation when some files always are open during backup should be avoided, in general. In case if there are just a few files and they are always the same, it is probably a good idea to create an exclusion list. So if all xfer errors happen when attempting to transfer files that are in the exclusion list, do not mark that backup as partial. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ BackupPC-users mailing list BackupPC-users@lists.sourceforge.net List: https://lists.sourceforge.net/lists/listinfo/backuppc-users Wiki: http://backuppc.wiki.sourceforge.net Project: http://backuppc.sourceforge.net/
