Re: [BackupPC-users] HIGH PRIORITY BUG FIX in v4.x that creates corruption when creating/reading/migrating v3 backups

2019-04-08 Thread backuppc 
Daniel Berteaud wrote at about 09:05:50 +0200 on Monday, April 8, 2019:
 > Le 2019-04-08 02:23, Craig Barratt via BackupPC-users a écrit :
 > 
 > >
 > Jeff, 
 > > 
 > > Thanks for tracking this down and proposing the correct fix.
 > I've pushed the fix to git, and released a new BackupPC-XS-0.59.tar.gz
 > on both git and cpan.
 > 
 > I'll update ASAP, but, what are the concrete
 > risks for running 0.58 and earlier ? I have a few install upgraded from
 > v3, are the new backups made after the upgrade safe ? 
 > 
 > Cheers, 
 > Daniel
 > 

The error should only affect backups made with v3-type or migrated from v3
using the v4 binary. If you have files with long file names
(especially that are non-standard ascii characters), there is a risk
that your backups were corrected - i.e. files left out.


___
BackupPC-users mailing list
BackupPC-users@lists.sourceforge.net
List:https://lists.sourceforge.net/lists/listinfo/backuppc-users
Wiki:http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/

Re: [BackupPC-users] HIGH PRIORITY BUG FIX in v4.x that creates corruption when creating/reading/migrating v3 backups

2019-04-08 Thread Daniel Berteaud 
Le 2019-04-08 02:23, Craig Barratt via BackupPC-users a écrit :

>
Jeff, 
> 
> Thanks for tracking this down and proposing the correct fix.
I've pushed the fix to git, and released a new BackupPC-XS-0.59.tar.gz
on both git and cpan.

I'll update ASAP, but, what are the concrete
risks for running 0.58 and earlier ? I have a few install upgraded from
v3, are the new backups made after the upgrade safe ? 

Cheers, 
Daniel


  

--
Daniel Berteaud
FIREWALL-SERVICES SAS, La sécurité des réseaux
Société de Services en Logiciels Libres
Tel/Fax : +33.5 56 64 15 32
Mail : dan...@firewall-services.com
Web : https://www.firewall-services.com___
BackupPC-users mailing list
BackupPC-users@lists.sourceforge.net
List:https://lists.sourceforge.net/lists/listinfo/backuppc-users
Wiki:http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/

Re: [BackupPC-users] HIGH PRIORITY BUG FIX in v4.x that creates corruption when creating/reading/migrating v3 backups

2019-04-07 Thread Craig Barratt via BackupPC-users 
Jeff,

Thanks for tracking this down and proposing the correct fix.  I've pushed
the fix to git, and released a new BackupPC-XS-0.59.tar.gz on both git and
cpan.

Craig

On Sun, Apr 7, 2019 at 7:03 AM  wrote:

> There is a simple but severe bug in bpc_attrib.c that causes v3
> version (BPC_ATTRIB_TYPE_UNIX) attrib files to either not read or read
> in a partial/corrupted fashion.
>
> For me, this led to error messages of form:
> unreasonable file name length 1048962
>
> BackupPC_migrateV3toV4: can't read attribute file 
>
> setVarInt botch: got negative argument -; setting to 0
>
> Plus presumably much silent corruption.
>
> Here is a simple patch:
>
> --- libbackuppc-xs-perl-0.58.orig/bpc_attrib.c
> +++ libbackuppc-xs-perl-0.58/bpc_attrib.c
> @@ -917,7 +917,7 @@ int bpc_attrib_dirRead(bpc_attrib_dir *d
>  return -1;
>   }
>
> -fileNameLen = getVarInt(, buf + nRead);
> +fileNameLen = getVarInt_v3(, buf + nRead);
>  if ( fileNameLen > 2 * BPC_MAXPATHLEN - 16 ) {
>  bpc_logErrf("bpc_attrib_dirRead: got unreasonable file
> name length %d\n", fileNameLen);
>  bpc_fileZIO_close();
>
>
> ___
> BackupPC-users mailing list
> BackupPC-users@lists.sourceforge.net
> List:https://lists.sourceforge.net/lists/listinfo/backuppc-users
> Wiki:http://backuppc.wiki.sourceforge.net
> Project: http://backuppc.sourceforge.net/
>
___
BackupPC-users mailing list
BackupPC-users@lists.sourceforge.net
List:https://lists.sourceforge.net/lists/listinfo/backuppc-users
Wiki:http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/

[BackupPC-users] HIGH PRIORITY BUG FIX in v4.x that creates corruption when creating/reading/migrating v3 backups

2019-04-07 Thread backuppc 
There is a simple but severe bug in bpc_attrib.c that causes v3
version (BPC_ATTRIB_TYPE_UNIX) attrib files to either not read or read
in a partial/corrupted fashion.

For me, this led to error messages of form:
unreasonable file name length 1048962

BackupPC_migrateV3toV4: can't read attribute file 

setVarInt botch: got negative argument -; setting to 0

Plus presumably much silent corruption.

Here is a simple patch:

--- libbackuppc-xs-perl-0.58.orig/bpc_attrib.c
+++ libbackuppc-xs-perl-0.58/bpc_attrib.c
@@ -917,7 +917,7 @@ int bpc_attrib_dirRead(bpc_attrib_dir *d
 return -1;
  }

-fileNameLen = getVarInt(, buf + nRead);
+fileNameLen = getVarInt_v3(, buf + nRead);
 if ( fileNameLen > 2 * BPC_MAXPATHLEN - 16 ) {
 bpc_logErrf("bpc_attrib_dirRead: got unreasonable file name 
length %d\n", fileNameLen);
 bpc_fileZIO_close();


___
BackupPC-users mailing list
BackupPC-users@lists.sourceforge.net
List:https://lists.sourceforge.net/lists/listinfo/backuppc-users
Wiki:http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/