Re: [Bacula-devel] [PATCH] Autochanger race causes volumes to marked in error

2014-01-05 Thread Matthew Ife
I'm not following you; The 'loaded' parameter is never changed in that function unless loaded < 0, which it isn't on entry. This is being called from autoload_device() (autoload.c:164-170) where the autoloader reports another slot than the one the volume is assumed to occupy. The comments in the fu

Re: [Bacula-devel] [PATCH] Autochanger race causes volumes to marked in error

2014-01-05 Thread Kern Sibbald
Matthew, I am not sure how your suggested fix can actually do something useful. The code just a bit higher in Bacula always sets the slot to either -1 or 0, consequently, this test will always fail if something was actually unloaded. What you say you want it to do seems to me to be correct, but

[Bacula-devel] [PATCH] Autochanger race causes volumes to marked in error

2014-01-03 Thread Matthew Ife
Sorry if this is not the right place to put this; I tried to submit this to mantis, but it did not respond with a confirmation email to setup my account. We recently upgraded to the latest community version of bacula but have seen some of our volumes landing in an error state on a daily basis. Th