Re: [Bacula-devel] Regression scripts fail

2007-07-19 Thread Andreas Helmcke
On 19.07.2007 15:28, Kern Sibbald wrote: > On Thursday 19 July 2007 15:22, BOLLENGIER Eric wrote: > Well, I have changed the behavior you expect to correspond to how most > other parameters of a Volume are handled. The Recycle Pool is set when > a Volume is created, but not changed whe

Re: [Bacula-devel] Regression scripts fail

2007-07-19 Thread Kern Sibbald
On Thursday 19 July 2007 15:22, BOLLENGIER Eric wrote: > > >> Well, I have changed the behavior you expect to correspond to how most > > >> other parameters of a Volume are handled. The Recycle Pool is set when > > >> a Volume is created, but not changed when it is recycled into the new > > >> poo

Re: [Bacula-devel] Regression scripts fail

2007-07-19 Thread BOLLENGIER Eric
> >> Well, I have changed the behavior you expect to correspond to how most > >> other parameters of a Volume are handled. The Recycle Pool is set when > >> a Volume is created, but not changed when it is recycled into the new > >> pool. Ok, if you use something like Pool { Name = Scratch Re

Re: [Bacula-devel] Regression scripts fail

2007-07-19 Thread Andreas Helmcke
On 19.07.2007 14:40, BOLLENGIER Eric wrote: > On Thursday 19 July 2007 14:20:51 Kern Sibbald wrote: >> On Thursday 19 July 2007 14:09, BOLLENGIER Eric wrote: >> >> That happened because the default pool attributes from the new pool were >> applied when moving the volume out of the Scratch pool. >>

Re: [Bacula-devel] Regression scripts fail

2007-07-19 Thread Kern Sibbald
On Thursday 19 July 2007 14:30, BOLLENGIER Eric wrote: > > > > With your new algo, RecyclePool must be set by user per volume. > > > > The problem was that the RecyclePool for the volume was destroyed when > > moving it to another Pool. > > > > I think it is fixed now. > > No, now, get_scratch_vo

Re: [Bacula-devel] Regression scripts fail

2007-07-19 Thread BOLLENGIER Eric
>From the manual : http://www.bacula.org/dev-manual/Configuring_Director.html#SECTION001416 RecyclePool = On versions 2.1.4 or greater, this directive defines to which pool the Volume will be placed (moved) when it is recycled. Without this directive, a Volume will remain i

Re: [Bacula-devel] Regression scripts fail

2007-07-19 Thread BOLLENGIER Eric
On Thursday 19 July 2007 14:20:51 Kern Sibbald wrote: > On Thursday 19 July 2007 14:09, BOLLENGIER Eric wrote: > > >From the manual : > > >From the manual : > > http://www.bacula.org/dev-manual/Configuring_Director.html#SECTION001416000 >0 > > > RecyclePool = > > On versions 2.1.4

Re: [Bacula-devel] Regression scripts fail

2007-07-19 Thread BOLLENGIER Eric
> > With your new algo, RecyclePool must be set by user per volume. > > The problem was that the RecyclePool for the volume was destroyed when > moving it to another Pool. > > I think it is fixed now. No, now, get_scratch_volume() is broken. The RecyclePoolId *must* be set when volume move from S

Re: [Bacula-devel] Regression scripts fail

2007-07-19 Thread Kern Sibbald
On Thursday 19 July 2007 14:09, BOLLENGIER Eric wrote: > > >From the manual : > >From the manual : > http://www.bacula.org/dev-manual/Configuring_Director.html#SECTION001416 > > RecyclePool = > On versions 2.1.4 or greater, this directive defines to which pool the > Volume

Re: [Bacula-devel] Regression scripts fail

2007-07-19 Thread Kern Sibbald
On Thursday 19 July 2007 13:47, BOLLENGIER Eric wrote: > > > > What happens is the following: > > > > > > > > Scratch Pool > > > > Volume X , Recycle Pool = Scratch Pool > > > > > > > > Volume X moved to Default Pool > > > > Default Pool has Recycle Pool = NULL > > > > Volume X Recycle Pool s

Re: [Bacula-devel] Regression scripts fail

2007-07-19 Thread BOLLENGIER Eric
> > > What happens is the following: > > > > > > Scratch Pool > > > Volume X , Recycle Pool = Scratch Pool > > > > > > Volume X moved to Default Pool > > > Default Pool has Recycle Pool = NULL > > > Volume X Recycle Pool set to NULL (previously it was unchanged) > > > > "Previously" means be

Re: [Bacula-devel] Regression scripts fail

2007-07-19 Thread Kern Sibbald
On Thursday 19 July 2007 11:26, BOLLENGIER Eric wrote: > Hi, > > > A recent "subtle" change to dird/ua_cmds.c causes at least one (possibly > > more) regression scripts to fail. I haven't checked, but I suspect that > > you made the change when you were fixing Andreas' SQL problems. > > I have j

Re: [Bacula-devel] Regression scripts fail

2007-07-19 Thread BOLLENGIER Eric
Hi, > A recent "subtle" change to dird/ua_cmds.c causes at least one (possibly > more) regression scripts to fail. I haven't checked, but I suspect that > you made the change when you were fixing Andreas' SQL problems. I have just cleanup the code. > Basically, the change forces the Recycle Poo

[Bacula-devel] Regression scripts fail

2007-07-19 Thread Kern Sibbald
Hello Eric, A recent "subtle" change to dird/ua_cmds.c causes at least one (possibly more) regression scripts to fail. I haven't checked, but I suspect that you made the change when you were fixing Andreas' SQL problems. Basically, the change forces the Recycle Pool to be the default value as