Re: [Bacula-devel] crash in 5.2.2 - bug fix

2011-12-05 Thread James Harper
> > Hello, > > On 12/05/2011 10:08 AM, James Harper wrote: > >> Unfortunately, the previous code was : > >> /* TODO: see if len contains already the 3 \0 */ > >> item = (CurFile > > *)jcr->file_list->hash_malloc(sizeof(CurFile)+len+3); > >> > >> And the new code is > >> item = (Cur

Re: [Bacula-devel] crash in 5.2.2 - bug fix

2011-12-05 Thread Eric Bollengier
Hello, On 12/05/2011 10:08 AM, James Harper wrote: >> Unfortunately, the previous code was : >> /* TODO: see if len contains already the 3 \0 */ >> item = (CurFile > *)jcr->file_list->hash_malloc(sizeof(CurFile)+len+3); >> >> And the new code is >> item = (CurFile > *)jcr->file_list

Re: [Bacula-devel] crash in 5.2.2 - bug fix

2011-12-05 Thread Eric Bollengier
On 12/05/2011 10:03 AM, James Harper wrote: >> >> Thanks to pin this problem, I think that allocating 1 extra byte as we > did in the >> previous version will handle this problem. >> >> Unfortunately, the previous code was : >> /* TODO: see if len contains already the 3 \0 */ >> item = (C

Re: [Bacula-devel] crash in 5.2.2 - bug fix

2011-12-05 Thread James Harper
> Unfortunately, the previous code was : > /* TODO: see if len contains already the 3 \0 */ > item = (CurFile *)jcr->file_list->hash_malloc(sizeof(CurFile)+len+3); > > And the new code is > item = (CurFile *)jcr->file_list->hash_malloc(sizeof(CurFile)+len); > > This is a serious issue

Re: [Bacula-devel] crash in 5.2.2 - bug fix

2011-12-05 Thread James Harper
> > Thanks to pin this problem, I think that allocating 1 extra byte as we did in the > previous version will handle this problem. > > Unfortunately, the previous code was : > /* TODO: see if len contains already the 3 \0 */ > item = (CurFile *)jcr->file_list->hash_malloc(sizeof(CurFile)+

Re: [Bacula-devel] crash in 5.2.2 - bug fix

2011-12-05 Thread Eric Bollengier
> + item->chksum = item->lstat+strlen(item->lstat); > + } else { > + item->chksum = item->lstat+strlen(item->lstat)+1; > + strcpy(item->chksum, chksum); > + } > > item->delta_seq = delta; > > James > >> -Original

Re: [Bacula-devel] crash in 5.2.2 - bug fix

2011-12-04 Thread James Harper
at); + } else { + item->chksum = item->lstat+strlen(item->lstat)+1; + strcpy(item->chksum, chksum); + } item->delta_seq = delta; James > -Original Message- > From: James Harper > Sent: Monday, 5 December 2011 3:08 PM > To: James Harper; bacu

Re: [Bacula-devel] crash in 5.2.2

2011-12-04 Thread James Harper
> > I'm getting a consistent crash on one Windows 2008 R2 server: > > 05-Dec 12:50 bitdc1-fd: ABORTING due to ERROR in > /home/kern/bacula/k/bacula/src/lib/smartall.c:216 > Overrun buffer: len=9830441 addr=40d0068 allocated: > /home/kern/bacula/k/bacula/src/lib/htable.c:72 called from > /home/ker

[Bacula-devel] crash in 5.2.2

2011-12-04 Thread James Harper
I'm getting a consistent crash on one Windows 2008 R2 server: 05-Dec 12:50 bitdc1-fd: ABORTING due to ERROR in /home/kern/bacula/k/bacula/src/lib/smartall.c:216 Overrun buffer: len=9830441 addr=40d0068 allocated: /home/kern/bacula/k/bacula/src/lib/htable.c:72 called from /home/kern/bacula/k/bacula