Re: [BangPypers] Fwd: Need a help on reviewing a python code. Message-ID: cacimrglh7bharoas710ofojd8g2i_liynbywka1640dvk5r...@mail.gmail.com

2015-07-17 Thread Senthil Kumaran
Very minor comments. 1. planet.py: from math import pi as PI Unless there is a name conflict with the identifier being used. You could avoid using as in the import. Here I guess, you wanted constants in capitals (perhaps a linter tool required). In that case, you could write it as import math;

[BangPypers] Fwd: Need a help on reviewing a python code. Message-ID: cacimrglh7bharoas710ofojd8g2i_liynbywka1640dvk5r...@mail.gmail.com

2015-07-17 Thread Ramesh Rajagopal
With regards to the below thread-id, I have posted my code into github account. Please have a look at and review it. https://github.com/rameshrajagopal/alignment Regards, Ramesh Message: 1 Date: Fri, 17 Jul 2015 01:13:13 +0530 From: Gora Mohanty g...@mimirtech.com To: Bangalore Python Users

Re: [BangPypers] Fwd: Need a help on reviewing a python code.

2015-07-16 Thread Anuvrat Parashar
1. alignment.tar.gs is missing. 2. please consider hosting the code on github / bitbucket instead of attaching heavy files. On Thu, Jul 16, 2015 at 3:49 PM, Ramesh Rajagopal mail2.rame...@gmail.com wrote: -- Forwarded message -- From: Ramesh Rajagopal mail2.rame...@gmail.com

[BangPypers] Fwd: Need a help on reviewing a python code.

2015-07-16 Thread Ramesh Rajagopal
-- Forwarded message -- From: Ramesh Rajagopal mail2.rame...@gmail.com Date: Jul 16, 2015 3:30 PM Subject: Fwd: Need a help on reviewing a python code. To: bangpypers@python.org Cc: Hello All, It would be very helpful, if you can review a small code which I had written in

Re: [BangPypers] Fwd: Need a help on reviewing a python code.

2015-07-16 Thread Gora Mohanty
Hi, Just forget it. The problem statement itself is so badly broken that it is unfixable, IMHO. To quote from problem.txt: The application will not determine the alignments itself. Instead, the application must be able to load a set of plugins at runtime that will determine whether a particular

Re: [BangPypers] Fwd: Need a help on reviewing a python code.

2015-07-16 Thread Senthil Kumaran
Agree with Anuvrat. Paste your code in https://gist.github.com/ or upload it github/bitcket and share it again. I will help with the review. Thanks, Senthil On Thu, Jul 16, 2015 at 3:40 AM, Anuvrat Parashar anuv...@anuvrat.in wrote: 1. alignment.tar.gs is missing. 2. please consider

Re: [BangPypers] Fwd: Need a help on reviewing a python code.

2015-07-16 Thread Senthil Kumaran
On Thu, Jul 16, 2015 at 12:43 PM, Gora Mohanty g...@mimirtech.com wrote: IMHO, it is just not worth even applying to such companies as their basic recruitment process seems not to work. Agree. Irrespective of that, this list 'bangpypers' focusses on python language ecosystem. So, I thought,