Hello,
I'm interested in way Barebox passes initrd to kernel if both are taken
from FIT. What shall I do, if I want my kernel and initrd to be compressed
in a single FIT image? What kernel boot params and config options
should be set then?
--
Yours sincerely,
Seraphim Dolbilov
On Thu, Mar 07, 2019 at 10:52:33AM +0100, Tomaž Šolc wrote:
> Hi
>
> On 6. 03. 19 10:42, Sascha Hauer wrote:
> > diff --git a/common/Kconfig b/common/Kconfig
> > index 563cf15fb1..0c6acfcddb 100644
> > --- a/common/Kconfig
> > +++ b/common/Kconfig
> > @@ -1173,6 +1173,12 @@ config DEBUG_RPI2_UART
On 3/7/19 8:32 AM, Sascha Hauer wrote:
> On Mon, Mar 04, 2019 at 03:16:51PM +0100, Ahmad Fatoum wrote:
>> Hello,
>>
>> On 19/2/19 13:10, Ahmad Fatoum wrote:
>>> For platforms such as the at91, the boot ROM imposes an upper limit
>>> on barebox file size. Prior to 5a1a5ed253 ("ARM: images: use
Hi
I tried this series on R.Pi 3B (make rpi_defconfig +
DEBUG_RPI3_MINI_UART) and Compute Module 3 (make rpi_defconfig +
DEBUG_RPI2_UART) and after the two small fixes I mention in my other
replies they both work as expected. Thanks!
Best regards
Tomaž
On 6. 03. 19 10:42, Sascha Hauer
Hi
On 6. 03. 19 10:42, Sascha Hauer wrote:
In contrast to other architectures, R.Pi debug UART config was placed
under the "System Type" menu, not under the "Debugging -> low-level
debugging port". This made this setting easy to miss when enabling low
level debug mesages.
While at it use the
Hi
On 6. 03. 19 10:42, Sascha Hauer wrote:
diff --git a/common/Kconfig b/common/Kconfig
index 563cf15fb1..0c6acfcddb 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -1173,6 +1173,12 @@ config DEBUG_RPI2_UART
Say Y here if you want low-level debugging support on
Checking that sector_count is zero, shouldn't be necessary since block
layer won't call this function if there's no data to be read. Drop it.
Checking that blockbits is eqal to SECTOR_SHIFT isn't necessary, since
that field is filled by the driver and is not changed outsied of
it. We know it is
Both usb_stor_read_10() and usb_stor_write_10() do almost exactly the
same thing, so merge them into a signle routine and adjust all of the
users accordingly.
Signed-off-by: Andrey Smirnov
---
drivers/usb/storage/usb.c | 60 ++-
1 file changed, 9
Usb_limit_blk_cnt() has only one user so we may as well inline it.
Signed-off-by: Andrey Smirnov
---
drivers/usb/storage/usb.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
index 335f8033b..fda24d616
Replace explicit endianness casts with put_unaligned_be* helpers.
Signed-off-by: Andrey Smirnov
---
drivers/usb/storage/usb.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
index 5a5d075ec..06ec1eb4e
Simplify I/O loop a bit, by re-arranging things and dropping
"sectors_done", "result" and "data" local variables.
Signed-off-by: Andrey Smirnov
---
drivers/usb/storage/usb.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/usb/storage/usb.c
There's only user of the to_usb_mass_storage() so we may as well
inline it.
Signed-off-by: Andrey Smirnov
---
drivers/usb/storage/usb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
index 29e3792aa..0ab20f1ac
Drop a number of variables no longer used in the code.
Signed-off-by: Andrey Smirnov
---
drivers/usb/storage/usb.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
index 64142048c..69de9ebf3 100644
--- a/drivers/usb/storage/usb.c
Signed-off-by: Andrey Smirnov
---
drivers/usb/storage/usb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
index 7df8a52b6..335f8033b 100644
--- a/drivers/usb/storage/usb.c
+++ b/drivers/usb/storage/usb.c
@@ -285,9
No symbols found in are used in this file. Drop it.
Signed-off-by: Andrey Smirnov
---
drivers/ata/ahci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 3f0bbb075..7dc09d00c 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -27,7 +27,6
Move special preparation steps done before the call to
usb_stor_write_10() inside the function itself for clarity and to
allow futher code improvements. No functional change intended.
Signed-off-by: Andrey Smirnov
---
drivers/usb/storage/usb.c | 43 +++
1
There are no users of usb_control_msg() in the codebase that pass
timeout of 0, so it doesn't look like usb_disable_asynch() has any
effect on USB operation. Drop that function and remove all of its uses
to simplify things.
Signed-off-by: Andrey Smirnov
---
drivers/usb/core/usb.c| 24
Use simple boolean to speficy read vs. write operation
usb_stor_blk_io() instead of having a custom anonymous enum.
Signed-off-by: Andrey Smirnov
---
drivers/usb/storage/usb.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/storage/usb.c
All the info we need to pass to transport function can be captured in
a struct us_blk_dev and two byte arrays, so having a dedicated struct
with many unused fields doesn't really buy us anything. Drop the
struct and convert the rest of the code to pass needed data
explicitly.
Signed-off-by:
There are no users of us_blkdev_list in the file. Drop it.
Signed-off-by: Andrey Smirnov
---
drivers/usb/storage/usb.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
index c04a202bb..faf9ec2b4 100644
--- a/drivers/usb/storage/usb.c
Move retry logic found in all of the low-level usb_stor_* functions
into a standalone subroutine and convert the rest of the code to use
it.
Signed-off-by: Andrey Smirnov
---
drivers/usb/storage/usb.c | 213 +-
1 file changed, 117 insertions(+), 96
Only bulk-only transport is supported by the currennt codebase, so
ep_bInterval and recv_intr_ep are not really used. Remove them and all
related code. While at it remove flags and subclass as well since they
are not really used anywhere in the codebase.
Signed-off-by: Andrey Smirnov
---
No symbols found in are used in this file. Drop it.
Signed-off-by: Andrey Smirnov
---
drivers/usb/core/hub.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 39e5fe67d..d01a01607 100644
--- a/drivers/usb/core/hub.c
+++
Don't try to re-use caller's "ccb" and instead convert
usb_stor_request_sense() to use its own for clarity and to allow
futher code improvements. No functional change intended.
Signed-off-by: Andrey Smirnov
---
drivers/usb/storage/usb.c | 33 ++---
1 file changed, 18
Move special preparation steps done before and after call to
usb_stor_inquiry() inside the function itself for clarity and to allow
futher code improvements. No functional change intended.
Signed-off-by: Andrey Smirnov
---
drivers/usb/storage/usb.c | 52 ++-
Move special preparation steps done before the call to
usb_stor_test_unit_ready() inside the function itself for clarity and
to allow futher code improvements. No functional change intended.
Signed-off-by: Andrey Smirnov
---
drivers/usb/storage/usb.c | 28
1 file
Move special preparation steps done before the call to
usb_stor_read_10() inside the function itself for clarity and to allow
futher code improvements. No functional change intended.
Signed-off-by: Andrey Smirnov
---
drivers/usb/storage/usb.c | 41 ---
1 file
There doesn't seem to be a particularly good reason to call
->trasport() one last time after 2 failures. Drop the call so allow
sharing this code with usb_stor_read_10() in the following commit.
Signed-off-by: Andrey Smirnov
---
drivers/usb/storage/usb.c | 2 +-
1 file changed, 1 insertion(+),
Move special preparation steps done before and after call to
usb_stor_read_capacity() inside the function itself for clarity and to
allow futher code improvements. No functional change intended.
Signed-off-by: Andrey Smirnov
---
drivers/usb/storage/usb.c | 53
Unsignled long will expand to 64-bit unsigned integer on 64-bit
CPUs. This will break current code using it to read out two 32-bit
values returned by READ_CAPACITY. Fix the proble by using "u32"
explicitly.
Signed-off-by: Andrey Smirnov
---
drivers/usb/storage/usb.c | 6 +++---
1 file changed,
Everyone:
While creating fix found in "usb: storage: Don't use "unsigned long"
for 32-bit values" I spent some time reading code of our USB storage
implementation. The other 25 patches is the result of that effort and
my attempt to improve/simplify that codebase. Hopefuly each patch is
Replace custom debug tracing macros with a call to dev_dbg to simplify
code and add device info into degug output.
Signed-off-by: Andrey Smirnov
---
drivers/usb/storage/transport.c | 59
drivers/usb/storage/usb.c | 118 +---
Replace explicit malloc() + OOM check and memset() with a single call
to xzalloc().
Signed-off-by: Andrey Smirnov
---
drivers/usb/storage/usb.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
index
33 matches
Mail list logo
