Re: [PATCH 1/3] watchdog: remove wrong uses of timeout_cur

2019-10-24 Thread Oleksij Rempel
Hi, How about using this variable to start watchdog(s) on kernel boot? Am 24.10.19 um 17:24 schrieb Ahmad Fatoum: > The barebox watchdog poller uses the struct watchdog.timeout_cur as > the timeout value to configure the watchdog with. > > There's no need for the device driver to set this. I

Re: [PATCH] sandbox: add_image: mmap block devices

2019-10-24 Thread Ahmad Fatoum
On 10/24/19 6:02 PM, Robert Karszniewicz wrote: > This makes it possible to mount block devices from the host machine, > which have been passed as arguments to --image > > Signed-off-by: Robert Karszniewicz > --- > arch/sandbox/os/common.c | 8 > 1 file changed, 8 insertions(+) > >

[PATCH] sandbox: add_image: mmap block devices

2019-10-24 Thread Robert Karszniewicz
This makes it possible to mount block devices from the host machine, which have been passed as arguments to --image Signed-off-by: Robert Karszniewicz --- arch/sandbox/os/common.c | 8 1 file changed, 8 insertions(+) diff --git a/arch/sandbox/os/common.c b/arch/sandbox/os/common.c

[PATCH 1/3] watchdog: remove wrong uses of timeout_cur

2019-10-24 Thread Ahmad Fatoum
The barebox watchdog poller uses the struct watchdog.timeout_cur as the timeout value to configure the watchdog with. There's no need for the device driver to set this. I didn't know that when I wrote the drivers, but I do now, hence this commit. Signed-off-by: Ahmad Fatoum ---

[PATCH 2/3] watchdog: rename timeout_curr to poller_timeout_curr internally

2019-10-24 Thread Ahmad Fatoum
timeout_curr is the timeout programmed into the watchdog hardware every 500 milliseconds. If watchdog poller support is disabled, it serves no purpose, prefix it with poller_ to better communicate this fact. No functional change. Signed-off-by: Ahmad Fatoum --- drivers/watchdog/wd_core.c | 10

[PATCH 3/3] watchdog: add timeout_cur parameter only when poller is enabled

2019-10-24 Thread Ahmad Fatoum
timeout_curr is the timeout programmed into the watchdog hardware every 500 milliseconds. If watchdog poller support is disabled, it still shows up as a configurable device parameter, but has no effect. Improve user experience by having it show up only if watchdog poller support was compiled in.

Re: [PATCH 2/5] firmware-zynqmp: extend driver with fpga relavant functions

2019-10-24 Thread Michael Tretter
On Thu, 24 Oct 2019 10:26:51 +, Thomas Hämmerle wrote: > From: Thomas Haemmerle > > Port functions from xlnx-linux to get FPGA status and invoke bitstream > loading. > > Signed-off-by: Thomas Haemmerle Reviewed-by: Michael Tretter > --- > arch/arm/mach-zynqmp/firmware-zynqmp.c

Re: [PATCH 3/5] firmware: zynqmp-fpga: introduce driver to load bitstream to FPGA

2019-10-24 Thread Michael Tretter
On Thu, 24 Oct 2019 10:26:51 +, Thomas Hämmerle wrote: > From: Thomas Haemmerle > > The driver provides functionalities to check and load a bitstream to FPGA. > A boolean parameter to check if FPGA is already programmed is > added. > > Signed-off-by: Thomas Haemmerle > --- >

Re: [PATCH 1/5] ARM: zynqmp: dts: move firmware node to src tree

2019-10-24 Thread Michael Tretter
On Thu, 24 Oct 2019 10:26:50 +, Thomas Hämmerle wrote: > From: Michael Tretter > > The firmware node will be added to the mainline device tree. As it will > eventually enter Barebox via a device tree sync, add it to the src tree > already. Not sure, but I think that we should wait with the

[PATCH 5/5] firmware: zynqmp-fpga: print Xilinx bitstream header

2019-10-24 Thread Thomas Hämmerle
From: Michael Tretter The bitstream header has 5 fields, that start with a char for the type. Four fields have a big-ending length and a null-terminated string for the design name, the part number, and the date and time of creation. The last field is a big-endian 32 bit unsigned int for the size

[PATCH 1/5] ARM: zynqmp: dts: move firmware node to src tree

2019-10-24 Thread Thomas Hämmerle
From: Michael Tretter The firmware node will be added to the mainline device tree. As it will eventually enter Barebox via a device tree sync, add it to the src tree already. Signed-off-by: Michael Tretter --- arch/arm/dts/zynqmp-zcu104-revA.dts | 1 - arch/arm/dts/zynqmp.dtsi|

[PATCH 2/5] firmware-zynqmp: extend driver with fpga relavant functions

2019-10-24 Thread Thomas Hämmerle
From: Thomas Haemmerle Port functions from xlnx-linux to get FPGA status and invoke bitstream loading. Signed-off-by: Thomas Haemmerle --- arch/arm/mach-zynqmp/firmware-zynqmp.c | 47 ++ .../arm/mach-zynqmp/include/mach/firmware-zynqmp.h | 8 2 files

[PATCH 4/5] ARM: zynqmp: dts: move pcap node to src tree

2019-10-24 Thread Thomas Hämmerle
From: Thomas Haemmerle The pcap node will be added to the mainline device tree. As it will eventually enter Barebox via a device tree sync, add it to the src tree already. Signed-off-by: Thomas Haemmerle --- dts/src/arm64/xilinx/zynqmp.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 3/5] firmware: zynqmp-fpga: introduce driver to load bitstream to FPGA

2019-10-24 Thread Thomas Hämmerle
From: Thomas Haemmerle The driver provides functionalities to check and load a bitstream to FPGA. A boolean parameter to check if FPGA is already programmed is added. Signed-off-by: Thomas Haemmerle --- arch/arm/configs/zynqmp_defconfig | 1 +

[PATCH 0/5] ARM: zynqmp: add support for bitstream loading

2019-10-24 Thread Thomas Hämmerle
From: Thomas Haemmerle Michael Tretter (2): ARM: zynqmp: dts: move firmware node to src tree firmware: zynqmp-fpga: print Xilinx bitstream header Thomas Haemmerle (3): firmware-zynqmp: extend driver with fpga relavant functions firmware: zynqmp-fpga: introduce driver to load bitstream

Re: [PATCH 1/6] Documentation: efi: emphasize watchdog deactivation on ExitBootServices

2019-10-24 Thread Sascha Hauer
On Wed, Oct 23, 2019 at 06:55:56PM +0200, Ahmad Fatoum wrote: > The UEFI specification paragraph quoted above notes: > > The watchdog timer is only used during boot services. On successful > > completion of ExitBootServices() the watchdog timer is disabled. > > Thus disabling the watchdog is

Re: flash barebox to NAND

2019-10-24 Thread Sascha Hauer
On Wed, Oct 23, 2019 at 03:47:49PM +0200, Mihaita Ivascu wrote: > On Wed, Oct 23, 2019 at 3:33 PM Sascha Hauer wrote: > > > > On Wed, Oct 23, 2019 at 11:39:00AM +0200, Mihaita Ivascu wrote: > > > Hello all, > > > > > > I would like to know what possibilities do I have to flash a barebox > > >

Re: [PATCH 1/6] Documentation: efi: emphasize watchdog deactivation on ExitBootServices

2019-10-24 Thread Oleksij Rempel
On Wed, Oct 23, 2019 at 06:55:56PM +0200, Ahmad Fatoum wrote: > The UEFI specification paragraph quoted above notes: > > The watchdog timer is only used during boot services. On successful > > completion of ExitBootServices() the watchdog timer is disabled. > > Thus disabling the watchdog is

[PATCH] efi: populate boot source instance

2019-10-24 Thread Ahmad Fatoum
We already determine the boot source variable at core init level, but so far we didn't populate the instance because the numbering of the block devices isn't known that early. Introduce a helper to check if a block device is the boot source and if it is, have the block device driver populate the

[PATCH v6 1/2] Documentation: add watchdog documentation

2019-10-24 Thread Oleksij Rempel
Signed-off-by: Oleksij Rempel --- Documentation/user/user-manual.rst | 1 + Documentation/user/watchdog.rst| 85 ++ 2 files changed, 86 insertions(+) create mode 100644 Documentation/user/watchdog.rst diff --git a/Documentation/user/user-manual.rst

[PATCH v6 2/2] doc: watchdog: add note about danger of autoping

2019-10-24 Thread Oleksij Rempel
Signed-off-by: Oleksij Rempel --- Documentation/user/watchdog.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/user/watchdog.rst b/Documentation/user/watchdog.rst index 26e347d5f6..02bd576a89 100644 --- a/Documentation/user/watchdog.rst +++