We no longer use __dtb_start on ARM and the declaration is unused in the
file. Drop it.
No functional change.
Signed-off-by: Ahmad Fatoum
---
arch/arm/cpu/dtb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/cpu/dtb.c b/arch/arm/cpu/dtb.c
index 1ba5aa415ef7..c43474e63b9b 100644
data->{blocks, blocksize, flags} are all used outside of the if clause
checking whether data is not NULL.
Fix this to avoid dereferencing null pointers.
Fixes: bdcf89d274 ("mci: add Marvell Dove SDHCI driver")
Cc: Michael Grzeschik
Signed-off-by: Ahmad Fatoum
---
drivers/mci/dove-sdhci.c | 15
Signed-off-by: Antony Pavlov
---
drivers/i2c/busses/i2c-gpio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c
index 5ab43fe935..7ccdb0b222 100644
--- a/drivers/i2c/busses/i2c-gpio.c
+++
On Tue, Nov 19, 2019 at 12:10:39PM +0100, Ahmad Fatoum wrote:
> > + if (prs & SDHCI_BUFFER_WRITE_ENABLE &&
> > + !(data->flags & MMC_DATA_READ)) {
> > + sdhci_tx_pio(sdhci, data, block);
> > + block++;
> > + start =
On 11/19/19 11:50 AM, Sascha Hauer wrote:
> We have several SDHCI compatible drivers in the tree. This starts
> with a set of generic helper functions for these drivers to share
> some common functionality.
>
> Signed-off-by: Sascha Hauer
> ---
> drivers/mci/Kconfig | 3 +
>
On Mon, Nov 18, 2019 at 07:11:53AM +0100, Oleksij Rempel wrote:
> Signed-off-by: Oleksij Rempel
> ---
> arch/mips/mach-ath79/art.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
On Fri, Nov 15, 2019 at 08:52:53AM +0100, Ahmad Fatoum wrote:
> So far, the smc command was only usable when barebox also provides the
> secure monitor. It's useful to have it when barebox is a PSCI consumer
> as well to test whether the secure monitor works.
> Factor out the code into commands/
As we have several drivers for different SDHCI controller variants it's
time to start sharing some code. This series creates some generic SDHCI
helper functions and starts using them drom the different drivers.
There's more to share, this series is only a start. Finally the Arasan
SDHCI driver is
To use the sdhci helpers we have to switch to the sdhci accessors.
Also use sdhci_read_response().
Signed-off-by: Sascha Hauer
---
drivers/mci/Kconfig | 1 +
drivers/mci/tegra-sdmmc.c | 122 --
2 files changed, 65 insertions(+), 58 deletions(-)
diff
We have several SDHCI compatible drivers in the tree. This starts
with a set of generic helper functions for these drivers to share
some common functionality.
Signed-off-by: Sascha Hauer
---
drivers/mci/Kconfig | 3 +
drivers/mci/Makefile | 1 +
drivers/mci/sdhci.c | 127
Add some missing register definitions.
Signed-off-by: Sascha Hauer
---
drivers/mci/sdhci.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mci/sdhci.h b/drivers/mci/sdhci.h
index 640398d9d8..bd98c96060 100644
--- a/drivers/mci/sdhci.h
+++ b/drivers/mci/sdhci.h
@@ -24,6 +24,9 @@
Use sdhci_transfer_data() to share more code.
Signed-off-by: Sascha Hauer
---
drivers/mci/mci-bcm2835.c | 92 ---
1 file changed, 8 insertions(+), 84 deletions(-)
diff --git a/drivers/mci/mci-bcm2835.c b/drivers/mci/mci-bcm2835.c
index f17bae7c8d..b18d681870
Use sdhci_set_cmd_xfer_mode() to share more code.
Signed-off-by: Sascha Hauer
---
drivers/mci/tegra-sdmmc.c | 33 +++--
1 file changed, 3 insertions(+), 30 deletions(-)
diff --git a/drivers/mci/tegra-sdmmc.c b/drivers/mci/tegra-sdmmc.c
index 69de39b180..1cc75dc524
The 32bit register defines are no longer used. Remove them.
Signed-off-by: Sascha Hauer
---
drivers/mci/sdhci.h | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/mci/sdhci.h b/drivers/mci/sdhci.h
index bd98c96060..c1e4f06606 100644
--- a/drivers/mci/sdhci.h
+++
We have some register defines in a 16bit access version and a 32bit
access version. Use the former to get rid of the latter later.
Signed-off-by: Sascha Hauer
---
drivers/mci/imx-esdhc.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git
To use the sdhci helpers we have to switch to the sdhci accessors.
Also use sdhci_read_response().
Signed-off-by: Sascha Hauer
---
drivers/mci/Kconfig | 1 +
drivers/mci/dove-sdhci.c | 116 +--
2 files changed, 63 insertions(+), 54 deletions(-)
diff
To use the sdhci helpers we have to switch to the sdhci accessors.
Also use sdhci_read_response().
Signed-off-by: Sascha Hauer
---
drivers/mci/Kconfig | 1 +
drivers/mci/imx-esdhc.c | 140 ++--
2 files changed, 77 insertions(+), 64 deletions(-)
diff
From: Thomas Haemmerle
This adds support for the Arasan SDHCI controller, which is found on
the Xilinx Zynq 7000 and ZynqMP SoCs. This just adds very basic
PIO read/write support.
This submission is also missing the tap delay configuration, which is
required for the high speed modes on the
Use sdhci_set_cmd_xfer_mode() to share more code.
Signed-off-by: Sascha Hauer
---
drivers/mci/mci-bcm2835.c | 22 ++
1 file changed, 2 insertions(+), 20 deletions(-)
diff --git a/drivers/mci/mci-bcm2835.c b/drivers/mci/mci-bcm2835.c
index 61995a2883..f17bae7c8d 100644
---
We have duplicate register bit defines for the transfer mode register.
Remove the duplicates.
Signed-off-by: Sascha Hauer
---
drivers/mci/imx-esdhc-pbl.c | 4 ++--
drivers/mci/imx-esdhc.c | 8
drivers/mci/mci-bcm2835.c | 6 +++---
drivers/mci/sdhci.h | 6 --
Use sdhci_set_cmd_xfer_mode() to share more code.
Signed-off-by: Sascha Hauer
---
drivers/mci/imx-esdhc.c | 57 -
1 file changed, 11 insertions(+), 46 deletions(-)
diff --git a/drivers/mci/imx-esdhc.c b/drivers/mci/imx-esdhc.c
index
We have some register defines in a 16bit access version and a 32bit
access version. Use the former to get rid of the latter later.
Signed-off-by: Sascha Hauer
---
drivers/mci/mci-bcm2835.c | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git
Use sdhci_transfer_data() in PIO mode to share mode code.
Signed-off-by: Sascha Hauer
---
drivers/mci/imx-esdhc.c | 69 +
1 file changed, 1 insertion(+), 68 deletions(-)
diff --git a/drivers/mci/imx-esdhc.c b/drivers/mci/imx-esdhc.c
index
We have some register defines in a 16bit access version and a 32bit
access version. Use the former to get rid of the latter later.
Signed-off-by: Sascha Hauer
---
drivers/mci/imx-esdhc-pbl.c | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git
We have duplicate register bit defines for the prsstat register.
Remove the duplicates.
Signed-off-by: Sascha Hauer
---
drivers/mci/imx-esdhc-pbl.c | 6 +++---
drivers/mci/imx-esdhc.c | 17 +++--
drivers/mci/mci-bcm2835.c | 8
drivers/mci/sdhci.h | 16
We have some register defines in a 16bit access version and a 32bit
access version. Use the former to get rid of the latter later.
Signed-off-by: Sascha Hauer
---
drivers/mci/tegra-sdmmc.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git
To use the sdhci helpers we have to switch to the sdhci accessors.
Also use sdhci_read_response().
Signed-off-by: Sascha Hauer
---
drivers/mci/Kconfig | 1 +
drivers/mci/mci-bcm2835.c | 119 +-
2 files changed, 55 insertions(+), 65 deletions(-)
diff
Use sdhci_set_cmd_xfer_mode() to share more code.
Signed-off-by: Sascha Hauer
---
drivers/mci/dove-sdhci.c | 32
1 file changed, 4 insertions(+), 28 deletions(-)
diff --git a/drivers/mci/dove-sdhci.c b/drivers/mci/dove-sdhci.c
index 7818bef0d9..e71a27ce4f
We have duplicate bit defines for the interrupt bits. Remove the duplicates.
Signed-off-by: Sascha Hauer
---
drivers/mci/imx-esdhc-pbl.c | 12 -
drivers/mci/imx-esdhc.c | 21
drivers/mci/imx-esdhc.h | 4 +--
drivers/mci/mci-bcm2835.c | 14 +--
Hello Oleksij,
On 11/19/19 10:41 AM, Oleksij Rempel wrote:
> Am 19.11.19 um 09:26 schrieb Ahmad Fatoum:
>> I am asking because I am testing use of the generic ARM board as default
>> second stage image for the multi-image AT91s. The board specific entry point
>> generates only the PBL, which runs
Am 19.11.19 um 09:26 schrieb Ahmad Fatoum:
> Hello Sascha,
>
> On 8/19/19 3:38 PM, Sascha Hauer wrote:
>> +void dt_2nd_aarch64(void *fdt)
>> +{
>> +unsigned long image_start = (unsigned long)_text +
>> global_variable_offset();
>> +
>> +arm_setup_stack(image_start);
>
> Shouldn't we
Hello Sascha,
On 8/19/19 3:38 PM, Sascha Hauer wrote:
> +void dt_2nd_aarch64(void *fdt)
> +{
> + unsigned long image_start = (unsigned long)_text +
> global_variable_offset();
> +
> + arm_setup_stack(image_start);
Shouldn't we rather place the stack somewhere beyond the end of the
32 matches
Mail list logo