Re: [PATCH] common: boards: wolfvision: use state_by_alias instead of opencoding

2024-05-14 Thread Michael Riesch
Hi Ahmad, On 5/15/24 08:35, Ahmad Fatoum wrote: > Hello Michael, > > On 15.05.24 08:29, Michael Riesch wrote: >> Hi Ahmad, >> >> Thanks a lot for your patch! >> >> On 5/15/24 08:07, Ahmad Fatoum wrote: >>> This introduces no functional change, but makes code a bit more compact. >>> >>> Cc: Michae

Re: [PATCH] common: boards: wolfvision: use state_by_alias instead of opencoding

2024-05-14 Thread Ahmad Fatoum
Hello Michael, On 15.05.24 08:29, Michael Riesch wrote: > Hi Ahmad, > > Thanks a lot for your patch! > > On 5/15/24 08:07, Ahmad Fatoum wrote: >> This introduces no functional change, but makes code a bit more compact. >> >> Cc: Michael Riesch >> Signed-off-by: Ahmad Fatoum >> --- >> common/b

Re: [PATCH] common: boards: wolfvision: use state_by_alias instead of opencoding

2024-05-14 Thread Michael Riesch
Hi Ahmad, Thanks a lot for your patch! On 5/15/24 08:07, Ahmad Fatoum wrote: > This introduces no functional change, but makes code a bit more compact. > > Cc: Michael Riesch > Signed-off-by: Ahmad Fatoum > --- > common/boards/wolfvision/common.c | 6 +- > 1 file changed, 1 insertion(+),

[PATCH master 2/2] pblimage: ls1028a: fix handling of short reads on

2024-05-14 Thread Ahmad Fatoum
Newer toolchains rightly complain: scripts/pblimage.c:259:17: error: ignoring return value of ‘read’ declared with attribute ‘warn_unused_result’ [-Werror=unused-result] 259 | read(in_fd, mem_buf + 0x1000, image_size); In the ls1046a case, this doesn't happen, because

[PATCH master 1/2] list: fix CONFIG_DEBUG_LIST link failure in PBL

2024-05-14 Thread Ahmad Fatoum
With the addition of PBL handoff data, we now use in PBL. This works fine with CONFIG_DEBUG_LIST disabled, because all functions are inlined, but when building with the option enabled, references to the out-of-line sanity checking functions breaks the build. Fix this by omitting these references

Re: [PATCH 1/2] usb:gadget:composite: add public functions for managing setup requests

2024-05-14 Thread Sascha Hauer
On Tue, 14 May 2024 15:03:26 +0200, Enrico Scholz wrote: > The composite driver does some bookkeeping about pending requests and > decides in its cleanup function whether requests must be dequeued. > > There are some function drivers (dfu, acm) which queue the requests > directly which causes e.

[PATCH] common: boards: wolfvision: use state_by_alias instead of opencoding

2024-05-14 Thread Ahmad Fatoum
This introduces no functional change, but makes code a bit more compact. Cc: Michael Riesch Signed-off-by: Ahmad Fatoum --- common/boards/wolfvision/common.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/common/boards/wolfvision/common.c b/common/boards/wolfvision/co

Re: [PATCH v2] ARM64: reloc: fix relocation error for big fat bareboxes

2024-05-14 Thread Sascha Hauer
On Mon, 13 May 2024 16:01:21 +0200, Ahmad Fatoum wrote: > A multi_v8 barebox with KASAN enabled is 2051804 bytes even after > compression and this breaks linking for me: > > arch/arm/cpu/common.o: in function `global_variable_offset': > arch/arm/include/asm/reloc.h:20:(.text.relocate_to_curr

Re: [PATCH master 1/3] mci: core: reset number of parttions on card probe failure

2024-05-14 Thread Sascha Hauer
On Mon, 13 May 2024 11:58:45 +0200, Ahmad Fatoum wrote: > mci_part_add records information about MMC hardware partitions and > increments mci->nr_parts by one afterwards. > If starting up the card succeeds, this information is then used to > call mci_register_partition for each added partition. >

[PATCH 2/2] usb:gadget: use helper function to queue composite requests

2024-05-14 Thread Enrico Scholz
From: Enrico Scholz Fixes bookkeeping in composite driver. Signed-off-by: Enrico Scholz --- drivers/usb/gadget/function/dfu.c | 2 +- drivers/usb/gadget/function/f_acm.c | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/function/dfu.c b/drivers/usb/

[PATCH 1/2] usb:gadget:composite: add public functions for managing setup requests

2024-05-14 Thread Enrico Scholz
From: Enrico Scholz The composite driver does some bookkeeping about pending requests and decides in its cleanup function whether requests must be dequeued. There are some function drivers (dfu, acm) which queue the requests directly which causes e.g. | :/ dfu /tmp/img(img)c | ... | g_multi gad