Re: [PATCH 1/7] I2C: i.MX: Add early i2c support for i.MX6

2023-01-23 Thread Marco Felsch
Hi John, thanks for your patch. albeit it is obvious we tend to have a small commit message here. The code change lgtm. Regards, Marco On 23-01-22, John Watts wrote: > Signed-off-by: John Watts > --- > drivers/i2c/busses/i2c-imx-early.c | 14 ++ > include/pbl/i2c.h

[PATCH v3 1/2] ARM: i.MX8MM: split barebox dts into dtsi file

2023-01-19 Thread Marco Felsch
Move the dts file into a dtsi file. This is in preparation for the imx8mm-evkb support which will reuse the config. No functional change. Signed-off-by: Marco Felsch --- v3: - new in this series arch/arm/dts/imx8mm-evk.dts | 54 + arch/arm/dts/imx8mm-evk.dtsi

[PATCH v3 2/2] ARM: i.MX8MM: add support for 8MMINILPD4-CPU2 board

2023-01-19 Thread Marco Felsch
...@pengutronix.de: Fix pmic configuration settings to align with u-boot] [m.fel...@pengutronix.de: Add dedicated dts support] [m.fel...@pengutronix.de: Include Ahmad's review feedback] Signed-off-by: Marco Felsch --- Hi, I pocked Johannes v2 [1] and added the review feedback from Ahmad. [1

Re: [PATCH v2 1/1] ARM: i.MX8M: add PCA9450 PMIC on rev-b EVK

2023-01-19 Thread Marco Felsch
On 23-01-11, Ahmad Fatoum wrote: > Hi, > > How do you generate your patches? Easiest is: > > git config sendemail.to barebox@lists.infradead.org > git send-email -3 --annotate > > This will take care to number the patches correctly. > > On 11.01.23 11:01, Johannes Schneider wrote: > >

Re: [PATCH 3/6] ARM: i.MX6: skov: refactor LVDS/parallel device tree fixups

2022-12-23 Thread Marco Felsch
On 22-12-22, Ahmad Fatoum wrote: > In preparation for a fix in a follow-up commit, refactor the code, so > each fixup is done in its own function. This enables easy early exists > without increasing indentation level. No functional change > > Signed-off-by: Ahmad Fatoum Rev

Re: [PATCH 1/6] clk: imx: set CLK_SET_RATE_NO_REPARENT for all muxes

2022-12-23 Thread Marco Felsch
On 22-12-22, Ahmad Fatoum wrote: > The Linux i.MX clk drivers instantiate all muxes with > CLK_SET_RATE_NO_REPARENT. Do likewise in barebox. > > Signed-off-by: Ahmad Fatoum Reviewed-by: Marco Felsch > --- > drivers/clk/imx/clk.h | 30 +++--- >

Re: [PATCH 6/6] ARM: configs: imx_v7_defconfig: enable some useful options

2022-12-23 Thread Marco Felsch
Hi Ahmad, On 22-12-22, Ahmad Fatoum wrote: > Give the defconfig some color by enabling console colors during startup, > i.MX6 parallel LCD driver, backlight and some more options that were > noticed missing during debugging a skov-imx6 issue. I'm okay with enabling a few command and the colored

Re: [PATCH 4/6] ARM: i.MX6: skov: fix LVDS deep probe

2022-12-23 Thread Marco Felsch
with: > > mode_name: invalid:0 (type: enum) > > Fixes: 31d2289da2f3 ("ARM: boards: skov-imx6: start using deep-probe") > Signed-off-by: Ahmad Fatoum Reviewed-by: Marco Felsch > --- > arch/arm/boards/skov-imx6/board.c | 7 --- > 1 file changed, 4 insertions(+), 3

Re: [PATCH 5/6] video: edid: print debug message on EDID read out error

2022-12-23 Thread Marco Felsch
Hi Ahmad, On 22-12-22, Ahmad Fatoum wrote: > EDID readout errors happen often, e.g. because the HDMI port doesn't > have a display connected. However, when a monitor is connected, but some > other error occurs, barebox is silent. Add a debug message with an error > code for this. > >

Re: [PATCH] common: deep-probe: write deep probe enabled message to log

2022-12-22 Thread Marco Felsch
On 22-12-22, Ahmad Fatoum wrote: > Hello Macro, > > On 22.12.22 16:47, Marco Felsch wrote: > > Hi Ahamd, > > > > thanks for your patch. > > > > On 22-12-22, Ahmad Fatoum wrote: > >> The "Deep probe supported due to" was not written t

Re: [PATCH] common: deep-probe: write deep probe enabled message to log

2022-12-22 Thread Marco Felsch
Hi Ahamd, thanks for your patch. On 22-12-22, Ahmad Fatoum wrote: > The "Deep probe supported due to" was not written to log and thus only > shown on startup and not in dmesg output. Make it available in both. > > Signed-off-by: Ahmad Fatoum > --- > common/deep-probe.c | 4 +++- > 1 file

Re: [PATCH 0/5] Rename some structs

2022-12-15 Thread Marco Felsch
gt; Rename struct fs_driver_d to fs_driver Reviewed-by: Marco Felsch > Documentation/devel/porting.rst | 3 +- > arch/arm/boards/animeo_ip/init.c | 4 +- > arch/arm/boards/at91sam9m10ihd/hw_version.c | 2 +- > arch/arm/boards/at91sam9x5ek/hw_version.c

Re: [PATCH 1/3] driver: support Linux device/driver OF struct member names

2022-12-09 Thread Marco Felsch
s use the Linux naming, we could drop the union > again. Nice :) > Signed-off-by: Ahmad Fatoum Reviewed-by: Marco Felsch > --- > include/driver.h | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/include/driver.h b/include/driver.h >

[PATCH] pbl: set IMAGE_COMPRESSION per default to lz4

2022-12-06 Thread Marco Felsch
://lore.kernel.org/all/20220524152401.1663317-9-ross.bur...@arm.com/ [2] https://lore.barebox.org/barebox/20220713100922.1880282-1-a.fat...@pengutronix.de/ [3] https://lkml.org/lkml/2020/7/1/848 Signed-off-by: Marco Felsch --- pbl/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] regulator: core: don't call of_regulator_get with NULL argument

2022-12-02 Thread Marco Felsch
> + if (dev->device_node && supply) { > ri = of_regulator_get(dev, supply); > if (IS_ERR(ri)) > return ERR_CAST(ri); Nevertheless the change is correct, so: Reviewed-by: Marco Felsch Regards, Marco > -- > 2.30.2 > > >

[PATCH] firmware: Makefile: fix firmware file dependency tracking

2022-12-01 Thread Marco Felsch
ware files. As result a firmware binary file update is not recognized by make and and won't make into the final binary. This commit fixes this and so an update will be recognized automatically without require a 'make clean' before. Fixes: 663894d99c64 ("firmware: refactor firmware/Makefile")

Re: [PATCH master] ARM: stm32mp: lxa-mc1: enable deep probe

2022-11-30 Thread Marco Felsch
Signed-off-by: Ahmad Fatoum Reviewed-by: Marco Felsch > --- > arch/arm/boards/lxa-mc1/board.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boards/lxa-mc1/board.c b/arch/arm/boards/lxa-mc1/board.c > index 9126973dcbdc..f8a7a6bd1f72 100644 > --- a/arch/ar

Re: [PATCH 14/14] imx-bbu-nand-fcb: Add fcb command

2022-11-02 Thread Marco Felsch
On 22-11-02, Sascha Hauer wrote: > On Wed, Nov 02, 2022 at 09:44:41AM +0100, Marco Felsch wrote: > > > +static void dump_fcb_n(struct fcb_block **fcbs, int n) > > > +{ > > > + int i; > > > + > > > + if (!n || !fcbs[n]) > > > +

Re: [PATCH 14/14] imx-bbu-nand-fcb: Add fcb command

2022-11-02 Thread Marco Felsch
Hi Sascha, On 22-11-01, Sascha Hauer wrote: > The FCB on NAND has a special page layout and thus can't be read with > the normal MTD driver. Add a fcb command for printing information about > the installed FCB on the console. > > Signed-off-by: Sascha Hauer > --- > commands/Kconfig |

Re: [PATCH 13/14] ARM: i.MX: xload nand: Implement i.MX7 support

2022-11-02 Thread Marco Felsch
Hi Sascha, On 22-11-01, Sascha Hauer wrote: > i.MX7 xload NAND support works like on i.MX6, but the FCB is in a > different format. The FCB page uses BCH62 ECC, has 8 ECC chunks with > 128 bytes each with a resulting total page size of 1862 bytes. Also > the page data is written with a pseudo

Re: [PATCH 12/14] ARM: i.MX: xload nand: Move mxs_nand_mode_fcb_62bit() to header file

2022-11-02 Thread Marco Felsch
Hi Sascha, On 22-11-01, Sascha Hauer wrote: > mxs_nand_mode_fcb_62bit() can be shared between the regular MTD NAND > driver and the upcoming i.MX7 xload driver. Move to header file. > > Signed-off-by: Sascha Hauer > --- > drivers/mtd/nand/nand_mxs.c | 34 ++ >

Re: [PATCH 08/14] ARM: i.MX: xload nand: Pull ECC status checking out of read page

2022-11-02 Thread Marco Felsch
Hi Sascha, On 22-11-01, Sascha Hauer wrote: > The read page code can be reused by upcoming i.MX7 support, but the ECC > checking will be different. Pull ECC status checking out of the read > page code to make that reusable on i.MX7. > > Signed-off-by: Sascha Hauer > --- >

Re: [PATCH 03/14] ARM: i.MX: xload nand: add common readid

2022-11-02 Thread Marco Felsch
Hi Sascha, On 22-11-01, Sascha Hauer wrote: > mxs_nand_check_onfi() and mxs_nand_read_id() setup the same DMA > descriptors with only a small difference. factor out a common > read_id function from it and share the code. > > Signed-off-by: Sascha Hauer > --- >

Re: [PATCH 02/14] ARM: i.MX: xload nand: Use common register defines

2022-11-02 Thread Marco Felsch
Hi Sascha, On 22-11-01, Sascha Hauer wrote: > We have a set of GPMI register defines in include/, so use them for the > xload driver as well. > > Signed-off-by: Sascha Hauer > --- > arch/arm/mach-imx/xload-gpmi-nand.c | 66 - > 1 file changed, 17 insertions(+), 49

Re: [PATCH 01/14] mtd: nand: nand-mxs: Move register definitions to separate file

2022-11-02 Thread Marco Felsch
Hi Sascha, On 22-11-01, Sascha Hauer wrote: > The GPMI registers are needed in the MTD GPMI driver and also in the > xload-gpmi driver. So far both use their own set of register defines. > Move the MTD GPMI register defines to include/ so that we can use them > in the xload driver as well. Nit:

Re: [PATCH] ARM: i.MX8M: atf: prefix log messages via pr_fmt()

2022-11-02 Thread Marco Felsch
On 22-11-01, Ahmad Fatoum wrote: > We have a couple of log messages in the file, so ensure they are > appropriately prefixed. > > Signed-off-by: Ahmad Fatoum > --- > arch/arm/mach-imx/atf.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/mach-imx/atf.c

[PATCH] ARM: dts: i.MX8MP: increase off-on delay on the SD Vcc regulator

2022-11-01 Thread Marco Felsch
lator") targeted Renesas SOCs. | | Signed-off-by: Andrey Zhizhikin | Cc: Stefano Babic Signed-off-by: Marco Felsch --- arch/arm/dts/imx8mp-evk.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/imx8mp-evk.dts b/arch/arm/dts/imx8mp-evk.dts index 3264ade4b8..

Re: [PATCH 1/2] ARM: imx8mm-evk: Switch to deep-probe

2022-10-24 Thread Marco Felsch
Hi Sascha, On 22-10-24, Sascha Hauer wrote: > Signed-off-by: Sascha Hauer > --- > arch/arm/boards/nxp-imx8mm-evk/board.c | 24 +++- > 1 file changed, 19 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boards/nxp-imx8mm-evk/board.c >

Re: [PATCH v2 6/7] RISC-V: squash 64bit defconfigs into rv64i_defconfig

2022-10-24 Thread Marco Felsch
Hi Antony, On 22-10-22, Antony Pavlov wrote: > On Wed, 5 Oct 2022 13:12:13 +0200 > Marco Felsch wrote: > > Hi Marco! > > It looks like this commit breaks emulate.pl, e.g. > > ARCH=riscv > ARCH=${ARCH} ./test/emulate.pl --kconfig-full --test -- > --junitxml

Re: [PATCH 4/8] state: cosmetic fix reverse christmas tree order

2022-10-19 Thread Marco Felsch
On 22-10-19, Sascha Hauer wrote: > On Fri, Oct 14, 2022 at 06:35:30PM +0200, Marco Felsch wrote: > > No functional change, just apply the common code standards. > > I didn't know these are common code standards for barebox ;) I thought that we are following the Linu

Re: [PATCH 2/8] state: select the STATE_DRV when STATE is selected

2022-10-19 Thread Marco Felsch
On 22-10-19, Sascha Hauer wrote: > On Fri, Oct 14, 2022 at 06:35:28PM +0200, Marco Felsch wrote: > > As written in the state.rst documentation, state will silently fail if > > the STATE_DRV is not selected. So enabling state without the state > > driver is useless.

[PATCH next 2/3] ARM: dts: i.MX8MP: assume hsio power domain to be powered

2022-10-17 Thread Marco Felsch
set this flag to tell barebox that everything is okay. Signed-off-by: Marco Felsch --- arch/arm/dts/imx8mp.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/imx8mp.dtsi b/arch/arm/dts/imx8mp.dtsi index b251ebeada..7e46a71546 100644 --- a/arch/arm/dts/imx8mp.dtsi +++ b/arch

[PATCH next 3/3] ARM: i.MX8M: align SIP_BUILDINFO with the tf-a define

2022-10-17 Thread Marco Felsch
Align the define with the name used by the usptream and downstream tf-a. While on change the pr_info behaviour to only print the version if a0 contain something useful. Signed-off-by: Marco Felsch --- arch/arm/mach-imx/imx8m.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions

[PATCH next 1/3] ARM: i.MX8MP: EVK: convert to board driver and enable deep-probe

2022-10-17 Thread Marco Felsch
Convert the driver to the board driver mechanism. While on it enable the deep-probe support and add a comment about the ENET1_RGMII_EN bit setting. Signed-off-by: Marco Felsch --- arch/arm/boards/nxp-imx8mp-evk/board.c | 21 - 1 file changed, 16 insertions(+), 5 deletions

Re: [PATCH 0/8] Barebox-State on-disk partition support

2022-10-14 Thread Marco Felsch
On 22-10-14, Marco Felsch wrote: > Hi, > > this small series adds the support to store the barebox-state on a > on-disk partition like mbr/gpt. Note for testing you need a very recent > dt-utils package. I will send the patches soon as well and will add a > link to the

[PATCH 0/8] Barebox-State on-disk partition support

2022-10-14 Thread Marco Felsch
Hi, this small series adds the support to store the barebox-state on a on-disk partition like mbr/gpt. Note for testing you need a very recent dt-utils package. I will send the patches soon as well and will add a link to the patches here later. Regards, Marco Marco Felsch (8

[PATCH 3/8] state: rename partition_node to backend_node

2022-10-14 Thread Marco Felsch
Rename the local variable in preparation of addding support for backends stored within a partition table. This also aligns the name with the name used by of_state_fixup(). No functional change. Signed-off-by: Marco Felsch --- common/state/state.c | 14 +++--- 1 file changed, 7

[PATCH 7/8] of: partition: add a helper to determin if a node is a of-partition

2022-10-14 Thread Marco Felsch
This helper checks if the given device_node is a of-partition. The check is based on the node name which should something like partition@xxx. If that fails the we try to check if the parent node contains a "fixed-partitions" compatible. Signed-off-by: Marco Felsch --- drivers/of/p

[PATCH 5/8] state: rename backend members

2022-10-14 Thread Marco Felsch
Rename backend members to drop the assumption that the backend always points to a partition. This is preperation work for the upcoming state partition table support which allows us to store the state within a MBR/GPT partition. Signed-off-by: Marco Felsch --- common/state/state.c | 17

[PATCH 8/8] state: add support for new backend format

2022-10-14 Thread Marco Felsch
s table are gone. For this feature a recent dt-utils package must be used, else you can't manipulate the state from user-space anymore. Signed-off-by: Marco Felsch --- .../bindings/barebox/barebox,state.rst| 30 ++- Documentation/user/state.rst | 12 ++- comm

[PATCH 2/8] state: select the STATE_DRV when STATE is selected

2022-10-14 Thread Marco Felsch
As written in the state.rst documentation, state will silently fail if the STATE_DRV is not selected. So enabling state without the state driver is useless. Fix this by selecting the STATE_DRV if STATE is selected. Signed-off-by: Marco Felsch --- common/Kconfig | 1 + 1 file changed, 1

[PATCH 6/8] state: factor out the backend property parsing

2022-10-14 Thread Marco Felsch
makes the code easier to read. Also remove the unnecessary ret initialization. Signed-off-by: Marco Felsch --- common/state/state.c | 55 ++-- 1 file changed, 38 insertions(+), 17 deletions(-) diff --git a/common/state/state.c b/common/state/state.c index

[PATCH 4/8] state: cosmetic fix reverse christmas tree order

2022-10-14 Thread Marco Felsch
No functional change, just apply the common code standards. Signed-off-by: Marco Felsch --- common/state/state.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/common/state/state.c b/common/state/state.c index d954f0d453..65e47524a3 100644

[PATCH 1/8] of: of_node_name_eq: correct alignment

2022-10-14 Thread Marco Felsch
Just a cleanup nothing special. Signed-off-by: Marco Felsch --- drivers/of/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index ea2a88764b..2eee1279a9 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -32,7 +32,7 @@ bool

Re: [PATCH master 0/3] Fix GCC 11 THUMB2 relocate_to_current_adr miscompile

2022-10-13 Thread Marco Felsch
Hi Ahmad, On 22-10-13, Ahmad Fatoum wrote: > TL;DR: GCC can prove that variables aren't supposed to overlap and as > such it generated code than readded get_runtime_offset() on top of an > already relocated linker-defined variable's address. > See PATCH 2/3 for a disassembly of the affected code.

[PATCH v2 1/7] RISC-V: cache: fix local_flush_icache_all enabling

2022-10-05 Thread Marco Felsch
9 ("RISC-V: support incoherent I-Cache") Signed-off-by: Marco Felsch --- arch/riscv/include/asm/cache.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/include/asm/cache.h b/arch/riscv/include/asm/cache.h index 9a0b9326b2..6d69ed49bd 100644 --- a/arch/riscv

[PATCH v2 2/7] RISC-V: add riscv_vendor_id() support

2022-10-05 Thread Marco Felsch
Add the support to query the vendorid which is stored within the mvendorid register. This register is only accessible from M-Mode so we need to use the sbi interface if we are running from S-Mode. Signed-off-by: Marco Felsch --- v2: - adapt switch-case to fix compile error. arch/riscv/include

[PATCH v2 5/7] RISC-V: implement cache-management errata for T-Head SoCs

2022-10-05 Thread Marco Felsch
the generic Zicbom extension. While on it replace the 'asm' statement by '__asm__' so we are not relying on GNU extension. Signed-off-by: Marco Felsch --- Hi, please note that I'm aware of the fact that not all RISC-V cores implementing the vendorid register, which is quirky according

[PATCH v2 6/7] RISC-V: squash 64bit defconfigs into rv64i_defconfig

2022-10-05 Thread Marco Felsch
This commit squashes all 64bit risc-v defconfigs into one like armv8. The 32bit defconfigs are not changed since those systems have tight resource constraints and a generic defconfig may break some systems. Signed-off-by: Marco Felsch --- v2: - new commit Documentation/boards/emulated.rst

[PATCH v2 7/7] RISC-V: add Allwinner Sun20i D1 Nezha support

2022-10-05 Thread Marco Felsch
Add Allwinner sun20i SoC and D1-Nezha board support. Signed-off-by: Marco Felsch --- v2: - drop own defconfig instead use the new rv64i_defconfig Documentation/boards/riscv.rst| 102 ++ arch/riscv/Kconfig.socs | 16 arch/riscv/boards

[PATCH v2 4/7] RISC-V: use m/sscratch registers for barebox_riscv_pbl_flags

2022-10-05 Thread Marco Felsch
by the relocation code. This commit prepares barebox to add support for the special cache ops used by several T-Head CPUs. Signed-off-by: Marco Felsch --- v2: - adapt switch-case to fix compile error arch/riscv/boot/entry.c | 3 +- arch/riscv/boot/entry.h | 6 ++-- arch/riscv

[PATCH v2 3/7] RISC-V: import vendorid list from linux

2022-10-05 Thread Marco Felsch
Import the vendor id list from upstream linux. Signed-off-by: Marco Felsch --- arch/riscv/include/asm/vendorid_list.h | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 arch/riscv/include/asm/vendorid_list.h diff --git a/arch/riscv/include/asm/vendorid_list.h b/arch/riscv

Re: [PATCH master] ARM: i.MX7: enable caches when booted over USB

2022-10-04 Thread Marco Felsch
Hi, On 22-09-30, Johannes Zink wrote: > From: Ahmad Fatoum > > BootROM on the i.MX7 doesn't set the SMP bit when booted > over serial download. This leads to vastly worse performance > when doing memory-heavy operations in a USB-booted system, > as the caches are not utilized. Example running

Re: [PATCH 1/2] ddr: imx8m: write fsp_table entry automatically

2022-09-22 Thread Marco Felsch
On 22-09-22, Sascha Hauer wrote: > On Wed, Sep 21, 2022 at 07:20:51PM +0200, Marco Felsch wrote: > > Currently the fsp_table must be set manually within the 'struct > > dram_timing_info'. Since the 'struct fsp_msg' already has all > > information needed for the fsp_table

[PATCH 1/2] ddr: imx8m: write fsp_table entry automatically

2022-09-21 Thread Marco Felsch
Currently the fsp_table must be set manually within the 'struct dram_timing_info'. Since the 'struct fsp_msg' already has all information needed for the fsp_table we can use it to set it automatically. This approach is less error-prone and avoids information duplication. Signed-off-by: Marco

[PATCH 2/2] ARM: i.MX8M: remove fsp_table entry

2022-09-21 Thread Marco Felsch
Barebox now have the support to write the fsp_table entries automatically based on fsp_msg.drata information. Remove the fsp_table entry and let the common code do the rest for us. Signed-off-by: Marco Felsch --- arch/arm/boards/mnt-reform/lpddr4-timing.c | 1 - arch/arm/boards/nxp-imx8mn

Re: [PATCH] net: Bring up all interfaces before going interactive

2022-09-20 Thread Marco Felsch
Hi Sascha, On 22-09-16, Sascha Hauer wrote: > So far we only bring up network interfaces when we actually need them. > This means we could be idling in the shell for long and once the user > decides to do networking he has to wait for the link to be established. > We can do better: Before going

Re: [PATCH 4/6] RISC-V: use m/sscratch registers for barebox_riscv_pbl_flags

2022-09-14 Thread Marco Felsch
On 22-09-14, Sascha Hauer wrote: > On Tue, Sep 13, 2022 at 02:49:52PM +0200, Marco Felsch wrote: > > Use the dedicated scratch register for setting the pbl flags. Each mode > > has it's own scratch register so we are not conflicting with M-mode > > running firmware e.g. OpenS

Re: [PATCH 6/6] RISC-V: add Allwinner Sun20i D1 Nezha support

2022-09-14 Thread Marco Felsch
On 22-09-14, Sascha Hauer wrote: > On Wed, Sep 14, 2022 at 09:52:37AM +0200, Marco Felsch wrote: > > On 22-09-14, Sascha Hauer wrote: > > > On Tue, Sep 13, 2022 at 02:49:54PM +0200, Marco Felsch wrote: > > > > Add Allwinner sun20i SoC and D1-Nezha board suppor

Re: [PATCH 6/6] RISC-V: add Allwinner Sun20i D1 Nezha support

2022-09-14 Thread Marco Felsch
On 22-09-14, Sascha Hauer wrote: > On Tue, Sep 13, 2022 at 02:49:54PM +0200, Marco Felsch wrote: > > Add Allwinner sun20i SoC and D1-Nezha board support. > > > > Signed-off-by: Marco Felsch > > --- > > Documentation/boards/riscv.rst| 102

[PATCH 2/6] RISC-V: add riscv_vendor_id() support

2022-09-13 Thread Marco Felsch
Add the support to query the vendorid which is stored within the mvendorid register. This register is only accessible from M-Mode so we need to use the sbi interface if we are running from S-Mode. Signed-off-by: Marco Felsch --- arch/riscv/include/asm/system.h | 31

[PATCH 0/6] RISC-V Allwinner D1 Support 2nd Stage Support

2022-09-13 Thread Marco Felsch
the vendorid register. Please see the patch notes on this patch. Patch 6 adds the support for the D1 board and a detailed description how to build and flash a bootable image. Marco Felsch (6): RISC-V: cache: fix local_flush_icache_all enabling RISC-V: add riscv_vendor_id() support RISC-V: import

[PATCH 5/6] RISC-V: implement cache-management errata for T-Head SoCs

2022-09-13 Thread Marco Felsch
the generic Zicbom extension. While on it replace the 'asm' statement by '__asm__' so we are not relying on GNU extension. Signed-off-by: Marco Felsch --- Hi, please note that I'm aware of the fact that not all RISC-V cores implementing the vendorid register, which is quirky according

[PATCH 6/6] RISC-V: add Allwinner Sun20i D1 Nezha support

2022-09-13 Thread Marco Felsch
Add Allwinner sun20i SoC and D1-Nezha board support. Signed-off-by: Marco Felsch --- Documentation/boards/riscv.rst| 102 + arch/riscv/Kconfig.socs | 16 +++ arch/riscv/boards/Makefile| 1 + arch/riscv/boards/allwinner-d1/Makefile

[PATCH 4/6] RISC-V: use m/sscratch registers for barebox_riscv_pbl_flags

2022-09-13 Thread Marco Felsch
by the relocation code. This commit prepares barebox to add support for the special cache ops used by several T-Head CPUs. Signed-off-by: Marco Felsch --- arch/riscv/boot/entry.c | 3 +- arch/riscv/boot/entry.h | 6 ++-- arch/riscv/boot/start.c | 13 +++ arch/riscv

[PATCH 1/6] RISC-V: cache: fix local_flush_icache_all enabling

2022-09-13 Thread Marco Felsch
9 ("RISC-V: support incoherent I-Cache") Signed-off-by: Marco Felsch --- arch/riscv/include/asm/cache.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/include/asm/cache.h b/arch/riscv/include/asm/cache.h index 9a0b9326b2..6d69ed49bd 100644 --- a/arch/riscv

[PATCH 3/6] RISC-V: import vendorid list from linux

2022-09-13 Thread Marco Felsch
Import the vendor id list from upstream linux. Signed-off-by: Marco Felsch --- arch/riscv/include/asm/vendorid_list.h | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 arch/riscv/include/asm/vendorid_list.h diff --git a/arch/riscv/include/asm/vendorid_list.h b/arch/riscv

Re: [PATCH v2] ARM: dts: i.MX8MM: describe feature controller

2022-08-30 Thread Marco Felsch
On 22-08-30, Ahmad Fatoum wrote: > Hello Marco, > > On 30.08.22 10:10, Marco Felsch wrote: > > Hi Ahamd, > > > > On 22-08-30, Ahmad Fatoum wrote: > >> Now with i.MX8M feature controller driver support available, have the > >> OCOTP provide feature c

Re: [PATCH v2] ARM: dts: i.MX8MM: describe feature controller

2022-08-30 Thread Marco Felsch
Hi Ahamd, On 22-08-30, Ahmad Fatoum wrote: > Now with i.MX8M feature controller driver support available, have the > OCOTP provide feature control on the i.MX8MM to ensure the kernel DT > does not cause Linux to access the VPU and its power domains, > when barebox knows them to be unavailable. >

Re: [PATCH 3/3] ARM: i.MX8M: define imx8mX_load_bl33 and imx8mX_load_and_start_tfa

2022-08-16 Thread Marco Felsch
Hi Ahmad, On 22-08-15, Ahmad Fatoum wrote: > For most users imx8mX_load_and_start_tfa saves a good deal of > boilerplate. It's not always sufficient though: > > - board code may need a pointer to bl33 to install other firmware > besides barebox proper from there before jumping to bl31

Re: [PATCH 1/2] of: implement of_append_property

2022-08-09 Thread Marco Felsch
Hi Ahmad, On 22-08-09, Ahmad Fatoum wrote: > board code fix up the device tree for OS consumption. Sometimes it's > useful for the fixup to append onto an existing property. > Add a helper that simplifies this. do you have a particular use-case for this? Regards, Marco > Signed-off-by: Ahmad

Re: [PATCH 0/9] ARM: i.MX8MN: clean up and enable imx-usb-loader

2022-08-08 Thread Marco Felsch
> i2c: add for PBL use > ARM: i.MX8M: use new pbl/pmic.h API Hi Ahmad, whole series LGTM. Reviewed-by: Marco Felsch > > arch/arm/boards/ls1046ardb/lowlevel.c | 6 +- > arch/arm/boards/mnt-reform/lowlevel.c | 28 +--- > arch/arm/boards/mnt-reform/

Re: [PATCH 07/12] imx-usb-loader: Add i.MX8MP support

2022-07-29 Thread Marco Felsch
Hi Sascha, please see below. On 22-07-14, Sascha Hauer wrote: > For the i.MX8MP NXP dropped the SDP protocol used on other SoCs. > Instead the image is just sent straight to the device. > > Signed-off-by: Sascha Hauer > --- > scripts/imx/imx-usb-loader.c | 37

Re: [PATCH] mci: add new MCI_BROKEN_CD option for testing

2022-07-20 Thread Marco Felsch
Hi Ahmad, On 22-07-20, Ahmad Fatoum wrote: > In remote labs co-located with other hardware, we've observed card > detect levers of different boards to sporadically fail to detect > the card, e.g. because the cable on the usbsdmux was yanked around > by accident. When this happens, barebox usually

[PATCH 4/4] ARM: i.MX8MN: pass along correct DT depending on variant

2022-07-06 Thread Marco Felsch
-by: Marco Felsch Signed-off-by: Marco Felsch --- arch/arm/boards/nxp-imx8mn-evk/board.c| 21 -- arch/arm/boards/nxp-imx8mn-evk/lowlevel.c | 13 +++- arch/arm/dts/Makefile | 2 +- arch/arm/dts/imx8mn-ddr4-evk.dts | 6 ++ arch/arm/dts/imx8mn-evk.dts

[PATCH 3/4] usb: chipidea: imx: call enable_clk after all resources are requested

2022-07-06 Thread Marco Felsch
ources are available. So the probability to leave the system in a partly initialized state is lesser. Drop the !IS_ERR() since NULL and errors are handled in clk_enable() as well. Signed-off-by: Marco Felsch --- drivers/usb/imx/chipidea-imx.c | 10 -- 1 file changed, 8 insertions(+), 2 del

[PATCH 2/4] phy: propagate error in of_phy_get_by_phandle

2022-07-06 Thread Marco Felsch
Don't return -ENODEV if of_phy_provider_lookup() fails instead propagate the error. So errors like -EPROBE_DEFER are propagated correctly. Signed-off-by: Marco Felsch --- drivers/phy/phy-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-core.c b/drivers

[PATCH 0/4] MX8MN-EVK DDR4 Support

2022-07-06 Thread Marco Felsch
: pass along correct DT depending on variant Marco Felsch (3): phy: fix deep probe support phy: propagate error in of_phy_get_by_phandle usb: chipidea: imx: call enable_clk after all resources are requested arch/arm/boards/nxp-imx8mn-evk/board.c| 21 -- arch/arm/boards/nxp-imx8mn-evk

[PATCH 1/4] phy: fix deep probe support

2022-07-06 Thread Marco Felsch
ets called by both functions. Signed-off-by: Marco Felsch --- drivers/phy/phy-core.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c index b298da..ef7bd76648 100644 --- a/drivers/phy/phy-core.c +++ b/drivers/phy/

[PATCH] console: add new CONSOLE_FULL_BUFFERSIZE option

2022-07-06 Thread Marco Felsch
Make the early printk buffer size adjustable since I noticed truncated log buffers if I enable DEBUG_INITCALLS and DEBUG_PROBES. Signed-off-by: Marco Felsch --- common/Kconfig | 15 +++ common/console.c | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/common

Re: [PATCH] ARM: i.MX8MM: Consolidate common code to load image and jump to it via TF-A

2022-07-06 Thread Marco Felsch
Hi Uwe, thanks for the patch. On 22-07-06, Uwe Kleine-König wrote: ... > @@ -96,11 +92,6 @@ extern struct dram_timing_info imx8mm_evk_dram_timing; > > static void start_atf(void) > { > - size_t bl31_size; > - const u8 *bl31; > - enum bootsource src; > - int instance; > - >

[PATCH v3] ARM: i.MX8MP: adapt atf bl31 base address

2022-07-04 Thread Marco Felsch
adapts the documentation for the i.MX8MP-EVK to reference the upstream TF-A and to point out our favorite version. Signed-off-by: Marco Felsch --- Changelog: v3: - rephrase the complete commit message. Sry. again for the previouse noise. v2: - fix commit message ger/eng mixup and mention tapeout

[PATCH] ARM: i.MX8MN: fix phy-reset gpio

2022-07-04 Thread Marco Felsch
Drop the Barebox local 'phy-reset-gpios' property since the upstream/linux device-tree is handling it now within the ethernet-phy node and we get an error: gpiolib: _gpio_request: gpio-118 (ethernet-phy@0) status -16 miibus0: failed to request reset gpio for: ethernet-phy@0 Signed-off-by: Marco

Re: [PATCH v2] ARM: i.MX8MP: adapt atf bl31 base addr

2022-07-04 Thread Marco Felsch
On 22-07-04, Lucas Stach wrote: > Am Montag, dem 04.07.2022 um 16:27 +0200 schrieb Marco Felsch: > > The usptream TF-A was shifting around the base address from version to > > version. But finally with upstream TF-A v2.7 it is correctly set to > > 0x97. This change was

[PATCH v2] ARM: i.MX8MP: adapt atf bl31 base addr

2022-07-04 Thread Marco Felsch
the upstream TF-A. The new warning should point out that we strongly recommended to use versions from v2.7 onwards, due to the version mess explained above. Signed-off-by: Marco Felsch --- Changelog: v2: - fix commit message ger/eng mixup and mention tapeout version A1 Documentation/boards/imx

Re: [PATCH] ARM: i.MX8MP: adapt atf bl31 base addr

2022-07-04 Thread Marco Felsch
On 22-07-04, Lucas Stach wrote: > Am Montag, dem 04.07.2022 um 14:33 +0200 schrieb Marco Felsch: > > The usptream TF-A was shifting around the base address from version to > > version. But finally with upstream TF-A v2.7 it is correctly set to > > 0x97. This change was

[PATCH] common: bootm: print error in case of appendroot failed

2022-07-04 Thread Marco Felsch
Inform the user that appendroot failed instead of silently dropping the request. This makes the debugging easier e.g. if nt-signature wasn't set correctly. Signed-off-by: Marco Felsch --- common/bootm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/bootm.c b/common/bootm.c index

[PATCH] ARM: i.MX8MP: adapt atf bl31 base addr

2022-07-04 Thread Marco Felsch
warning should point out that we strongly recommended to use versions from v2.7 onwards, due to the version mess explained above. Signed-off-by: Marco Felsch --- Documentation/boards/imx/nxp-imx8mp-evk.rst | 11 +++ arch/arm/mach-imx/include/mach/atf.h| 2 +- 2 files changed, 8

Re: [PATCH 1/9] ARM: boards: protonic-imx6: prtvt7 hardkey inputs are active low

2022-06-17 Thread Marco Felsch
On 22-06-17, Sascha Hauer wrote: > On Thu, Jun 16, 2022 at 06:38:45PM +0200, Oleksij Rempel wrote: > > Am 16.06.22 um 18:28 schrieb Oleksij Rempel: > > > Hi Robin, > > > > > > On Thu, Jun 16, 2022 at 03:11:06PM +0200, Robin van der Gracht wrote: > > > > The usb check needs to be skipped unless

[PATCH 1/2] regulator: fixed: use local device_node reference

2022-06-16 Thread Marco Felsch
Just a cosmetic commit, no functional changes. Use a local variable for the device_node instead of dereference the pointer multiple times. Signed-off-by: Marco Felsch --- drivers/regulator/fixed.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/regulator

[PATCH 2/2] regulator: fixed: add off-on-delay-us device-tree parsing support

2022-06-16 Thread Marco Felsch
The core already handles the off_on_delay if we set it. So parse the official device-tree property and set it if present. Signed-off-by: Marco Felsch --- drivers/regulator/fixed.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c index

[PATCH 2/2] clk: imx8mn: remove SYS PLL 1/2 clock gates

2022-06-16 Thread Marco Felsch
166-3-peng@oss.nxp.com | Signed-off-by: Abel Vesa Unlike the original patch this one also makes sure that the removed gates are enabled as they are needed for their consumers. Signed-off-by: Marco Felsch --- drivers/clk/imx/clk-imx8mn.c | 65 ++-- 1 file c

[PATCH 1/2] clk: imx8mm: remove SYS PLL 1/2 clock gates

2022-06-16 Thread Marco Felsch
166-2-peng@oss.nxp.com | Signed-off-by: Abel Vesa Unlike the original patch this one also makes sure that the removed gates are enabled as they are needed for their consumers. Signed-off-by: Marco Felsch --- drivers/clk/imx/clk-imx8mm.c | 65 ++-- 1 file c

[PATCH 1/2] ARM: i.MX8MM: fix phy-reset gpio

2022-06-16 Thread Marco Felsch
Drop the Barebox local property since the upstream/linux device-tree is handling it now within the phy and we get an error: ERROR: gpiolib: _gpio_request: gpio-118 (ethernet-phy@0) status -16 ERROR: miibus0: failed to request reset gpio for: ethernet-phy@0 Signed-off-by: Marco Felsch

[PATCH 2/2] ARM: i.MX8MM: increase off-on delay on the SD Vcc regulator

2022-06-16 Thread Marco Felsch
Cc: Stefano Babic 8<----- Signed-off-by: Marco Felsch --- arch/arm/dts/imx8mm-evk.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/imx8mm-evk.dts b/arch/arm/dts/imx8mm-evk.dts index 854e9db869..6c06ad7e47 100644 --- a/arch/arm/dts/imx8mm-

Re: [PATCH] ARM: DTS: myir-x335x: Add GPIO aliases

2022-05-25 Thread Marco Felsch
On 22-05-24, Ahmad Fatoum wrote: > Hi, > > On 24.05.22 09:30, Alexander Shiyan wrote: > > For the correct work of GPIO driver, we need to define aliases. > > Let's add them to the devicetree. > > > > Signed-off-by: Alexander Shiyan > > --- > > arch/arm/dts/am335x-myirtech-myd.dts | 7 +++ >

Re: [PATCH] ARM: DTS: myir-x335x: Add GPIO aliases

2022-05-24 Thread Marco Felsch
On 22-05-24, Alexander Shiyan wrote: > вт, 24 мая 2022 г. в 12:03, Marco Felsch : > > On 22-05-24, Alexander Shiyan wrote: > > > For the correct work of GPIO driver, we need to define aliases. > > > Let's add them to the devicetree. > ... > > > +

Re: [PATCH] ARM: DTS: myir-x335x: Add GPIO aliases

2022-05-24 Thread Marco Felsch
On 22-05-24, Alexander Shiyan wrote: > For the correct work of GPIO driver, we need to define aliases. > Let's add them to the devicetree. > > Signed-off-by: Alexander Shiyan > --- > arch/arm/dts/am335x-myirtech-myd.dts | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

Re: [PATCH] usb: usb251xb: remove duplicate status line on probe success

2022-05-23 Thread Marco Felsch
On 22-05-23, Ahmad Fatoum wrote: > On 23.05.22 10:22, Marco Felsch wrote: > > On 22-05-23, Ahmad Fatoum wrote: > >> Hello Marco, > >> > >> On 23.05.22 10:00, Marco Felsch wrote: > >>> Hi Ahmad, > >>> > >>> On 22-05-23, A

Re: [PATCH] usb: usb251xb: remove duplicate status line on probe success

2022-05-23 Thread Marco Felsch
On 22-05-23, Ahmad Fatoum wrote: > Hello Marco, > > On 23.05.22 10:00, Marco Felsch wrote: > > Hi Ahmad, > > > > On 22-05-23, Ahmad Fatoum wrote: > >> A successful probe results in two lines logged: > >> > >> usb251xb usb2514b0: Hub co

<    1   2   3   4   5   6   7   8   >