Re: [PATCH] i2c: add Atmel AT91 driver

2014-07-24 Thread Sascha Hauer
Hi Raphaël, Looks mostly fine to me. Two small comments: On Wed, Jul 23, 2014 at 12:09:04PM -0700, Raphaël Poggi wrote: + +static int at91_twi_probe(struct device_d *dev) +{ + struct at91_twi_dev *i2c_at91; + struct at91_twi_pdata *i2c_data; + int rc; + u32 bus_clk_rate;

Re: [PATCH] i2c: add Atmel AT91 driver

2014-07-24 Thread Raphaël Poggi
Hi Sascha, Thanks for your review, I'll correct these and send a v2. Raphaël 2014-07-24 11:34 GMT+02:00 Sascha Hauer s.ha...@pengutronix.de: Hi Raphaël, Looks mostly fine to me. Two small comments: On Wed, Jul 23, 2014 at 12:09:04PM -0700, Raphaël Poggi wrote: + +static int

[PATCH] i2c: add Atmel AT91 driver

2014-07-23 Thread Raphaël Poggi
Signed-off-by: Raphaël Poggi poggi.r...@gmail.com --- drivers/i2c/busses/Kconfig| 4 + drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-at91.c | 438 ++ 3 files changed, 443 insertions(+) create mode 100644 drivers/i2c/busses/i2c-at91.c