Re: [PATCH 02/25] usb: xhci-hcd: Do not zero out DMA coherent memory

2019-02-20 Thread Andrey Smirnov
On Wed, Feb 20, 2019 at 1:29 AM Yann Sionneau wrote: > > I'm not sure dma_alloc_coherent() should return zeroed out memory. > > I'm pretty sure it does not. > > mips arch seems to memset it to 0, but not all arch do that. > It is definitely the semantics in latest kernel code, see e.g. here:

Re: [PATCH 02/25] usb: xhci-hcd: Do not zero out DMA coherent memory

2019-02-20 Thread Yann Sionneau
I'm not sure dma_alloc_coherent() should return zeroed out memory. I'm pretty sure it does not. mips arch seems to memset it to 0, but not all arch do that. On 2/20/19 8:29 AM, Andrey Smirnov wrote: Memory returned by dma_alloc_coherent() should already be zeroed out, so there's no need to do

[PATCH 02/25] usb: xhci-hcd: Do not zero out DMA coherent memory

2019-02-19 Thread Andrey Smirnov
Memory returned by dma_alloc_coherent() should already be zeroed out, so there's no need to do this explicitly. Signed-off-by: Andrey Smirnov --- drivers/usb/host/xhci-hcd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/host/xhci-hcd.c b/drivers/usb/host/xhci-hcd.c index