Re: [PATCH 1/2] Add initial regulator support

2014-04-28 Thread Alexander Aring
On Mon, Apr 28, 2014 at 10:00:30PM +0200, Sascha Hauer wrote: > On Mon, Apr 28, 2014 at 08:51:21PM +0200, Alexander Aring wrote: > > Hi, > > > > On Mon, Apr 28, 2014 at 08:47:02PM +0200, Sascha Hauer wrote: > > > > > > I think both functions should return 0 without a valid gpio instead. > > > Any

Re: [PATCH 1/2] Add initial regulator support

2014-04-28 Thread Sascha Hauer
On Mon, Apr 28, 2014 at 08:51:21PM +0200, Alexander Aring wrote: > Hi, > > On Mon, Apr 28, 2014 at 08:47:02PM +0200, Sascha Hauer wrote: > > > > I think both functions should return 0 without a valid gpio instead. > > Anyway, there's something wrong here. > > > > maybe checking on this at probe

Re: [PATCH 1/2] Add initial regulator support

2014-04-28 Thread Alexander Aring
Hi, On Mon, Apr 28, 2014 at 08:47:02PM +0200, Sascha Hauer wrote: > > I think both functions should return 0 without a valid gpio instead. > Anyway, there's something wrong here. > maybe checking on this at probe time, at the beginning or can this gpio changed at runtime? Maybe you don't need

Re: [PATCH 1/2] Add initial regulator support

2014-04-28 Thread Sascha Hauer
On Mon, Apr 28, 2014 at 06:30:19PM +0200, Alexander Aring wrote: > Hi Sascha, > > On Mon, Apr 28, 2014 at 10:18:40AM +0200, Sascha Hauer wrote: > > Provide minimal regulator support. Only supported operations are enabling > > and disabling regulators. Association of devices with their regulators i

Re: [PATCH 1/2] Add initial regulator support

2014-04-28 Thread Alexander Aring
On Mon, Apr 28, 2014 at 06:30:15PM +0200, Alexander Aring wrote: > Hi Sascha, > > On Mon, Apr 28, 2014 at 10:18:40AM +0200, Sascha Hauer wrote: > > Provide minimal regulator support. Only supported operations are enabling > > and disabling regulators. Association of devices with their regulators i

Re: [PATCH 1/2] Add initial regulator support

2014-04-28 Thread Alexander Aring
Hi Sascha, On Mon, Apr 28, 2014 at 10:18:40AM +0200, Sascha Hauer wrote: > Provide minimal regulator support. Only supported operations are enabling > and disabling regulators. Association of devices with their regulators is > limited to devicetree only. If regulator support is disabled the API ex

[PATCH 1/2] Add initial regulator support

2014-04-28 Thread Sascha Hauer
Provide minimal regulator support. Only supported operations are enabling and disabling regulators. Association of devices with their regulators is limited to devicetree only. If regulator support is disabled the API expands to static inline stubs so consumers can still use the API. Signed-off-by: