Re: [PATCH 1/2] serial: efi-stdio: replace globals with handles in priv struct

2019-10-23 Thread Sascha Hauer
On Mon, Oct 21, 2019 at 11:23:40AM +0200, Ahmad Fatoum wrote: > Despite assigning efi_sys_table->{con_in,con_out} to priv->{in,out}, > some functions still use the global efi_sys_table->{con_in,con_out}. > Let's restrict globals access to the probe function and have the priv > struct completely

[PATCH 1/2] serial: efi-stdio: replace globals with handles in priv struct

2019-10-21 Thread Ahmad Fatoum
Despite assigning efi_sys_table->{con_in,con_out} to priv->{in,out}, some functions still use the global efi_sys_table->{con_in,con_out}. Let's restrict globals access to the probe function and have the priv struct completely describe input and output used in the callbacks. No functional change.