Re: [PATCH 2/4] ARM: at91: debug_ll: make UART base address configurable

2019-02-26 Thread Ahmad Fatoum
Hello Sascha, On 20/2/19 08:55, Sascha Hauer wrote: > On Tue, Feb 19, 2019 at 10:10:02PM +0100, Ahmad Fatoum wrote: >> Hello Sam, >> >> On 19/2/19 21:42, Sam Ravnborg wrote: >>> Hi Ahmad. >>> >>> On Tue, Feb 19, 2019 at 01:06:10PM +0100, Ahmad Fatoum wrote: This is in line with other

Re: [PATCH 2/4] ARM: at91: debug_ll: make UART base address configurable

2019-02-19 Thread Sascha Hauer
On Tue, Feb 19, 2019 at 10:10:02PM +0100, Ahmad Fatoum wrote: > Hello Sam, > > On 19/2/19 21:42, Sam Ravnborg wrote: > > Hi Ahmad. > > > > On Tue, Feb 19, 2019 at 01:06:10PM +0100, Ahmad Fatoum wrote: > >> This is in line with other platforms such as i.MX, which allow > >> specifying a debug

Re: [PATCH 2/4] ARM: at91: debug_ll: make UART base address configurable

2019-02-19 Thread Sam Ravnborg
Hi Ahmad. > I think it should remain build-time configurable, to account for cases > such as when the designated debug port isn't usable for whatever reason > (e.g. its exposed via a USB-to-UART bridge and you want to use a proper > UART, because you hate that the disconnection on power cycle..).

Re: [PATCH 2/4] ARM: at91: debug_ll: make UART base address configurable

2019-02-19 Thread Ahmad Fatoum
Hello, On 19/2/19 22:10, Ahmad Fatoum wrote: > Hello Sam, > > On 19/2/19 21:42, Sam Ravnborg wrote: >> Hi Ahmad. >> >> On Tue, Feb 19, 2019 at 01:06:10PM +0100, Ahmad Fatoum wrote: >>> This is in line with other platforms such as i.MX, which allow >>> specifying a debug port. As we can't use

Re: [PATCH 2/4] ARM: at91: debug_ll: make UART base address configurable

2019-02-19 Thread Ahmad Fatoum
Hello Sam, On 19/2/19 21:42, Sam Ravnborg wrote: > Hi Ahmad. > > On Tue, Feb 19, 2019 at 01:06:10PM +0100, Ahmad Fatoum wrote: >> This is in line with other platforms such as i.MX, which allow >> specifying a debug port. As we can't use port indices because >> the UARTs aren't mapped

Re: [PATCH 2/4] ARM: at91: debug_ll: make UART base address configurable

2019-02-19 Thread Sam Ravnborg
Hi Ahmad. On Tue, Feb 19, 2019 at 01:06:10PM +0100, Ahmad Fatoum wrote: > This is in line with other platforms such as i.MX, which allow > specifying a debug port. As we can't use port indices because > the UARTs aren't mapped consecutively, allow specifying a hex > base at configuration time. >

[PATCH 2/4] ARM: at91: debug_ll: make UART base address configurable

2019-02-19 Thread Ahmad Fatoum
This is in line with other platforms such as i.MX, which allow specifying a debug port. As we can't use port indices because the UARTs aren't mapped consecutively, allow specifying a hex base at configuration time. A side effect of this patch is that sama5d4's HAVE_AT91_DBGU2 is now honored as