Re: [PATCH 7/8] i.MX: serial: Distil common clock ungating code

On Sat, May 02, 2015 at 07:26:19PM -0700, Andrey Smirnov wrote: Move all of the common clock ungating code in early UART initialization into a dedicated subroutine that can be shared by all of the users. Signed-off-by: Andrey Smirnov andrew.smir...@gmail.com ---

Re: [PATCH 7/8] i.MX: serial: Distil common clock ungating code

Please add a imx6_ namespace to this function. The calling code always knows that it is running on imx6, so you can use IMX6_CCM_BASE_ADDR directly rather than using soc##_. The function above is imx6 specific anyway since only this SoC has the gate registers on 0x68..0x80. What about i.MX51?

Re: [PATCH 7/8] i.MX: serial: Distil common clock ungating code

On Mon, May 04, 2015 at 11:04:25AM -0700, Andrey Smirnov wrote: Please add a imx6_ namespace to this function. The calling code always knows that it is running on imx6, so you can use IMX6_CCM_BASE_ADDR directly rather than using soc##_. The function above is imx6 specific anyway since

[PATCH 7/8] i.MX: serial: Distil common clock ungating code

Move all of the common clock ungating code in early UART initialization into a dedicated subroutine that can be shared by all of the users. Signed-off-by: Andrey Smirnov andrew.smir...@gmail.com --- arch/arm/boards/freescale-mx6sx-sabresdb/lowlevel.c | 9 +