Re: [PATCH v2 01/19] ARM: i.MX: boot: Coalesce copy-pasted code

2018-04-19 Thread Andrey Smirnov
On Wed, Apr 18, 2018 at 1:15 AM, Sascha Hauer wrote: > On Tue, Apr 17, 2018 at 08:20:46AM -0700, Andrey Smirnov wrote: >> On Mon, Apr 16, 2018 at 11:58 PM, Sascha Hauer >> wrote: >> > On Mon, Apr 16, 2018 at 12:31:39PM -0700, Andrey Smirnov wrote:

Re: [PATCH v2 01/19] ARM: i.MX: boot: Coalesce copy-pasted code

2018-04-18 Thread Sascha Hauer
On Tue, Apr 17, 2018 at 08:20:46AM -0700, Andrey Smirnov wrote: > On Mon, Apr 16, 2018 at 11:58 PM, Sascha Hauer wrote: > > On Mon, Apr 16, 2018 at 12:31:39PM -0700, Andrey Smirnov wrote: > >> All of the instances of imx*_boot_save_loc() do exactly the same thing with > >>

Re: [PATCH v2 01/19] ARM: i.MX: boot: Coalesce copy-pasted code

2018-04-17 Thread Andrey Smirnov
On Mon, Apr 16, 2018 at 11:58 PM, Sascha Hauer wrote: > On Mon, Apr 16, 2018 at 12:31:39PM -0700, Andrey Smirnov wrote: >> All of the instances of imx*_boot_save_loc() do exactly the same thing with >> the only difference being SoC-specific imx*_get_boot_source >> call.

Re: [PATCH v2 01/19] ARM: i.MX: boot: Coalesce copy-pasted code

2018-04-17 Thread Sascha Hauer
On Mon, Apr 16, 2018 at 12:31:39PM -0700, Andrey Smirnov wrote: > All of the instances of imx*_boot_save_loc() do exactly the same thing with > the only difference being SoC-specific imx*_get_boot_source > call. Convert the code into a generic function taking function pointer > + a macro to take

[PATCH v2 01/19] ARM: i.MX: boot: Coalesce copy-pasted code

2018-04-16 Thread Andrey Smirnov
All of the instances of imx*_boot_save_loc() do exactly the same thing with the only difference being SoC-specific imx*_get_boot_source call. Convert the code into a generic function taking function pointer + a macro to take care of the boilerplate. Signed-off-by: Andrey Smirnov