Re: [PATCH v2 07/28] ARM: mmu: Separate index and address in create_sections()

2018-05-16 Thread Andrey Smirnov
On Wed, May 16, 2018 at 1:52 PM, Sam Ravnborg wrote: > On Wed, May 16, 2018 at 01:00:15PM -0700, Andrey Smirnov wrote: >> Both TTB index and address used to fill that entry are derived from >> the same variable 'addr' which requires shifting right and left by 20 >> and somewhat

Re: [PATCH v2 07/28] ARM: mmu: Separate index and address in create_sections()

2018-05-16 Thread Sam Ravnborg
On Wed, May 16, 2018 at 01:00:15PM -0700, Andrey Smirnov wrote: > Both TTB index and address used to fill that entry are derived from > the same variable 'addr' which requires shifting right and left by 20 > and somewhat confusing. > > Split the counter used to iterate over elements of TTB into

[PATCH v2 07/28] ARM: mmu: Separate index and address in create_sections()

2018-05-16 Thread Andrey Smirnov
Both TTB index and address used to fill that entry are derived from the same variable 'addr' which requires shifting right and left by 20 and somewhat confusing. Split the counter used to iterate over elements of TTB into a separate variable to make this code a bit easier to read.