Re: [PATCH v2 2/4] watchdog: implement generic support for .running device parameter

2019-11-08 Thread Ahmad Fatoum
On 11/5/19 12:18 PM, Sascha Hauer wrote: > On Tue, Nov 05, 2019 at 12:10:51PM +0100, Ahmad Fatoum wrote: >> On 11/5/19 11:46 AM, Ahmad Fatoum wrote: >>> Hi, >>> >>> On 11/5/19 11:40 AM, Sascha Hauer wrote: When we just started the watchdog we actually know that it is running, so we could

Re: [PATCH v2 2/4] watchdog: implement generic support for .running device parameter

2019-11-05 Thread Sascha Hauer
On Tue, Nov 05, 2019 at 12:10:51PM +0100, Ahmad Fatoum wrote: > On 11/5/19 11:46 AM, Ahmad Fatoum wrote: > > Hi, > > > > On 11/5/19 11:40 AM, Sascha Hauer wrote: > >> When we just started the watchdog we actually know that it is running, > >> so we could support the parameter for all watchdogs

Re: [PATCH v2 2/4] watchdog: implement generic support for .running device parameter

2019-11-05 Thread Ahmad Fatoum
On 11/5/19 11:46 AM, Ahmad Fatoum wrote: > Hi, > > On 11/5/19 11:40 AM, Sascha Hauer wrote: >> When we just started the watchdog we actually know that it is running, >> so we could support the parameter for all watchdogs once it's started. I'll do this. >> Casting p->value to (struct watchdog

Re: [PATCH v2 2/4] watchdog: implement generic support for .running device parameter

2019-11-05 Thread Sascha Hauer
On Tue, Nov 05, 2019 at 11:46:18AM +0100, Ahmad Fatoum wrote: > Hi, > > On 11/5/19 11:40 AM, Sascha Hauer wrote: > > Hi Ahmad, > > > > On Mon, Nov 04, 2019 at 11:14:05PM +0100, Ahmad Fatoum wrote: > >> Linux watchdog have an optional WDOG_HW_RUNNING bit that is used in > >> conjunction with

Re: [PATCH v2 2/4] watchdog: implement generic support for .running device parameter

2019-11-05 Thread Ahmad Fatoum
Hi, On 11/5/19 11:40 AM, Sascha Hauer wrote: > Hi Ahmad, > > On Mon, Nov 04, 2019 at 11:14:05PM +0100, Ahmad Fatoum wrote: >> Linux watchdog have an optional WDOG_HW_RUNNING bit that is used in >> conjunction with CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED to automatically >> ping running watchdogs

Re: [PATCH v2 2/4] watchdog: implement generic support for .running device parameter

2019-11-05 Thread Sascha Hauer
Hi Ahmad, On Mon, Nov 04, 2019 at 11:14:05PM +0100, Ahmad Fatoum wrote: > Linux watchdog have an optional WDOG_HW_RUNNING bit that is used in > conjunction with CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED to automatically > ping running watchdogs until userspace takes over. > > So far, when we ported

[PATCH v2 2/4] watchdog: implement generic support for .running device parameter

2019-11-04 Thread Ahmad Fatoum
Linux watchdog have an optional WDOG_HW_RUNNING bit that is used in conjunction with CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED to automatically ping running watchdogs until userspace takes over. So far, when we ported Linux drivers, we dropped this detection, but it would be useful to have this