Re: [PATCH v3 04/15] ARM: at91: replace at91sam9_ddrsdr.h with at91bootstrap's at91_ddrsdrc.h

2019-04-03 Thread Ahmad Fatoum
Hi, On 2/4/19 21:18, Sam Ravnborg wrote: > Hi Ahmad. > >>> >>> If we introduced the following small helpers we could simplify the call >>> sites >>> to just use at91_get_ddram_size(AT91SAM9G45_BASE_DDRSDRC0) and similar. >>> >>> static inline u32 at91_get_ddram_size(void __force __iomem * addr)

Re: [PATCH v3 04/15] ARM: at91: replace at91sam9_ddrsdr.h with at91bootstrap's at91_ddrsdrc.h

2019-04-03 Thread Sascha Hauer
On Tue, Apr 02, 2019 at 09:18:37PM +0200, Sam Ravnborg wrote: > Hi Ahmad. > > > > > > > If we introduced the following small helpers we could simplify the call > > > sites > > > to just use at91_get_ddram_size(AT91SAM9G45_BASE_DDRSDRC0) and similar. > > > > > > static inline u32

Re: [PATCH v3 04/15] ARM: at91: replace at91sam9_ddrsdr.h with at91bootstrap's at91_ddrsdrc.h

2019-04-02 Thread Sam Ravnborg
Hi Ahmad. > > > > If we introduced the following small helpers we could simplify the call > > sites > > to just use at91_get_ddram_size(AT91SAM9G45_BASE_DDRSDRC0) and similar. > > > > static inline u32 at91_get_ddram_size(void __force __iomem * addr) > > { > > return

Re: [PATCH v3 04/15] ARM: at91: replace at91sam9_ddrsdr.h with at91bootstrap's at91_ddrsdrc.h

2019-04-02 Thread Ahmad Fatoum
Hi Sam, On 2/4/19 19:25, Sam Ravnborg wrote: > Hi Ahmad. > > On Mon, Apr 01, 2019 at 12:18:12PM +0200, Ahmad Fatoum wrote: >> Instead of adding missing definitions to the existing at91sam9_ddrsdr.h >> and adapting the incoming DDRAM initialization code from at91bootstrap, >> just replace the

[PATCH v3 04/15] ARM: at91: replace at91sam9_ddrsdr.h with at91bootstrap's at91_ddrsdrc.h

2019-04-01 Thread Ahmad Fatoum
Instead of adding missing definitions to the existing at91sam9_ddrsdr.h and adapting the incoming DDRAM initialization code from at91bootstrap, just replace the lightly used existing header with: https://github.com/linux4sam/at91bootstrap/blob/v3.8.12/include/arch/at91_ddrsdrc.h For easier