[PATCH 5/7] Documentation: barebox environment: fix list rendering

2022-09-12 Thread Antony Pavlov
Signed-off-by: Antony Pavlov --- .../devicetree/bindings/barebox/barebox,environment.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/barebox/barebox,environment.rst b/Documentation/devicetree/bindings/barebox/barebox,environment.rst index

[PATCH 1/7] Documentation: OKUD Max9331: fix sphinx warning

2022-09-12 Thread Antony Pavlov
sphinx warning: Documentation/boards/mips/max9331.rst:129: WARNING: Pygments lexer name 'assembly' is not known Use pygments lexer for Gas (AT) assembly code, see https://pygments.org/docs/lexers/#lexers-for-assembly-languages for details. Signed-off-by: Antony Pavlov ---

[PATCH 7/7] Documentation: Voltage/Current Regulators: fix sphinx error

2022-09-12 Thread Antony Pavlov
sphinx error: Documentation/devicetree/bindings/regulator/regulator.rst:8: ERROR: Unexpected indentation. Signed-off-by: Antony Pavlov --- Documentation/devicetree/bindings/regulator/regulator.rst | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH 11/32] of: silence warning about never-read error assignment

2022-09-12 Thread Sascha Hauer
On Mon, Sep 05, 2022 at 11:55:36AM +0200, Ahmad Fatoum wrote: > err is assigned specific error codes, but they are not propagated and > instead NULL is returned for error. Make it explicit that we handle all > errors the same by typecasting to (void). This warning likely goes back to assigning

Re: [PATCH 00/32] treewide: fix some clang-analyze static analyzer warnings

2022-09-12 Thread Sascha Hauer
On Mon, Sep 05, 2022 at 11:55:25AM +0200, Ahmad Fatoum wrote: > I ran scan-build while building barebox for sandbox with clang and > patched some of the reported issues. > > Ahmad Fatoum (32): > clk: define stub implementation for clk_get_parent > clk: have SCMI and SiFive clock controllers

Re: [PATCH] commands: add pm_domain for listing power domains

2022-09-12 Thread Sascha Hauer
On Mon, Sep 05, 2022 at 09:04:48AM +0200, Ahmad Fatoum wrote: > Like the regulator command, this new pm_domain command gives an easy > way for listing registered power domains and whether barebox had them > activated. > > Signed-off-by: Ahmad Fatoum > --- > commands/Kconfig | 8 >

Re: [PATCH v2 08/10] ARM: mmu: use reserve mem entries to modify maps

2022-09-12 Thread Sascha Hauer
This patch breaks NAND support on my Phytec i.MX6 board. There are some problems with this patch, so I ended up reverting it for now. On Wed, Aug 17, 2022 at 01:42:42PM +0200, Ahmad Fatoum wrote: > @@ -468,11 +469,28 @@ void __mmu_init(bool mmu_on) > vectors_init(); > >

Re: [PATCH] of: platform: propagate of_devices_ensure_probed_by(name|property) errors

2022-09-12 Thread Sascha Hauer
On Mon, Sep 05, 2022 at 01:59:44PM +0200, Ahmad Fatoum wrote: > The of_devices_ensure_probed_by functions are expected to return an > error code after iterating over all matching devices should any device > have failed its of_device_ensure_probed. Doing this unearths one common > failure: a

[PATCH next] Documentation: filesystems: tftp: fix code blocks

2022-09-12 Thread Antony Pavlov
The patch fixes these sphinx errors: Documentation/filesystems/tftp.rst:44: ERROR: Error in "code-block" directive: maximum 1 argument(s) allowed, 3 supplied. Documentation/filesystems/tftp.rst:53: ERROR: Error in "code-block" directive: maximum 1 argument(s) allowed, 4 supplied.

Re: [PATCH 0/2] of: overlay: avoid potential null pointer exception

2022-09-12 Thread Sascha Hauer
On Mon, Sep 05, 2022 at 12:07:15PM +0200, Michael Riesch wrote: > Hi all, > > The function of_overlay_fix_path returns NULL in certain error cases but > of_overlay_apply_symbols (which is the only caller) does not check the > return value. For broken overlays this may result in a null pointer >

Re: Makefile.lib: cmd_dtc: warning: missing whitespace after the macro name

2022-09-12 Thread Sascha Hauer
On Wed, Sep 07, 2022 at 11:21:18AM +0300, Antony Pavlov wrote: > Hi Everyone! > > During MIPS ath79_defconfig build I have a 'missing whitespace after the > macro name' warning: > > AS [P] arch/mips/dts/ar9331_tl_mr3020.dtb.pbl.o > DTC arch/mips/dts/ar9344-tl-wdr4300-v1.7.dtb > :1:9:

Re: [PATCH] commands: mm: don't ignore pread() errors for larger access sizes

2022-09-12 Thread Sascha Hauer
On Fri, Sep 02, 2022 at 12:04:58PM +0200, Ahmad Fatoum wrote: > Error check was before pread was called and because ret was initialized, > compiler didn't warn about it. Fix this. > > Signed-off-by: Ahmad Fatoum > --- > commands/mm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH 0/3] tftp fixups

2022-09-12 Thread Sascha Hauer
On Mon, Sep 05, 2022 at 10:56:55AM +0200, Enrico Scholz wrote: > Fixups for the "tftp" branch in next. > > Enrico Scholz (3): > fixup! tftp: implement 'windowsize' (RFC 7440) support > fixup! tftp: detect out-of-memory situations > tftp: make read() fail in error case > > fs/tftp.c | 29

[RFC] Documentation/conf.py: fix copyright years

2022-09-12 Thread Antony Pavlov
N.B. N-dash is used! Signed-off-by: Antony Pavlov --- Documentation/conf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/conf.py b/Documentation/conf.py index bcd8633c919..5fb8b07c380 100644 --- a/Documentation/conf.py +++ b/Documentation/conf.py @@ -44,7

Re: [PATCH] of: implement of_rename_property()

2022-09-12 Thread Sascha Hauer
On Mon, Sep 05, 2022 at 12:36:39PM +0200, Ahmad Fatoum wrote: > It's often desirable to have the same barebox binary for multiple > variants. DT-level differences between the variants are often handled > by having extra device tree nodes that are disabled by default and > patched as appropriate by

Re: [PATCH 1/2] i2c: implement of_i2c_register_devices_by_node()

2022-09-12 Thread Sascha Hauer
On Mon, Sep 05, 2022 at 12:36:12PM +0200, Ahmad Fatoum wrote: > i2c controllers probe the devices on their bus themselves, so in the > case the i2c controller was already probed, we currently have no way to > have it reread the device tree after fixing it up or applying an > overlay. Add a new

[PATCH 0/7] Documentation misc fixes

2022-09-12 Thread Antony Pavlov
Antony Pavlov (7): Documentation: OKUD Max9331: fix sphinx warning Documentation: Altera SOCFPGA FPGA Manager: fix sphinx error Documentation: Altera FPGAs in passive-serial mode: fix sphinx issues Documentation: barebox DT aliases: fix sphinx issues Documentation: barebox environment:

[PATCH 2/7] Documentation: Altera SOCFPGA FPGA Manager: fix sphinx error

2022-09-12 Thread Antony Pavlov
sphinx error: Documentation/devicetree/bindings/firmware/altr,socfpga-fpga-mgr.rst:10: ERROR: Unexpected indentation. Insert necessary whitespaces and empty lines to form correct nested lists structure. Signed-off-by: Antony Pavlov ---

[PATCH 6/7] Documentation: Common leds properties: fix 'panic-indicator' list entry rendering

2022-09-12 Thread Antony Pavlov
Signed-off-by: Antony Pavlov --- Documentation/devicetree/bindings/leds/common.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/leds/common.rst b/Documentation/devicetree/bindings/leds/common.rst index 911a55f4f66..09b4e401bc2 100644 ---

[PATCH 3/7] Documentation: Altera FPGAs in passive-serial mode: fix sphinx issues

2022-09-12 Thread Antony Pavlov
sphinx issues: Documentation/devicetree/bindings/firmware/altr,passive-serial.rst:10: ERROR: Unexpected indentation. Documentation/devicetree/bindings/firmware/altr,passive-serial.rst:11: WARNING: Block quote ends without a blank line; unexpected unindent. Insert necessary empty line

[PATCH 4/7] Documentation: barebox DT aliases: fix sphinx issues

2022-09-12 Thread Antony Pavlov
sphinx issues: Documentation/devicetree/bindings/barebox/aliases.rst:8: ERROR: Unexpected indentation. Documentation/devicetree/bindings/barebox/aliases.rst:12: WARNING: Definition list ends without a blank line; unexpected unindent.

Re: [PATCH 0/5] commands: gpio: add controller as optional argument

2022-09-12 Thread Sascha Hauer
On Mon, Sep 05, 2022 at 12:35:41PM +0200, Ahmad Fatoum wrote: > gpioinfo currently displays all GPIOs and the rest of the GPIO commands > like gpio_direction_output expects either a GPIO label or a global GPIO > number to act upon. > > With this series, the gpio commands now accept an optional

Re: [PATCH 01/32] clk: define stub implementation for clk_get_parent

2022-09-12 Thread Sascha Hauer
On Mon, Sep 05, 2022 at 11:55:26AM +0200, Ahmad Fatoum wrote: > To make it easier to build drivers utilizing clk_get_parent on sandbox > for static analysis, provide a stub implementation of the function. > > Signed-off-by: Ahmad Fatoum > --- > include/linux/clk.h | 20 > 1

Re: [PATCH 13/32] commands: tutorial: fix memory leak

2022-09-12 Thread Sascha Hauer
On Mon, Sep 05, 2022 at 11:55:38AM +0200, Ahmad Fatoum wrote: > We don't need to duplicate argv[i], because it persists for the lieftime s/lieftime/lifetime/ > of print_tutorial_step. We can thus drop the strdup and while at it, > just drop the redundant step variable altogether. > >

Re: Makefile.lib: cmd_dtc: warning: missing whitespace after the macro name

2022-09-12 Thread Antony Pavlov
On Mon, 12 Sep 2022 10:01:52 +0200 Sascha Hauer wrote: Hi Sascha! > On Wed, Sep 07, 2022 at 11:21:18AM +0300, Antony Pavlov wrote: > > Hi Everyone! > > > > During MIPS ath79_defconfig build I have a 'missing whitespace after the > > macro name' warning: > > > > AS [P]

Re: [PATCH v2 08/10] ARM: mmu: use reserve mem entries to modify maps

2022-09-12 Thread Ahmad Fatoum
Hi, On 12.09.22 14:01, Sascha Hauer wrote: > This patch breaks NAND support on my Phytec i.MX6 board. There are some > problems with this patch, so I ended up reverting it for now. I wonder why. I see no memory reserves in imx6q-phytec-phycore-som-nand.dts and the files it includes. > > On

[PATCH v2] of: implement of_prepend_property

2022-09-12 Thread Ahmad Fatoum
Like of_append_property for adding at the end of properties, implement of_prepend_property for placing data into the front. This is especially useful to fixup most-specific compatibles into existing nodes. Signed-off-by: Ahmad Fatoum --- v1 -> v2: - simplify with malloc/memcpy instead of

Re: [PATCH v2 08/10] ARM: mmu: use reserve mem entries to modify maps

2022-09-12 Thread Sascha Hauer
On Mon, Sep 12, 2022 at 05:15:45PM +0200, Ahmad Fatoum wrote: > Hi, > > On 12.09.22 14:01, Sascha Hauer wrote: > > This patch breaks NAND support on my Phytec i.MX6 board. There are some > > problems with this patch, so I ended up reverting it for now. > > I wonder why. I see no memory reserves

Re: [PATCH] ARM: i.MX23: fix memory size calulcation

2022-09-12 Thread Sascha Hauer
On Fri, Sep 09, 2022 at 04:39:15PM +0200, Bastian Krause wrote: > According to the i.MX233 Reference Manual (i.MX233RM, Rev. 4, 03 April > 2009) section "14.1.1 AHB Address Ranges", the formula to calculate the > DRAM memory size is: > > dram_memory_available = 2 * 2^col * 2^row * (#

Re: [PATCH] of: implement of_prepend_property

2022-09-12 Thread Sascha Hauer
On Fri, Sep 09, 2022 at 09:40:50AM +0200, Ahmad Fatoum wrote: > Like of_append_property for adding at the end of properties, implement > of_prepend_property for placing data into the front. > > This is especially useful to fixup most-specific compatibles into > existing nodes. > > Signed-off-by: