Re: [PATCH master] optee: check optee_verify_header argument for error pointers

2024-03-01 Thread Sascha Hauer
On Thu, 29 Feb 2024 10:46:56 +0100, Ahmad Fatoum wrote: > optee_verify_header is called at two places with > imx_scratch_get_optee_hdr() as argument, which returns an error pointer. > > Check against that to avoid crashing in error cases. > > Applied, thanks! [1/1] optee: check

Re: [PATCH master] optee: don't warn about missing OP-TEE header

2024-03-01 Thread Sascha Hauer
On Wed, 28 Feb 2024 19:03:20 +0100, Ahmad Fatoum wrote: > OP-TEE header is checked once in PBL, saved into scratch area after > verification and then checked again in barebox proper. > > The check in PBL fails silently, but the check in barebox proper that > should always follow, because the

Re: [PATCH next] fixup! usb: xhci: reset endpoint on USB stall

2024-03-01 Thread Sascha Hauer
On Fri, Mar 01, 2024 at 08:44:00AM +0100, Ahmad Fatoum wrote: > usb: xhci: call dma_unmap_single in all error paths > > A new early exit for stalled USB was added that resets the endpoint > before returning an error code to the caller. > > This unintentionally happened before unmapping the

Re: [PATCH v2 1/2] partitions: efi: change first partition number from 1 to 0

2024-03-01 Thread Sascha Hauer
On Thu, 29 Feb 2024 08:18:24 +0100, Sascha Hauer wrote: > Traditionally barebox starts partition numbers at 0. This was changed > in bdc3cb54dc to start at 1. This was done to make the parted numbering > consistent to the Linux tool. This breaks boot scripts though which > assume 0 to be the

Re: [PATCH] Patch to fix bootm barebox load address alignment to acomodate ADRP instruction

2024-03-01 Thread Sascha Hauer
On Tue, 06 Feb 2024 21:37:47 -0500, Thaison Phan wrote: > The aarch64 bootm image handler for barebox can choose a load address > that is not 4KB aligned. This can result in unexpected behavior with > the ADRP instruction that is available in 64 bit ARM architectures. > ADRP forms a PC-relative

Re: [PATCH v2 2/2] partitions: dos: change first partition number from 1 to 0

2024-03-01 Thread Ahmad Fatoum
On 29.02.24 08:18, Sascha Hauer wrote: > Traditionally barebox starts partition numbers at 0. This was changed > in 8f48e6366c to start at 1. This was done to make the parted numbering > consistent to the Linux tool. This breaks boot scripts though which > assume 0 to be the first partition, so

Re: [PATCH next] fixup! usb: xhci: reset endpoint on USB stall

2024-03-01 Thread Sascha Hauer
On Fri, 01 Mar 2024 08:44:00 +0100, Ahmad Fatoum wrote: > usb: xhci: call dma_unmap_single in all error paths > > A new early exit for stalled USB was added that resets the endpoint > before returning an error code to the caller. > > This unintentionally happened before unmapping the buffer,

Re: [PATCH master] firmware: arm_scmi: pmdomain: restrict default y for driver

2024-03-01 Thread Sascha Hauer
On Fri, 01 Mar 2024 08:47:52 +0100, Ahmad Fatoum wrote: > default y is inappropriate for drivers that depend on CONFIG_COMPILE_TEST, > because it enables the driver as soon as CONFIG_COMPILE_TEST is enabled. > > While the driver can be built in that case, without > CONFIG_ARM_SCMI_PROTOCOL, it

Temporary outage of Git-over-https at https://git.pengutronix.de/cgit/barebox/

2024-03-01 Thread Ahmad Fatoum
Hi, As some may have already noticed, the git-over-HTTPS upstream is currently non-functional: $ git clone https://git.pengutronix.de/git/barebox Cloning into 'barebox'... fatal: remote error: FATAL: R any barebox webserver DENIED by fallthru (or you mis-spelled the reponame) This is

[PATCH v2] mci: dwcmshc-sdhci: add support for Kalray Coolidge v2 SoC eMMC controller

2024-03-01 Thread Yann Sionneau
Kalray Coolidge v2 SoC eMMC controller needs static tx delay tuning even for basic standard or high speed modes. Add vendor specific callback mechanism for init and implement it for Coolidge v2 SoC. Signed-off-by: Yann Sionneau --- Notes: V1 -> V2: - Fixed comment style - Removed unused

[PATCH] ARM: i.MX: ele: remove unnecessary argument

2024-03-01 Thread Sascha Hauer
The get_response argument to imx9_s3mua_call() is always set to true by the callers. It must be like that because in the ELE API Reference Guide every call into the ELE has a response. Drop the unnecessary argument. Signed-off-by: Sascha Hauer --- arch/arm/mach-imx/ele.c | 34

[PATCH 1/4] of: fdt: factor out FDT header parsing

2024-03-01 Thread Ahmad Fatoum
Follow-up commit will need to parse the FDT header without unflattening the whole device tree at the same time. Therefore split off the header verification into its own separate function. Signed-off-by: Ahmad Fatoum --- drivers/of/fdt.c | 76 +++- 1

[PATCH 0/4] of: fdt: read blspec/FIT DT compat without unflattening

2024-03-01 Thread Ahmad Fatoum
blspec and FIT systems usually have multiple entries/configurations, where a suitable one should be selected at runtime by comparing each against the board's barebox DT compatible. For blspec, this meant we need to unflatten the whole DT only to access a single property. For FIT, this meant we

[PATCH 2/4] of: fdt: implement fdt_machine_is_compatible

2024-03-01 Thread Ahmad Fatoum
When finding compatible bootloader spec files, barebox will unflatten each DTB in turn, allocating objects for each property and node, only to compare a single property and then free all the allocations again. Given that this operation is repeated for every device tree until a match is found,

[PATCH 4/4] FIT: support finding compatible configuration by FDT compatible

2024-03-01 Thread Ahmad Fatoum
So far, we only supported finding compatible configurations that have a compatible property inside the configuration's device tree node. According to spec, this is optional however, and e.g. Yocto's kernel-fitimage.bbclass don't generate it. Instead, the bootloader is expected to lookup the

[PATCH 3/4] blspec: don't parse whole device tree to compare compatibles

2024-03-01 Thread Ahmad Fatoum
Now that we have an fdt_machine_is_compatible that can operate on flattened device trees, use it to speed up the process of finding compatible bootloader spec entries. Signed-off-by: Ahmad Fatoum --- common/blspec.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff

[PATCH] ARM: i.MX: sabresd: Add support for i.MX6DL board variant

2024-03-01 Thread Stefano Manni
The SabreSD comes with different SoC variants. This patch adds support for the i.MX6DL based board. the DCD data has been taken from U-Boot 2023.04 Signed-off-by: Stefano Manni --- arch/arm/boards/freescale-mx6-sabresd/board.c | 6 +- .../flash-header-mx6dl-sabresd.imxcfg | 104

Re: Temporary outage of Git-over-https at https://git.pengutronix.de/cgit/barebox/

2024-03-01 Thread Ahmad Fatoum
On 01.03.24 10:53, Ahmad Fatoum wrote: > Hi, > > As some may have already noticed, the git-over-HTTPS upstream is currently > non-functional: > > $ git clone https://git.pengutronix.de/git/barebox > Cloning into 'barebox'... > fatal: remote error: FATAL: R any barebox webserver DENIED by