Re: Q about bootstrap support for at91sam92* boards and proposal for retirement

2022-01-10 Thread Sam Ravnborg
Hi Oleksij,
> 
> By porting sama5d3 I noticed that bootROM is resetting configuration for
> at least some of ip cores. So, the main question is, do everything needed
> for uart is still pre-configured? For example pllc and clk settings?

I found this in the data sheet that agrees with you:

"
Before performing the jump to the application in internal SRAM,
all the PIOs and peripherals used in the boot
program are set to their reset state.
"

I will throw some hours after this in the weekend to see if I can get
it up and running.

> 
> As soon as UART is working, every thing else will be not really hard to
> do :)
Agree, except that I need find a nice way to add whatever I do to the
current at91 stuff. But that is part of the fun.

Sam

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


Re: [PATCH 7/9] RISC-V: don't use x8/s0/fp in assembly

2022-01-10 Thread Antony Pavlov
On Sat, 8 Jan 2022 19:25:03 +0100
Ahmad Fatoum  wrote:

Hi Ahmad!

> Hello Antony,
> 
> On 08.01.22 18:15, Ahmad Fatoum wrote:
> > Free up the register to allow building a configuration with x8/s0 used
> > as the frame pointer.
> > 
> > Signed-off-by: Ahmad Fatoum 
> > ---
> >  arch/riscv/include/asm/debug_ll_litex.h   | 12 +++---
> >  arch/riscv/include/asm/debug_ll_ns16550.h |  8 ++--
> >  arch/riscv/include/asm/riscv_nmon.h   | 50 +++
> 
> I just bumped the s register: s2 -> s3, s1 -> s2, s0 -> s1 to
> clear s0. Is that ok?

I suppose that there is no problem if nmon still works under qemu.


> >  3 files changed, 35 insertions(+), 35 deletions(-)
> > 
> > diff --git a/arch/riscv/include/asm/debug_ll_litex.h 
> > b/arch/riscv/include/asm/debug_ll_litex.h
> > index 2fcdd9b0ec3e..295477fc1010 100644
> > --- a/arch/riscv/include/asm/debug_ll_litex.h
> > +++ b/arch/riscv/include/asm/debug_ll_litex.h
> > @@ -90,11 +90,11 @@ static inline void PUTC_LL(char ch)
> > li  t0, DEBUG_LL_UART_ADDR
> >  
> > /* get line status and check for data present */
> > -   lbu s0, UART_RXEMPTY(t0)
> > -   bnezs0, 243f
> > -   li  s0, 1
> > +   lbu s1, UART_RXEMPTY(t0)
> > +   bnezs1, 243f
> > +   li  s1, 1
> > j   244f
> > -243:   li  s0, 0
> > +243:   li  s1, 0
> >  244:   nop
> >  #endif /* CONFIG_DEBUG_LL */
> >  .endm
> > @@ -109,10 +109,10 @@ static inline void PUTC_LL(char ch)
> > debug_ll_tstc
> >  
> > /* try again */
> > -   beqzs0, 204b
> > +   beqzs1, 204b
> >  
> > /* read a character */
> > -   lb  s0, UART_RXTX(t0)
> > +   lb  s1, UART_RXTX(t0)
> > li  t1, UART_EV_RX
> > sb  t1, UART_EV_PENDING(t0)
> >  
> > diff --git a/arch/riscv/include/asm/debug_ll_ns16550.h 
> > b/arch/riscv/include/asm/debug_ll_ns16550.h
> > index e208ef4fb1e1..47f0be328ce8 100644
> > --- a/arch/riscv/include/asm/debug_ll_ns16550.h
> > +++ b/arch/riscv/include/asm/debug_ll_ns16550.h
> > @@ -143,8 +143,8 @@ static inline void debug_ll_ns16550_init(void)
> > li  t0, DEBUG_LL_UART_ADDR
> >  
> > /* get line status and check for data present */
> > -   UART_REG_L  s0, UART_LSR(DEBUG_LL_UART_SHIFT)(t0)
> > -   andis0, s0, UART_LSR_DR
> > +   UART_REG_L  s1, UART_LSR(DEBUG_LL_UART_SHIFT)(t0)
> > +   andis1, s1, UART_LSR_DR
> >  
> >  #endif /* CONFIG_DEBUG_LL */
> >  .endm
> > @@ -159,10 +159,10 @@ static inline void debug_ll_ns16550_init(void)
> > debug_ll_tstc
> >  
> > /* try again */
> > -   beqzs0, 204b
> > +   beqzs1, 204b
> >  
> > /* read a character */
> > -   UART_REG_L  s0, UART_RBR(DEBUG_LL_UART_SHIFT)(t0)
> > +   UART_REG_L  s1, UART_RBR(DEBUG_LL_UART_SHIFT)(t0)
> >  
> >  #endif /* CONFIG_DEBUG_LL */
> >  .endm
> > diff --git a/arch/riscv/include/asm/riscv_nmon.h 
> > b/arch/riscv/include/asm/riscv_nmon.h
> > index 8a44e216d72d..3e349025febc 100644
> > --- a/arch/riscv/include/asm/riscv_nmon.h
> > +++ b/arch/riscv/include/asm/riscv_nmon.h
> > @@ -84,7 +84,7 @@ nmon_main:
> > debug_ll_getc
> >  
> > li  a0, 'q'
> > -   bne s0, a0, 3f
> > +   bne s1, a0, 3f
> >  
> > jal a2, _nmon_outc_a0
> >  
> > @@ -92,13 +92,13 @@ nmon_main:
> >  
> >  3:
> > li  a0, 'd'
> > -   beq s0, a0, nmon_cmd_d
> > +   beq s1, a0, nmon_cmd_d
> >  
> > li  a0, 'w'
> > -   beq s0, a0, nmon_cmd_w
> > +   beq s1, a0, nmon_cmd_w
> >  
> > li  a0, 'g'
> > -   beq s0, a0, nmon_cmd_g
> > +   beq s1, a0, nmon_cmd_g
> >  
> > j   nmon_main_help
> >  
> > @@ -112,7 +112,7 @@ nmon_cmd_d:
> >  
> > nmon_outs   msg_nl
> >  
> > -   lw  a0, (s0)
> > +   lw  a0, (s1)
> > debug_ll_outhexw
> >  
> > j   nmon_main
> > @@ -124,13 +124,13 @@ nmon_cmd_w:
> > jal a2, _nmon_outc_a0
> >  
> > jal a2, _nmon_gethexw
> > -   moves2, s0
> > +   moves3, s1
> >  
> > li  a0, ' '
> > jal a2, _nmon_outc_a0
> > jal a2, _nmon_gethexw
> >  
> > -   sw  s0, 0(s2)
> > +   sw  s1, 0(s3)
> > j   nmon_main
> >  
> >  nmon_cmd_g:
> > @@ -140,11 +140,11 @@ nmon_cmd_g:
> > jal a2, _nmon_outc_a0
> >  
> > jal a2, _nmon_gethexw
> > -   moves2, s0
> > +   moves3, s1
> >  
> > nmon_outs   msg_nl
> >  
> > -   jalrs2
> > +   jalrs3
> > j   nmon_main
> >  
> >  _nmon_outc_a0:
> > @@ -169,37 +169,37 @@ _nmon_gethexw:
> >  _get_hex_digit:
> > debug_ll_getc
> >  
> > -   li  s1, CODE_ESC
> > -   beq s0, s1, nmon_main
> > +   li  s2, CODE_ESC
> > +   beq s1, s2, nmon_main
> >  
> > -   li  s1, '0'
> > -   bge s0, s1, 0f
> > +   li  s2, '0'
> > +   bge s1, s2, 0f
> > j   _get_hex_digit
> >  
> >  0:
> > -   li  s1, '9'
> > -   ble s0, s1, 9f
> > +   li  s2, '9'
> > +   ble s1, s2, 9f
> >  
> > -   li  s1, 'f'
> > -   ble s0, s1, 1f
> > +  

[PATCH] misc: acpi-test: retire test driver in favor of WDAT driver

2022-01-10 Thread Ahmad Fatoum
With the integration of the ACPI WDAT watchdog driver, we now have an
actually useful user of the ACPI bus in tree, so the test driver
serves no purpose anymore. Drop it.

Signed-off-by: Ahmad Fatoum 
---
 drivers/misc/Kconfig |  6 
 drivers/misc/Makefile|  1 -
 drivers/misc/acpi-test.c | 61 
 3 files changed, 68 deletions(-)
 delete mode 100644 drivers/misc/acpi-test.c

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 56569145076e..5ab0506cd9fa 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -37,12 +37,6 @@ config UBOOTVAR
  While it can be used standalone, it is best when coupled
  with corresponding filesystem driver.
 
-config ACPI_TEST
-   bool "ACPI Test driver"
-   depends on ACPI
-   help
- This is a simple Test driver to test the ACPI bus.
-
 config STARFIVE_PWRSEQ
bool "StarFive power sequencing driver"
depends on SOC_STARFIVE
diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
index 05da264a426d..6326e784fc98 100644
--- a/drivers/misc/Makefile
+++ b/drivers/misc/Makefile
@@ -8,5 +8,4 @@ obj-$(CONFIG_SRAM)  += sram.o
 obj-$(CONFIG_STATE_DRV)+= state.o
 obj-$(CONFIG_DEV_MEM)  += mem.o
 obj-$(CONFIG_UBOOTVAR) += ubootvar.o
-obj-$(CONFIG_ACPI_TEST)+= acpi-test.o
 obj-$(CONFIG_STARFIVE_PWRSEQ)  += starfive-pwrseq.o
diff --git a/drivers/misc/acpi-test.c b/drivers/misc/acpi-test.c
deleted file mode 100644
index af20370fbc73..
--- a/drivers/misc/acpi-test.c
+++ /dev/null
@@ -1,61 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-only
-/*
- * Copyright (c) 2019 Ahmad Fatoum
- */
-
-#include 
-#include 
-#include 
-
-static const char *profiles[] = {
-   "Unspecified",
-   "Desktop",
-   "Mobile",
-   "Workstation",
-   "Enterprise Server",
-   "SOHO Server",
-   "Applicance PC",
-   "Performance Server",
-   "Tablet",
-};
-
-static int acpi_test_probe(struct device_d *dev)
-{
-   const char *profile = "reserved";
-   u8 *sdt;
-   u8 profileno;
-
-   dev_dbg(dev, "driver initializing...\n");
-
-   sdt = (u8 __force *)dev_request_mem_region_by_name(dev, "SDT");
-   if (IS_ERR(sdt)) {
-   dev_err(dev, "no SDT resource available: %pe\n", sdt);
-   return PTR_ERR(sdt);
-   }
-
-   dev_dbg(dev, "SDT is at 0x%p\n", sdt);
-
-   profileno = sdt[45];
-
-   if (profileno < ARRAY_SIZE(profiles))
-   profile = profiles[profileno];
-
-   dev_info(dev, "PM profile is for '%s'\n", profile);
-
-   return 0;
-}
-
-static void acpi_test_remove(struct device_d *dev)
-{
-   dev_dbg(dev, "FADT driver removed\n");
-}
-
-static struct acpi_driver acpi_test_driver = {
-   .signature = "FACP",
-   .driver = {
-   .name = "acpi-test",
-   .probe = acpi_test_probe,
-   .remove = acpi_test_remove,
-   }
-};
-device_acpi_driver(acpi_test_driver);
-- 
2.30.2


___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


Re: Re: Re: Re: barebox extending boot-scripts

2022-01-10 Thread Sascha Hauer
On Fri, Jan 07, 2022 at 05:42:22PM +0100, Frank Wunderlich wrote:
> Hi
> 
> missed the defaultenv_append_directory(defaultenv_rk3568); in 
> board-file...after adding that it seems to work
> 
> > Gesendet: Freitag, 07. Januar 2022 um 14:07 Uhr
> > Von: "Sascha Hauer" 
> >
> > Yes. Furthermore you have to add to the board code:
> >
> > defaultenv_append_directory(defaultenv_rk3568);
> 
> maybe this is the part i've missed. i thought it were 2 ways...either link 
> via makefile or add to boards code
> 
> > > > > > Boot scripts for publicly available evaluation kits are often not 
> > > > > > good candidates
> > > > > > for upstreaming, because everybody using the EVKs has different 
> > > > > > thoughts on how to
> > > > > > boot. The best way would be to use bootloader spec. It's one or 
> > > > > > more files you
> > > > > > place at a known location that describe where your kernel and 
> > > > > > device tree are and
> > > > > > what command line arguments to use and barebox can then 
> > > > > > automatically generate
> > > > > > boot entries from all available bootloader spec files.
> > >
> > > is extlinux (i used in uboot and conf-file is already present) supported 
> > > here?
> > >
> > > > > > See https://elinux.org/images/9/9d/Barebox-bells-n-whistles.pdf for 
> > > > > > an example
> > > > > > of how to set this up. This is what I'd recommend instead of 
> > > > > > writing your own
> > > > > > scripts.
> > >
> > > i do not fully understand the bootloader spec in the pdf as config file 
> > > seems to be
> > >
> > > /mnt/mmc0.4/loader/entries/stm32mp157c-dk2.conf
> > >
> > > and then
> > > boot -d mmc0.4
> > >
> > > is run...so the path (loader/entries) seems to be fixed and all files 
> > > there will be processed (which order)?
> >
> > Yes. No particular order, I guess it would be the order it is on the
> > filesystem.
> >
> > > how is root appended (/dev/mmcblkXpY|uuid|...) when linux-appendroot is 
> > > set to true?
> >
> > When root is appended it is assumed to be the same fs that also has the
> > bootloader spec file, so the rootfs also has the entry and the kernel.
> 
> ok, then this is not usable for me, as i have a boot-partition
> (bootloader+kernel+dtb) and separate rootfs-partition
> 
> > > this is for testing multiple kernels with changing filenames (very
> > > dynamic process, e.g. using 1 kernel binary with multiple dtb) and to
> > > avoid adding a bootmenu entry everytimethis is not for end-user :)
> >
> > In that case you could also use bootm directly.
> 
> yes but my approach is to list the available kernels before and ask to
> enter the filename to not everytime look for correct commands ;)
> 
> > > and here scripting is imho the best way...this allows me to add extra
> > > params to cmdline too (like debug level,dumping offsets) without
> > > changing a distroboot config
> >
> > Not sure if you know already, but barebox concatenates all variables in
> > the "global.linux.bootargs." namespace to the kernel command line, so
> > you can easily add or remove a variable to add/remove kernel options
> > without affecting unrelated options.
> 
> i know some options from documentation like this i've used to get a earlycon 
> for tftp
> 
> global linux.bootargs.debug="earlycon=uart8250,mmio32,0xfe66 earlyprintk"
> 
> > > for fixed kernels i have defined an extlinux.conf for uboot, but i'm
> > > unsure if barebox can use this file too. have not found anything about
> > > extlinux/syslinux in barebox yet.
> >
> > No, not yet.
> 
> ok, i created a bootloader-config like described in the pdf:
> 
> cat /mnt/sd.1/loader/entries/linux-gz.conf
> title Linux GZip
> version 5.16
> options earlycon=uart8250,mmio32,0xfe66 console=ttyS2,150n8
> linux /extlinux/Image_5.16.gz
> devicetree /extlinux/dtb_5.16
> initrd /rootfs.cpio.lz4
> 
> but on starting it is skipped due to devicetree mismatch
> 
> boot -d sd.1
> blspec: ignoring entry with incompatible devicetree 
> "rockchip,rk3568-bpi-r2pro"
> blspec: ignoring entry with incompatible devicetree 
> "rockchip,rk3568-bpi-r2pro"
> Nothing bootable found on 'sd.1'
> Nothing bootable found
> 
> in barebox i use the evb whereas in linux i already have a separate
> dts. Can i override the compatible for the bootloader or do i need to
> add my board (as copy of evb first)?

You can overwrite the compatible using the of_property command. However,
I really recommend to add a separate barebox board for your board.
Sooner or later you'll have to do this anyway and it's the only way to
properly add quirks for your board.

> 
> btw. don't you get my direct messages (regarding vop2 driver for
> rk3568 and the result of my barebox environment-tests)?

Yes, I received them, but probably forgot to answer them because you
didn't ask a question ;)

Regards,
 Sascha


-- 
Pengutronix e.K.   | |
Steuerwalder Str. 21   | http://www.pengutronix.de/  |
31137 Hildesheim, Germany  

Re: [PATCH] include: : sync with upstream

2022-01-10 Thread Sascha Hauer
On Sat, Jan 08, 2022 at 06:14:45PM +0100, Ahmad Fatoum wrote:
> We don't define CONFIG_RISCV_PRIV_1_9, so deleted stuff by the sync is
> unused anyway. No functional change.
> 
> Signed-off-by: Ahmad Fatoum 
> ---
>  arch/riscv/include/asm/csr.h | 213 ++-
>  1 file changed, 161 insertions(+), 52 deletions(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.   | |
Steuerwalder Str. 21   | http://www.pengutronix.de/  |
31137 Hildesheim, Germany  | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


Re: [PATCH] include : include for size_t definition

2022-01-10 Thread Sascha Hauer
On Sat, Jan 08, 2022 at 06:14:37PM +0100, Ahmad Fatoum wrote:
> size_t is used without previous definition relying on header include
> order. Fix that up.
> 
> Signed-off-by: Ahmad Fatoum 
> ---
>  include/printk.h | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks

Sascha


-- 
Pengutronix e.K.   | |
Steuerwalder Str. 21   | http://www.pengutronix.de/  |
31137 Hildesheim, Germany  | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


Re: [PATCH 3/3] commands: add new devunbind debugging command

2022-01-10 Thread Sascha Hauer
On Sat, Jan 08, 2022 at 06:14:26PM +0100, Ahmad Fatoum wrote:
> Memory corruption around device removal may go unnoticed, because
> barebox is shutting down anyway and doing no new allocations.
> 
> Add a new devunbind command that should help with debugging such issues
> by allowing selective unbinding and removal of devices.
> 
> Signed-off-by: Ahmad Fatoum 
> ---
>  commands/Kconfig  | 12 +++
>  commands/Makefile |  1 +
>  commands/devunbind.c  | 74 +++
>  drivers/base/driver.c |  7 ++--
>  include/driver.h  |  4 +++
>  5 files changed, 95 insertions(+), 3 deletions(-)
>  create mode 100644 commands/devunbind.c
> 
> diff --git a/commands/Kconfig b/commands/Kconfig
> index e2c36949347e..9abd97271952 100644
> --- a/commands/Kconfig
> +++ b/commands/Kconfig
> @@ -68,6 +68,18 @@ config CMD_DEVINFO
> If called with a device path being the argument, devinfo shows more
> default information about this device and its parameters.
>  
> +config CMD_DEVUNBIND
> + tristate
> + default y
> + prompt "devunbind"
> + help
> +   Debugging aid to unbind device from driver at runtime
> +
> +   devunbind [-f] DEVICE
> +
> +   Options:
> + -f   unbind driver and force removal of device and children
> +
>  config CMD_DMESG
>   tristate
>   prompt "dmesg"
> diff --git a/commands/Makefile b/commands/Makefile
> index 0b7c1563b534..875826743ffe 100644
> --- a/commands/Makefile
> +++ b/commands/Makefile
> @@ -107,6 +107,7 @@ obj-$(CONFIG_CMD_MIITOOL) += miitool.o
>  obj-$(CONFIG_CMD_DETECT) += detect.o
>  obj-$(CONFIG_CMD_BOOT)   += boot.o
>  obj-$(CONFIG_CMD_DEVINFO)+= devinfo.o
> +obj-$(CONFIG_CMD_DEVUNBIND)  += devunbind.o
>  obj-$(CONFIG_CMD_DRVINFO)+= drvinfo.o
>  obj-$(CONFIG_CMD_READF)  += readf.o
>  obj-$(CONFIG_CMD_MENUTREE)   += menutree.o
> diff --git a/commands/devunbind.c b/commands/devunbind.c
> new file mode 100644
> index ..4bebb27e8e68
> --- /dev/null
> +++ b/commands/devunbind.c
> @@ -0,0 +1,74 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +// SPDX-FileCopyrightText: © 2021 Ahmad Fatoum , 
> Pengutronix
> +
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +
> +static int do_devunbind(int argc, char *argv[])
> +{
> + bool unregister = false;
> + struct device_d *dev;
> + int ret = COMMAND_SUCCESS, i, opt;
> +
> + while ((opt = getopt(argc, argv, "fl")) > 0) {
> + switch (opt) {
> + case 'f':
> + unregister = true;
> + break;
> + case 'l':
> + list_for_each_entry(dev, _device_list, active) {
> + BUG_ON(!dev->driver);
> + if (dev->bus->remove)
> + printf("%pS(%s, %s)\n", 
> dev->bus->remove,
> +dev->driver->name, 
> dev_name(dev));
> + }
> + return 0;
> + default:
> + return COMMAND_ERROR_USAGE;
> + }
> + }
> +
> + if (!argv[optind])
> + return COMMAND_ERROR_USAGE;
> +
> + for (i = optind; i < argc; i++) {
> + dev = get_device_by_name(argv[i]);
> + if (!dev)
> + return -ENODEV;
> +
> + if (unregister)
> + return unregister_device(dev);

Shouldn't you continue the loop here?

Sascha

-- 
Pengutronix e.K.   | |
Steuerwalder Str. 21   | http://www.pengutronix.de/  |
31137 Hildesheim, Germany  | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


Re: [PATCH 1/2] common: boards: qemu-virt: fix dtc warning

2022-01-10 Thread Sascha Hauer
On Sat, Jan 08, 2022 at 06:13:55PM +0100, Ahmad Fatoum wrote:
> DTC complains about a Warning (chosen_node_is_root):
> 
>   /fragment@1/__overlay__/chosen: chosen node must be at root node
> 
> As /chosen is already available in the device tree of all of:
> 
>   - ARM 32-Bit QEMU Virt
>   - ARM 64-Bit QEMU Virt
>   - RISC-V 32-Bit QEMU Virt
>   - RISC-V 64-Bit QEMU Virt
> 
> Just reference that in a new fragment to silence the warning.
> 
> Signed-off-by: Ahmad Fatoum 
> ---
>  common/boards/qemu-virt/overlay-of-flash.dts | 17 +++--
>  1 file changed, 11 insertions(+), 6 deletions(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.   | |
Steuerwalder Str. 21   | http://www.pengutronix.de/  |
31137 Hildesheim, Germany  | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


Re: [PATCH 1/2] acpi.h: add defines for adr_space and gas

2022-01-10 Thread Sascha Hauer
On Fri, Jan 07, 2022 at 02:42:18PM +0100, Steffen Trumtrar wrote:
> From linux v5.15-rc1.
> 
> Signed-off-by: Steffen Trumtrar 
> ---
>  include/acpi.h | 72 ++
>  1 file changed, 72 insertions(+)

Applied, thanks

Sascha

-- 
Pengutronix e.K.   | |
Steuerwalder Str. 21   | http://www.pengutronix.de/  |
31137 Hildesheim, Germany  | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


Re: [PATCH] commands: hashsum: Fix endif typos

2022-01-10 Thread Sascha Hauer
On Fri, Jan 07, 2022 at 10:27:29AM +0100, Enguerrand de Ribaucourt wrote:
> Fix the comments in endif to correspond to the symbol of their
> ifdef.
> 
> Signed-off-by: Enguerrand de Ribaucourt 
> 
> ---
>  commands/hashsum.c | 12 ++--
>  1 file changed, 6 insertions(+), 6 deletions(-)

Applied, thanks

Sascha


-- 
Pengutronix e.K.   | |
Steuerwalder Str. 21   | http://www.pengutronix.de/  |
31137 Hildesheim, Germany  | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


Re: [PATCH] drivers: virtio: import list of newer Virtio IDs

2022-01-10 Thread Sascha Hauer
On Fri, Jan 07, 2022 at 09:01:04AM +0100, Ahmad Fatoum wrote:
> These are unused now.
> 
> Signed-off-by: Ahmad Fatoum 
> ---
>  include/uapi/linux/virtio_ids.h | 26 ++
>  1 file changed, 26 insertions(+)

Applied, thanks

Sascha


-- 
Pengutronix e.K.   | |
Steuerwalder Str. 21   | http://www.pengutronix.de/  |
31137 Hildesheim, Germany  | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


Re: [PATCH master] x86: : fix outl/outsl access size

2022-01-10 Thread Sascha Hauer
On Fri, Jan 07, 2022 at 07:36:44AM +0100, Ahmad Fatoum wrote:
> outl so far behaved like outb, probably due to a copy-paste error when
> it was first added. We have three users in-tree for outl:
> 
> * drivers/serial/serial_ns16550_pci.c
>   only for handling a Quatech qurik, which probably no one ever needed
> 
> * drivers/serial/serial_ns16550.c
>   For platform drivers with a 4 byte I/O port resource. Only possible
>   user is x86 and that has a 1 byte I/O port resource. Thus no one
>   used this either.
> 
> * drivers/watchdog/itco_wdt.c
>   Here it indeed triggers a bug, although in my testing the WDAT
>   was functional without.
> 
> Fix this up so new code doesn't have to track this down.
> 
> Signed-off-by: Ahmad Fatoum 
> ---
> Cc: Steffen Trumtrar 
> ---
>  arch/x86/include/asm/io.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.   | |
Steuerwalder Str. 21   | http://www.pengutronix.de/  |
31137 Hildesheim, Germany  | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox