[PATCH] power: reset: reboot-mode: Fix resetting to normal mode

2022-03-10 Thread Sascha Hauer
To clear the reboot mode for next reboot during registration of a reboot mode driver we call reboot->write() with a zero initialized u32 array with a single entry. This is wrong for two reasons. First the array is too short, for i.MX6 we need to entries. Then it is assumed that the magic to write

[PATCH v2] MIPS: fix optimised memset returning garbage

2022-03-10 Thread Denis Orlov
There is a subtle bug in arch/mips/lib/memset.S, used if option MIPS_OPTIMIZED_STRING_FUNCTIONS is enabled, which results in not writing the correct return value into v0 register if the value to fill memory with is 0. The bug stems from a missing '.set noreorder' directive before the first beqz

Re: [PATCH 0/1] MIPS: fix optimised memset returning garbage

2022-03-10 Thread Antony Pavlov
On Thu, 10 Mar 2022 16:40:39 +0300 Denis Orlov wrote: Hi Denis! I'm very glad to see that you have found this anoying bug! Some tips: * you comment from "PATCH 0/1" is very informative but after applying "PATCH 1/1" to the mainline this very informative comment remain in maillist archive but

[PATCH 1/1] MIPS: fix optimised memset returning garbage

2022-03-10 Thread Denis Orlov
There is a subtle bug in arch/mips/lib/memset.S, which results in not writing the correct return value into v0 register if the value to fill memory with is 0. Signed-off-by: Denis Orlov --- arch/mips/lib/memset.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 0/1] MIPS: fix optimised memset returning garbage

2022-03-10 Thread Denis Orlov
There is currently a bug in memset implementation from arch/mips/lib/memset.S that is used when MIPS_OPTIMIZED_STRING_FUNCTIONS option is enabled. It stems from a missing '.set noreorder' directive before the first branch. This results in an assembler stuffing a 'nop' instruction in a delay slot

Re: [PATCH] block: set S_IFBLK for block devices instead of S_IFCHR

2022-03-10 Thread Sascha Hauer
On Fri, Mar 04, 2022 at 10:28:05AM +0100, Ahmad Fatoum wrote: > In barebox, block devices are a special case of character devices. > Nevertheless, differentiation can be useful to allow scripts iterating > over all block devices without accounting for naming, e.g. > > for dev in /dev/*; do >