Re: [PATCH 4/4] mci: dwcmshc-sdhci: add support for Kalray Coolidge v2 SoC eMMC controller

2024-02-29 Thread Ahmad Fatoum
Hello Yann, On 29.02.24 17:31, Yann Sionneau wrote: > On 2/29/24 17:19, Ahmad Fatoum wrote: >> On 29.02.24 16:57, Yann Sionneau wrote: >>> Kalray Coolidge v2 SoC eMMC controller needs static tx delay tuning even >>> for basic standard or high speed modes. >>> +struct dwcmshc_callbacks { >>> +   

[PATCH master] firmware: arm_scmi: pmdomain: restrict default y for driver

2024-02-29 Thread Ahmad Fatoum
default y is inappropriate for drivers that depend on CONFIG_COMPILE_TEST, because it enables the driver as soon as CONFIG_COMPILE_TEST is enabled. While the driver can be built in that case, without CONFIG_ARM_SCMI_PROTOCOL, it just prints a red error message on init: ERROR: initcall

[PATCH next] fixup! usb: xhci: reset endpoint on USB stall

2024-02-29 Thread Ahmad Fatoum
usb: xhci: call dma_unmap_single in all error paths A new early exit for stalled USB was added that resets the endpoint before returning an error code to the caller. This unintentionally happened before unmapping the buffer, which is detected by CONFIG_DMA_API_DEBUG: usb2-0: Resetting EP 0...

Re: [PATCH 4/4] mci: dwcmshc-sdhci: add support for Kalray Coolidge v2 SoC eMMC controller

2024-02-29 Thread Yann Sionneau
Hello Ahmad, On 2/29/24 17:19, Ahmad Fatoum wrote: Hello Yann, On 29.02.24 16:57, Yann Sionneau wrote: Kalray Coolidge v2 SoC eMMC controller needs static tx delay tuning even for basic standard or high speed modes. This patch also adds possibility to do some vendor specific tuning in

[PATCH v2] mtd: don't try to detect UBI in too small flash partitions

2024-02-29 Thread Ahmad Fatoum
The detect callback will try to detect an UBI volume inside a partition. This can misbehave for partitions without UBI: - For partitions smaller than 512 bytes, detect fails with -EINVAL, because it wasn't possible to read as much - For partitions smaller than 64 PEBs, detect will

Re: [PATCH 2/4] mci: dwcmshc-sdhci: Fix f_max computation

2024-02-29 Thread Ahmad Fatoum
On 29.02.24 16:56, Yann Sionneau wrote: > f_max was possibly set from max-frequency DT property > by mci_of_parse() and then overwritten few lines later > with the clock frequency, making it impossible to > reduce the clock frequency from DT. > > Move the call to mci_of_parse() after the first

Re: [PATCH 4/4] mci: dwcmshc-sdhci: add support for Kalray Coolidge v2 SoC eMMC controller

2024-02-29 Thread Ahmad Fatoum
Hello Yann, On 29.02.24 16:57, Yann Sionneau wrote: > Kalray Coolidge v2 SoC eMMC controller needs static tx delay tuning even > for basic standard or high speed modes. > > This patch also adds possibility to do some vendor specific tuning > in set_ios(). > This will be needed for Coolidge v2

[PATCH 1/4] mci: dwcmshc-sdhci: Remove superfluous call to sdhci_enable_v4_mode

2024-02-29 Thread Yann Sionneau
sdhci_enable_v4_mode is already called from dwcmshc_mci_init which is always called before using the controller from mci-core.c Signed-off-by: Yann Sionneau --- drivers/mci/dwcmshc-sdhci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mci/dwcmshc-sdhci.c

[PATCH 3/4] mci: sdhci: add register define for P_VENDOR_SPECIFIC_AREA

2024-02-29 Thread Yann Sionneau
This register is standardized by SDHCI (See SD Host Controller Simplified Specification v4.20 "1.2 Register Map" and "2.3.14 Pointer Registers to mFFh-100h Area"). It is necessary to access some vendor specific registers for some controllers. Signed-off-by: Yann Sionneau ---

[PATCH 2/4] mci: dwcmshc-sdhci: Fix f_max computation

2024-02-29 Thread Yann Sionneau
f_max was possibly set from max-frequency DT property by mci_of_parse() and then overwritten few lines later with the clock frequency, making it impossible to reduce the clock frequency from DT. Move the call to mci_of_parse() after the first assignment to f_max. Signed-off-by: Yann Sionneau

[PATCH 4/4] mci: dwcmshc-sdhci: add support for Kalray Coolidge v2 SoC eMMC controller

2024-02-29 Thread Yann Sionneau
Kalray Coolidge v2 SoC eMMC controller needs static tx delay tuning even for basic standard or high speed modes. This patch also adds possibility to do some vendor specific tuning in set_ios(). This will be needed for Coolidge v2 for >50 MHz speeds and HS200/HS400 modes. Signed-off-by: Yann

Re: [PATCH master] optee: don't warn about missing OP-TEE header

2024-02-29 Thread Ahmad Fatoum
On 29.02.24 12:13, Marco Felsch wrote: > On 24-02-29, Ahmad Fatoum wrote: >> On 29.02.24 10:33, Marco Felsch wrote: >>> On 24-02-29, Ahmad Fatoum wrote: hdr is a valid pointer for me, but it doesn't point at a header, which causes me to get an error message. >>> >>> Yes, I have

Re: [PATCH master] optee: don't warn about missing OP-TEE header

2024-02-29 Thread Marco Felsch
On 24-02-29, Ahmad Fatoum wrote: > On 29.02.24 10:33, Marco Felsch wrote: > > On 24-02-29, Ahmad Fatoum wrote: > >> hdr is a valid pointer for me, but it doesn't point at a header, which > >> causes > >> me to get an error message. > > > > Yes, I have noticed the code path for non-pbl part as

Re: [PATCH master] optee: check optee_verify_header argument for error pointers

2024-02-29 Thread Marco Felsch
On 24-02-29, Ahmad Fatoum wrote: > optee_verify_header is called at two places with > imx_scratch_get_optee_hdr() as argument, which returns an error pointer. > > Check against that to avoid crashing in error cases. > > Suggested-by: Marco Felsch > Signed-off-by: Ahmad Fatoum Reviewed-by:

[PATCH master] optee: check optee_verify_header argument for error pointers

2024-02-29 Thread Ahmad Fatoum
optee_verify_header is called at two places with imx_scratch_get_optee_hdr() as argument, which returns an error pointer. Check against that to avoid crashing in error cases. Suggested-by: Marco Felsch Signed-off-by: Ahmad Fatoum --- common/optee.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH master] optee: don't warn about missing OP-TEE header

2024-02-29 Thread Ahmad Fatoum
On 29.02.24 10:33, Marco Felsch wrote: > On 24-02-29, Ahmad Fatoum wrote: >> hdr is a valid pointer for me, but it doesn't point at a header, which causes >> me to get an error message. > > Yes, I have noticed the code path for non-pbl part as well now :/ > > I was thinking about: > > if

Re: [PATCH master] optee: don't warn about missing OP-TEE header

2024-02-29 Thread Marco Felsch
On 24-02-29, Ahmad Fatoum wrote: > On 29.02.24 10:10, Marco Felsch wrote: > > Hi Ahmad, > > > > On 24-02-28, Ahmad Fatoum wrote: > >> OP-TEE header is checked once in PBL, saved into scratch area after > >> verification and then checked again in barebox proper. > >> > >> The check in PBL fails

Re: [PATCH master] optee: don't warn about missing OP-TEE header

2024-02-29 Thread Ahmad Fatoum
On 29.02.24 10:10, Marco Felsch wrote: > Hi Ahmad, > > On 24-02-28, Ahmad Fatoum wrote: >> OP-TEE header is checked once in PBL, saved into scratch area after >> verification and then checked again in barebox proper. >> >> The check in PBL fails silently, but the check in barebox proper that >>

Re: [PATCH master] optee: don't warn about missing OP-TEE header

2024-02-29 Thread Marco Felsch
Hi Ahmad, On 24-02-28, Ahmad Fatoum wrote: > OP-TEE header is checked once in PBL, saved into scratch area after > verification and then checked again in barebox proper. > > The check in PBL fails silently, but the check in barebox proper that > should always follow, because the header isn't

Re: [PATCH] ARM: i.MX93: tqm93xx: add PMIC node

2024-02-29 Thread Sascha Hauer
On Mon, 05 Feb 2024 13:53:01 +0100, Sascha Hauer wrote: > The PMIC is needs to be configured on the tqm93xx to properly reset the > board, see the board specific initialisation code. We had a PMIC node > in our downstream dts file which we dropped in favour for using the > upstream dts. The

Re: [PATCH] net: drop unused rarp.h

2024-02-29 Thread Sascha Hauer
On Tue, 27 Feb 2024 10:39:23 +0300, Antony Pavlov wrote: > Applied, thanks! [1/1] net: drop unused rarp.h https://git.pengutronix.de/cgit/barebox/commit/?id=3b38db4c3219 (link may not be stable) Best regards, -- Sascha Hauer

Re: [PATCH 1/2] ARM: i.MX8M: drop function prototype for removed imx8m_uid

2024-02-29 Thread Sascha Hauer
On Wed, 28 Feb 2024 18:51:27 +0100, Ahmad Fatoum wrote: > The i.MX8M UID and some other SoC-related info is now available over > soc0.soc_uid and imx8m_uid's function definition was removed. > > Therefore remove the prototype as well. > > Applied, thanks! [1/2] ARM: i.MX8M: drop function

Re: [PATCH 1/6] driver: make struct bus_type::match optional

2024-02-29 Thread Sascha Hauer
On Wed, 28 Feb 2024 17:05:13 +0100, Ahmad Fatoum wrote: > Newly introduce soc_bus_type doesn't define .match, which would crash > once a driver is registered on that bus. Do as Linux does and treat a > non-existent match callback as meaning that all drivers should be > matched and that the probe

Re: [PATCH] serial: lpuart32: fix rx stall on FIFO overflow

2024-02-29 Thread Sascha Hauer
On Wed, 28 Feb 2024 11:21:41 +0100, Sascha Hauer wrote: > When the rx FIFO overruns then no new characters are received, even > when the FIFO is read from and space becomes available again. > Acknowledge the overrun in this case to let the UART continue to work. > > Applied, thanks! [1/1]