Re: [RFC PATCH 11/15] resource: fix iomem root resource for 64 bit

[Peter Mamonov]

Hi, Andrey,

On Thu, May 17, 2018 at 02:50:58PM -0700, Andrey Smirnov wrote:
> On Thu, May 17, 2018 at 6:58 AM, Peter Mamonov  wrote:
> > Signed-off-by: Peter Mamonov 
> > ---
> >  common/resource.c | 4 
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/common/resource.c b/common/resource.c
> > index e4bbe15fd..1cf00a927 100644
> > --- a/common/resource.c
> > +++ b/common/resource.c
> > @@ -114,7 +114,11 @@ int release_region(struct resource *res)
> >  /* The root resource for the whole memory-mapped io space */
> >  struct resource iomem_resource = {
> > .start = 0,
> > +#ifdef CONFIG_PHYS_ADDR_T_64BIT
> > +   .end = -1ull,
> > +#else
> > .end = 0x,
> > +#endif
> 
> Would ".end = ~(resource_size_t)0" work instead? This way you'd avoid
> using preprocessor.

Guess it should work. Thanks for the tip!

Regards,
Peter

> 
> Thanks,
> Andrey Smironv
> 
> > .name = "iomem",
> > .children = LIST_HEAD_INIT(iomem_resource.children),
> >  };
> > --
> > 2.17.0
> >
> >
> > ___
> > barebox mailing list
> > barebox@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/barebox

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [RFC PATCH 11/15] resource: fix iomem root resource for 64 bit

[Andrey Smirnov]

On Thu, May 17, 2018 at 6:58 AM, Peter Mamonov  wrote:
> Signed-off-by: Peter Mamonov 
> ---
>  common/resource.c | 4 
>  1 file changed, 4 insertions(+)
>
> diff --git a/common/resource.c b/common/resource.c
> index e4bbe15fd..1cf00a927 100644
> --- a/common/resource.c
> +++ b/common/resource.c
> @@ -114,7 +114,11 @@ int release_region(struct resource *res)
>  /* The root resource for the whole memory-mapped io space */
>  struct resource iomem_resource = {
> .start = 0,
> +#ifdef CONFIG_PHYS_ADDR_T_64BIT
> +   .end = -1ull,
> +#else
> .end = 0x,
> +#endif

Would ".end = ~(resource_size_t)0" work instead? This way you'd avoid
using preprocessor.

Thanks,
Andrey Smironv

> .name = "iomem",
> .children = LIST_HEAD_INIT(iomem_resource.children),
>  };
> --
> 2.17.0
>
>
> ___
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox