Re: [PATCH] Revert "dma: use dma/cpu conversions correctly in dma_map/unmap_single"

2023-05-31 Thread Ahmad Fatoum
Hello Denis, On 31.05.23 15:02, Denis Orlov wrote: > Hi! > >> >> On 31.05.23 12:23, Sascha Hauer wrote: >>> This reverts commit d13d870986eeecc58d8652268557e4a159b9d4c4. >>> >>> While the patch itself is correct, it at least breaks USB on the >>> Raspberry Pi 3b. >>> >>> With this patch

Re: [PATCH] Revert "dma: use dma/cpu conversions correctly in dma_map/unmap_single"

2023-05-31 Thread Denis Orlov
Hi! > > On 31.05.23 12:23, Sascha Hauer wrote: > > This reverts commit d13d870986eeecc58d8652268557e4a159b9d4c4. > > > > While the patch itself is correct, it at least breaks USB on the > > Raspberry Pi 3b. > > > > With this patch dma_sync_single_for_device() is passed the DMA address. > > This

Re: [PATCH] Revert "dma: use dma/cpu conversions correctly in dma_map/unmap_single"

2023-05-31 Thread Ahmad Fatoum
On 31.05.23 12:23, Sascha Hauer wrote: > This reverts commit d13d870986eeecc58d8652268557e4a159b9d4c4. > > While the patch itself is correct, it at least breaks USB on the > Raspberry Pi 3b. > > With this patch dma_sync_single_for_device() is passed the DMA address. > This is correct as even the

[PATCH] Revert "dma: use dma/cpu conversions correctly in dma_map/unmap_single"

2023-05-31 Thread Sascha Hauer
This reverts commit d13d870986eeecc58d8652268557e4a159b9d4c4. While the patch itself is correct, it at least breaks USB on the Raspberry Pi 3b. With this patch dma_sync_single_for_device() is passed the DMA address. This is correct as even the prototype suggests that it should get a dma_addr_t.