Re: [PATCH next] Documentation: filesystems: tftp: fix code blocks
On Tue, Sep 13, 2022 at 12:54:11PM +0300, Antony Pavlov wrote: > On Tue, 13 Sep 2022 10:08:37 +0200 > Sascha Hauer wrote: > > Hi Sascha! > > > On Mon, Sep 12, 2022 at 11:50:47AM +0300, Antony Pavlov wrote: > > > The patch fixes these sphinx errors: > > > > > > Documentation/filesystems/tftp.rst:44: ERROR: Error in "code-block" > > > directive: > > > maximum 1 argument(s) allowed, 3 supplied. > > > Documentation/filesystems/tftp.rst:53: ERROR: Error in "code-block" > > > directive: > > > maximum 1 argument(s) allowed, 4 supplied. > > > > > > Signed-off-by: Antony Pavlov > > > --- > > > Documentation/filesystems/tftp.rst | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > Applied, thanks > > I thought that this patch is for ammend. My bad! I shell add "for > ammend" or "fixup" tag to the message subject next time. Ah, ok, I didn't realize that. When the to-be-fixed-up patch sits in next you could just commit with --fixup=, this makes it very easy to fix it up on my side. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
Re: [PATCH next] Documentation: filesystems: tftp: fix code blocks
On Tue, 13 Sep 2022 10:08:37 +0200 Sascha Hauer wrote: Hi Sascha! > On Mon, Sep 12, 2022 at 11:50:47AM +0300, Antony Pavlov wrote: > > The patch fixes these sphinx errors: > > > > Documentation/filesystems/tftp.rst:44: ERROR: Error in "code-block" > > directive: > > maximum 1 argument(s) allowed, 3 supplied. > > Documentation/filesystems/tftp.rst:53: ERROR: Error in "code-block" > > directive: > > maximum 1 argument(s) allowed, 4 supplied. > > > > Signed-off-by: Antony Pavlov > > --- > > Documentation/filesystems/tftp.rst | 2 ++ > > 1 file changed, 2 insertions(+) > > Applied, thanks I thought that this patch is for ammend. My bad! I shell add "for ammend" or "fixup" tag to the message subject next time. > > > > diff --git a/Documentation/filesystems/tftp.rst > > b/Documentation/filesystems/tftp.rst > > index 8929213d3c4..e88ad3dd4c8 100644 > > --- a/Documentation/filesystems/tftp.rst > > +++ b/Documentation/filesystems/tftp.rst > > @@ -42,6 +42,7 @@ the opposite effect. Performance depends on: > > 100 Mb/s) it had to be reduced to > > > > .. code-block:: console > > + > > global tftp.windowsize=26 > > > > for example. > > @@ -51,6 +52,7 @@ the opposite effect. Performance depends on: > > example, the `fec-imx` driver reserves place for > > > > .. code-block:: c > > + > > #define FEC_RBD_NUM 64 > > > > packets before they are dropped > > -- > > 2.37.2 > > > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | -- Best regards, Antony Pavlov
Re: [PATCH next] Documentation: filesystems: tftp: fix code blocks
On Mon, Sep 12, 2022 at 11:50:47AM +0300, Antony Pavlov wrote: > The patch fixes these sphinx errors: > > Documentation/filesystems/tftp.rst:44: ERROR: Error in "code-block" > directive: > maximum 1 argument(s) allowed, 3 supplied. > Documentation/filesystems/tftp.rst:53: ERROR: Error in "code-block" > directive: > maximum 1 argument(s) allowed, 4 supplied. > > Signed-off-by: Antony Pavlov > --- > Documentation/filesystems/tftp.rst | 2 ++ > 1 file changed, 2 insertions(+) Applied, thanks Sascha > > diff --git a/Documentation/filesystems/tftp.rst > b/Documentation/filesystems/tftp.rst > index 8929213d3c4..e88ad3dd4c8 100644 > --- a/Documentation/filesystems/tftp.rst > +++ b/Documentation/filesystems/tftp.rst > @@ -42,6 +42,7 @@ the opposite effect. Performance depends on: > 100 Mb/s) it had to be reduced to > > .. code-block:: console > + > global tftp.windowsize=26 > > for example. > @@ -51,6 +52,7 @@ the opposite effect. Performance depends on: > example, the `fec-imx` driver reserves place for > > .. code-block:: c > + > #define FEC_RBD_NUM 64 > > packets before they are dropped > -- > 2.37.2 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
[PATCH next] Documentation: filesystems: tftp: fix code blocks
The patch fixes these sphinx errors: Documentation/filesystems/tftp.rst:44: ERROR: Error in "code-block" directive: maximum 1 argument(s) allowed, 3 supplied. Documentation/filesystems/tftp.rst:53: ERROR: Error in "code-block" directive: maximum 1 argument(s) allowed, 4 supplied. Signed-off-by: Antony Pavlov --- Documentation/filesystems/tftp.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/filesystems/tftp.rst b/Documentation/filesystems/tftp.rst index 8929213d3c4..e88ad3dd4c8 100644 --- a/Documentation/filesystems/tftp.rst +++ b/Documentation/filesystems/tftp.rst @@ -42,6 +42,7 @@ the opposite effect. Performance depends on: 100 Mb/s) it had to be reduced to .. code-block:: console + global tftp.windowsize=26 for example. @@ -51,6 +52,7 @@ the opposite effect. Performance depends on: example, the `fec-imx` driver reserves place for .. code-block:: c + #define FEC_RBD_NUM 64 packets before they are dropped -- 2.37.2
