Re: [PATCH v2 4/5] arm: boards: beaglebone: Delete default env
Hi Sascha, Am 08.05.2017 um 14:57 schrieb Sascha Hauer: Hi Daniel, On Fri, May 05, 2017 at 04:46:57PM +0200, Daniel Schultz wrote: The Beaglebone environment should be set from outside with an application specific environment. I don't understand this. What are you trying to archieve and why? I thought you prefer the bootloader spec way without a predefined environment, but maybe I just had misunderstood you. If so, I will only change the mount path of the boot partition. -- Mit freundlichen Grüßen, With best regards, Daniel Schultz Sascha Signed-off-by: Daniel Schultz--- arch/arm/boards/beaglebone/Makefile | 1 - arch/arm/boards/beaglebone/board.c | 2 -- arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd| 6 -- .../arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300 | 5 - 4 files changed, 14 deletions(-) delete mode 100644 arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd delete mode 100644 arch/arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300 diff --git a/arch/arm/boards/beaglebone/Makefile b/arch/arm/boards/beaglebone/Makefile index 21a1a29..092c31d 100644 --- a/arch/arm/boards/beaglebone/Makefile +++ b/arch/arm/boards/beaglebone/Makefile @@ -1,3 +1,2 @@ lwl-y += lowlevel.o obj-y += board.o -bbenv-y += defaultenv-beaglebone diff --git a/arch/arm/boards/beaglebone/board.c b/arch/arm/boards/beaglebone/board.c index 5717c45..fc16aea 100644 --- a/arch/arm/boards/beaglebone/board.c +++ b/arch/arm/boards/beaglebone/board.c @@ -85,8 +85,6 @@ static int beaglebone_devices_init(void) black = is_beaglebone_black(); - defaultenv_append_directory(defaultenv_beaglebone); - globalvar_add_simple("board.variant", black ? "boneblack" : "bone"); printf("detected 'BeagleBone %s'\n", black ? "Black" : "White"); diff --git a/arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd b/arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd deleted file mode 100644 index aa94b2f..000 --- a/arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd +++ /dev/null @@ -1,6 +0,0 @@ -#!/bin/sh - -global.bootm.image=/boot/uImage -global.bootm.oftree=/boot/oftree -#global.bootm.initrd= -global.linux.bootargs.dyn.root="root=/dev/mmcblk0p2 rootfstype=ext4 rootwait" diff --git a/arch/arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300 b/arch/arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300 deleted file mode 100644 index 56313bf..000 --- a/arch/arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300 +++ /dev/null @@ -1,5 +0,0 @@ -#!/bin/sh - -echo -n "changing USB current limit to 1300 mA... " -i2c_write -b 0 -a 0x24 -r 0x01 0x3e -echo "done" -- 1.9.1 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH v2 4/5] arm: boards: beaglebone: Delete default env
Hi Daniel, On Fri, May 05, 2017 at 04:46:57PM +0200, Daniel Schultz wrote: > The Beaglebone environment should be set from outside with an application > specific environment. I don't understand this. What are you trying to archieve and why? Sascha > > Signed-off-by: Daniel Schultz> --- > arch/arm/boards/beaglebone/Makefile | 1 - > arch/arm/boards/beaglebone/board.c | 2 -- > arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd| 6 > -- > .../arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300 | 5 - > 4 files changed, 14 deletions(-) > delete mode 100644 arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd > delete mode 100644 > arch/arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300 > > diff --git a/arch/arm/boards/beaglebone/Makefile > b/arch/arm/boards/beaglebone/Makefile > index 21a1a29..092c31d 100644 > --- a/arch/arm/boards/beaglebone/Makefile > +++ b/arch/arm/boards/beaglebone/Makefile > @@ -1,3 +1,2 @@ > lwl-y += lowlevel.o > obj-y += board.o > -bbenv-y += defaultenv-beaglebone > diff --git a/arch/arm/boards/beaglebone/board.c > b/arch/arm/boards/beaglebone/board.c > index 5717c45..fc16aea 100644 > --- a/arch/arm/boards/beaglebone/board.c > +++ b/arch/arm/boards/beaglebone/board.c > @@ -85,8 +85,6 @@ static int beaglebone_devices_init(void) > > black = is_beaglebone_black(); > > - defaultenv_append_directory(defaultenv_beaglebone); > - > globalvar_add_simple("board.variant", black ? "boneblack" : "bone"); > > printf("detected 'BeagleBone %s'\n", black ? "Black" : "White"); > diff --git a/arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd > b/arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd > deleted file mode 100644 > index aa94b2f..000 > --- a/arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd > +++ /dev/null > @@ -1,6 +0,0 @@ > -#!/bin/sh > - > -global.bootm.image=/boot/uImage > -global.bootm.oftree=/boot/oftree > -#global.bootm.initrd= > -global.linux.bootargs.dyn.root="root=/dev/mmcblk0p2 rootfstype=ext4 rootwait" > diff --git > a/arch/arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300 > b/arch/arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300 > deleted file mode 100644 > index 56313bf..000 > --- a/arch/arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300 > +++ /dev/null > @@ -1,5 +0,0 @@ > -#!/bin/sh > - > -echo -n "changing USB current limit to 1300 mA... " > -i2c_write -b 0 -a 0x24 -r 0x01 0x3e > -echo "done" > -- > 1.9.1 > > > ___ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
[PATCH v2 4/5] arm: boards: beaglebone: Delete default env
The Beaglebone environment should be set from outside with an application specific environment. Signed-off-by: Daniel Schultz--- arch/arm/boards/beaglebone/Makefile | 1 - arch/arm/boards/beaglebone/board.c | 2 -- arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd| 6 -- .../arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300 | 5 - 4 files changed, 14 deletions(-) delete mode 100644 arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd delete mode 100644 arch/arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300 diff --git a/arch/arm/boards/beaglebone/Makefile b/arch/arm/boards/beaglebone/Makefile index 21a1a29..092c31d 100644 --- a/arch/arm/boards/beaglebone/Makefile +++ b/arch/arm/boards/beaglebone/Makefile @@ -1,3 +1,2 @@ lwl-y += lowlevel.o obj-y += board.o -bbenv-y += defaultenv-beaglebone diff --git a/arch/arm/boards/beaglebone/board.c b/arch/arm/boards/beaglebone/board.c index 5717c45..fc16aea 100644 --- a/arch/arm/boards/beaglebone/board.c +++ b/arch/arm/boards/beaglebone/board.c @@ -85,8 +85,6 @@ static int beaglebone_devices_init(void) black = is_beaglebone_black(); - defaultenv_append_directory(defaultenv_beaglebone); - globalvar_add_simple("board.variant", black ? "boneblack" : "bone"); printf("detected 'BeagleBone %s'\n", black ? "Black" : "White"); diff --git a/arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd b/arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd deleted file mode 100644 index aa94b2f..000 --- a/arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd +++ /dev/null @@ -1,6 +0,0 @@ -#!/bin/sh - -global.bootm.image=/boot/uImage -global.bootm.oftree=/boot/oftree -#global.bootm.initrd= -global.linux.bootargs.dyn.root="root=/dev/mmcblk0p2 rootfstype=ext4 rootwait" diff --git a/arch/arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300 b/arch/arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300 deleted file mode 100644 index 56313bf..000 --- a/arch/arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300 +++ /dev/null @@ -1,5 +0,0 @@ -#!/bin/sh - -echo -n "changing USB current limit to 1300 mA... " -i2c_write -b 0 -a 0x24 -r 0x01 0x3e -echo "done" -- 1.9.1 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox