Re: [PATCH v2 05/13] net: ath79: add ag71xx Ethernet driver

2017-08-08 Thread Lucas Stach
Hi Peter, Am Montag, den 07.08.2017, 23:45 +0300 schrieb Peter Mamonov: > On Mon, Aug 07, 2017 at 04:39:19PM +0200, Oleksij Rempel wrote: > > From: Yegor Yefremov > > > > Signed-off-by: Yegor Yefremov > > Signed-off-by: Antony Pavlov > > --- [...] > > +static int ag71xx_ether_send(struct eth_d

Re: [PATCH 1/2] readline_simple: return -1 if getc fails

2017-08-08 Thread Lucas Stach
Am Montag, den 07.08.2017, 18:10 -0400 schrieb Gaël PORTAY: > The getc function may return an errno code if an error happens. > > This patch prevents readline from printing a non printable character and > from looping to infinity and beyong. > > Signed-off-by: Gaël PORTAY > --- > lib/readline_s

Re: [PATCH 1/2] readline_simple: return -1 if getc fails

2017-08-08 Thread Ian Abbott
On 08/08/17 08:51, Lucas Stach wrote: Am Montag, den 07.08.2017, 18:10 -0400 schrieb Gaël PORTAY: The getc function may return an errno code if an error happens. This patch prevents readline from printing a non printable character and from looping to infinity and beyong. Signed-off-by: Gaël PO

Re: [PATCH 1/2] readline_simple: return -1 if getc fails

2017-08-08 Thread Gaël PORTAY
Hi Lucas, On Tue, Aug 08, 2017 at 09:51:54AM +0200, Lucas Stach wrote: > Am Montag, den 07.08.2017, 18:10 -0400 schrieb Gaël PORTAY: > > The getc function may return an errno code if an error happens. > > > > This patch prevents readline from printing a non printable character and > > from loopin

Re: [PATCH 1/2] readline_simple: return -1 if getc fails

2017-08-08 Thread Gaël PORTAY
Hi Ian, On Tue, Aug 08, 2017 at 11:07:54AM +0100, Ian Abbott wrote: > On 08/08/17 08:51, Lucas Stach wrote: > > Am Montag, den 07.08.2017, 18:10 -0400 schrieb Gaël PORTAY: > > > The getc function may return an errno code if an error happens. > > > > > > This patch prevents readline from printing

Re: [PATCH 1/2] readline_simple: return -1 if getc fails

2017-08-08 Thread Lucas Stach
Am Dienstag, den 08.08.2017, 11:20 -0400 schrieb Gaël PORTAY: > Hi Lucas, > > On Tue, Aug 08, 2017 at 09:51:54AM +0200, Lucas Stach wrote: > > Am Montag, den 07.08.2017, 18:10 -0400 schrieb Gaël PORTAY: > > > The getc function may return an errno code if an error happens. > > > > > > This patch p

Re: [PATCH 1/2] readline_simple: return -1 if getc fails

2017-08-08 Thread Ian Abbott
On 08/08/17 16:36, Lucas Stach wrote: Am Dienstag, den 08.08.2017, 11:20 -0400 schrieb Gaël PORTAY: Hi Lucas, On Tue, Aug 08, 2017 at 09:51:54AM +0200, Lucas Stach wrote: Am Montag, den 07.08.2017, 18:10 -0400 schrieb Gaël PORTAY: The getc function may return an errno code if an error happens

Re: [PATCH 1/2] readline_simple: return -1 if getc fails

2017-08-08 Thread Gaël PORTAY
On Tue, Aug 08, 2017 at 05:36:14PM +0200, Lucas Stach wrote: > Am Dienstag, den 08.08.2017, 11:20 -0400 schrieb Gaël PORTAY: > > Hi Lucas, > > > > On Tue, Aug 08, 2017 at 09:51:54AM +0200, Lucas Stach wrote: > > > > diff --git a/lib/readline_simple.c b/lib/readline_simple.c > > > > index c4d3d240e

Re: [PATCH 1/2] readline_simple: return -1 if getc fails

2017-08-08 Thread Gaël PORTAY
On Tue, Aug 08, 2017 at 05:05:35PM +0100, Ian Abbott wrote: > On 08/08/17 16:36, Lucas Stach wrote: > > Am Dienstag, den 08.08.2017, 11:20 -0400 schrieb Gaël PORTAY: > > > Hi Lucas, > > > > > > On Tue, Aug 08, 2017 at 09:51:54AM +0200, Lucas Stach wrote: > > > > (...) > > > > I don't like made up

[PATCH v2 1/2] readline_simple: return -1 if getc fails

2017-08-08 Thread Gaël PORTAY
The getc function may return an errno code if an error happens. This patch prevents readline from printing a non printable character and from looping to infinity and beyong. Signed-off-by: Gaël PORTAY --- lib/readline_simple.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --g

[PATCH 0/2] readline_simple: return -1 if getc fails

2017-08-08 Thread Gaël PORTAY
Dear maintainers, I came accross this issue when I was trying to add support for a new MIPS board. The getc() function from console_simple.c returns -EINVAL when no console is registered. It causes readline_simple to print a non-printable character (-EINVAL in this case). Furthermore, it causes

[PATCH v2 2/2] readline_simple: remove obsolete documentation

2017-08-08 Thread Gaël PORTAY
The readline function does not return timed-out anymore since the commit: be5d13bcb readline_simple: drop unusable u-boot legacy stuff Signed-off-by: Gaël PORTAY --- lib/readline_simple.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/readline_simple.c b/lib

Re: [PATCH 0/2] readline_simple: return -1 if getc fails

2017-08-08 Thread Oleksij Rempel
Am 09.08.2017 um 06:13 schrieb Gaël PORTAY: > Dear maintainers, > > I came accross this issue when I was trying to add support for a new MIPS > board. Just out of curiosity, what MIPS board are you working on? If it is not a secret :) -- Regards, Oleksij signature.asc Description: OpenPGP d