Re: [PATCH 1/6] include: add SPDX GPL-2.0-only license tags where applicable
On Sun, Mar 10, 2019 at 10:06:26PM +0100, Sam Ravnborg wrote: > Hi Roland. > > On Sun, Mar 10, 2019 at 09:42:25PM +0100, Roland Hieber wrote: > > Hi, > > > > this thread has been open for some time now without any more responses. > > The only motion against it was from Oleksij, who asked me remove the > > license headers in favour of having only the SPDX-License-Identifier > > tags. I replied that I think both the human-understandable license > > headers and the machine-readable tags have their own value, but there > > was no further argument. > I agree with Oleksij here. > We have the license information we need expressed using the SPDX tag, > and we shall avoid the remaining license boiler plate. > > If one needs to read the license text it is in the tree. > And when we do not have it in the file one does not have to read > it both in the file and in the tree when this is relevant > to look into. > The rest of us is just glad to have less boilerplate to > drag around with. OK thanks. There was less feedback than I'd hoped for, but what was there went in the same direction, so I'll spin a v2 without the headers. - Roland ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH 1/6] include: add SPDX GPL-2.0-only license tags where applicable
Hi Roland. On Sun, Mar 10, 2019 at 09:42:25PM +0100, Roland Hieber wrote: > Hi, > > this thread has been open for some time now without any more responses. > The only motion against it was from Oleksij, who asked me remove the > license headers in favour of having only the SPDX-License-Identifier > tags. I replied that I think both the human-understandable license > headers and the machine-readable tags have their own value, but there > was no further argument. I agree with Oleksij here. We have the license information we need expressed using the SPDX tag, and we shall avoid the remaining license boiler plate. If one needs to read the license text it is in the tree. And when we do not have it in the file one does not have to read it both in the file and in the tree when this is relevant to look into. The rest of us is just glad to have less boilerplate to drag around with. Sam ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH 1/6] include: add SPDX GPL-2.0-only license tags where applicable
Hi,
this thread has been open for some time now without any more responses.
The only motion against it was from Oleksij, who asked me remove the
license headers in favour of having only the SPDX-License-Identifier
tags. I replied that I think both the human-understandable license
headers and the machine-readable tags have their own value, but there
was no further argument. Oleksij, do you agree, or do you have further
arguments?
- Roland
On Fri, Feb 08, 2019 at 06:48:26AM +0100, Oleksij Rempel wrote:
> Hi Roland,
>
> please remove deprecated license headers in same patch.
>
> Am 07.02.19 um 23:39 schrieb Roland Hieber:
> > Interpret "GPLv2" as "GPLv2 only".
> >
> > Signed-off-by: Roland Hieber
> > ---
> > include/aimage.h| 1 +
> > include/aiodev.h| 1 +
> > include/binfmt.h| 1 +
> > include/bootstrap.h | 1 +
> > include/bpkfs.h | 1 +
> > include/ddr_spd.h | 1 +
> > include/dhcp.h | 1 +
> > include/digest.h| 1 +
> > include/dma.h | 1 +
> > include/firmware.h | 1 +
> > include/getopt.h| 1 +
> > include/local_mac_address.h | 1 +
> > include/menu.h | 1 +
> > include/of_graph.h | 1 +
> > include/of_mtd.h| 1 +
> > include/of_net.h| 1 +
> > include/password.h | 1 +
> > include/pbl.h | 1 +
> > include/poller.h| 1 +
> > include/shell.h | 1 +
> > include/uimagefs.h | 1 +
> > include/w1_mac_address.h| 1 +
> > include/xymodem.h | 1 +
> > 23 files changed, 23 insertions(+)
> >
> > diff --git a/include/aimage.h b/include/aimage.h
> > index 9702b7d35c..0c7dda39ce 100644
> > --- a/include/aimage.h
> > +++ b/include/aimage.h
> > @@ -1,15 +1,16 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > /*
> > * (C) Copyright 2011 Jean-Christhophe PLAGNIOL-VILLARD
> >
> > *
> > * Android boot image
> > *
> > * Under GPLv2 only
> > */
> >
> > #ifndef __AIMAGE_H__
> > #define __AIMAGE_H__
> >
> > #define BOOT_MAGIC "ANDROID!"
> > #define BOOT_MAGIC_SIZE8
> > #define BOOT_NAME_SIZE 16
> > #define BOOT_ARGS_SIZE 512
> > diff --git a/include/aiodev.h b/include/aiodev.h
> > index 5e38b4fab5..5f41554ad1 100644
> > --- a/include/aiodev.h
> > +++ b/include/aiodev.h
> > @@ -1,15 +1,16 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > /*
> > * core.c - Code implementing core functionality of AIODEV susbsystem
> > *
> > * Copyright (c) 2015 Sascha Hauer , Pengutronix
> > * Copyright (c) 2015 Zodiac Inflight Innovation
> > *
> > * See file CREDITS for list of people who contributed to this
> > * project.
> > *
> > * This program is free software; you can redistribute it and/or modify
> > * it under the terms of the GNU General Public License version 2
> > * as published by the Free Software Foundation.
> > *
> > * This program is distributed in the hope that it will be useful,
> > * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > diff --git a/include/binfmt.h b/include/binfmt.h
> > index 46b627e36d..b1fd2a72e8 100644
> > --- a/include/binfmt.h
> > +++ b/include/binfmt.h
> > @@ -1,15 +1,16 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > /*
> > * Copyright (C) 2012 Jean-Christophe PLAGNIOL-VILLARD
> >
> > *
> > * GPL v2
> > */
> >
> > #ifndef __BFMT_H__
> > #define __BFMT_H__
> >
> > #include
> > #include
> >
> > struct binfmt_hook {
> > enum filetype type;
> > int (*hook)(struct binfmt_hook *b, char *file, int argc, char **argv);
> > diff --git a/include/bootstrap.h b/include/bootstrap.h
> > index d3ee6be47c..6100f7be2f 100644
> > --- a/include/bootstrap.h
> > +++ b/include/bootstrap.h
> > @@ -1,15 +1,16 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > /*
> > * Copyright (C) 2012 Jean-Christophe PLAGNIOL-VILLARD
> >
> > *
> > * Under GPLv2
> > */
> >
> > #ifndef __BOOSTRAP_H__
> > #define __BOOSTRAP_H__
> >
> > #include
> >
> > #define bootstrap_err(fmt, arg...) printf(fmt, ##arg)
> >
> > typedef void (*kernel_entry_func)(int zero, int arch, void *params);
> > void bootstrap_boot(kernel_entry_func func, bool barebox);
> > diff --git a/include/bpkfs.h b/include/bpkfs.h
> > index ccb56c1419..49fbd5d48e 100644
> > --- a/include/bpkfs.h
> > +++ b/include/bpkfs.h
> > @@ -1,15 +1,16 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > /*
> > * Copyright (c) 2013 Jean-Christophe PLAGNIOL-VILLARD
> >
> > *
> > * under GPLv2 only
> > */
> >
> > #ifndef __BPKFS_H__
> > #define __BPKFS_H__
> >
> > #include
> > #include
> >
> > #define BPKFS_TYPE_BL 0x50424c00
> > #define BPKFS_TYPE_BLV 0x50424c56
> > #define BPKFS_TYPE_DSC 0x44456343
> > diff --git a/include/ddr_spd.h b/include/ddr_spd.h
> > index 01fe73c615..18bb7c2751 100644
> > --- a/include/ddr_spd.h
> > +++
Re: [PATCH 1/6] include: add SPDX GPL-2.0-only license tags where applicable
On Fri, Feb 15, 2019 at 12:18:19PM +0100, Roland Hieber wrote: > I think my current version of the patch gives us best of both worlds, > documentation of author intent as well as machine readability, so I > don't think anything is lost here by adding the SPDX tags. Any other comments here? - Roland -- Roland Hieber | r.hie...@pengutronix.de | Pengutronix e.K. | https://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH 1/6] include: add SPDX GPL-2.0-only license tags where applicable
On Fri, Feb 15, 2019 at 09:57:51AM +0100, Ahmad Fatoum wrote: > Hello, > > On 11/2/19 11:25, Roland Hieber wrote: > > On Fri, Feb 08, 2019 at 10:09:19AM +0100, Ahmad Fatoum wrote: > >> > >> > >> On 8/2/19 09:59, Roland Hieber wrote: > >>> On Fri, Feb 08, 2019 at 06:48:26AM +0100, Oleksij Rempel wrote: > Hi Roland, > > please remove deprecated license headers in same patch. > >>> > >>> I decided to leave them to record the original author's intent. There > >>> are several variations on the GPL headers in the project, the one > >>> extreme is the full GPL license header including a warranty disclaimer, > >>> but the other extreme is only a "GPLv2" and nothing more. We can decide > >>> on the project level to apply the warranty disclaimer. But by removing > >>> the license headers from individual files, the original author intent is > >>> lost – maybe the didn't want to include the disclaimer, maybe they > >>> didn't care, in any case it is not in our possibility to decide over > >>> their copyright matters and for most of the cases it is too late to > >>> track some of the people down and ask them. > >>> > >>> This all becomes important when someone forks our files to a new > >>> project. And if that someone does not know what the SPDX license tags > >>> actually mean, it's better to have the original documentation on the > >>> file level. > >>> > >>> I noticed that Linux usually removes the license headers and only keeps > >>> the copyright lines, but I wasn't able to find any reason for that. Do > >>> you have more insight here? > >> > >> (Obligatory IANAL) > > > > (Me neither) > > > >> With the copyright, the author states their right to deal as they > >> see fit with the source code. For example they may relicense. Replacing the > >> copyright with a SPDX-License-Identifier won't preserve this information. > > > > That sounds like an argument for leaving the copyright headers in the > > individual files? > > Yes, leave copyright/authorship lines, but replace license text with > SPDX-License-Identifier. Ah, we're talking about different things then. I was using "copyright headers" to include the "(c) author" line as well as the license statement. I think my current version of the patch gives us best of both worlds, documentation of author intent as well as machine readability, so I don't think anything is lost here by adding the SPDX tags. -- Roland Hieber | r.hie...@pengutronix.de | Pengutronix e.K. | https://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH 1/6] include: add SPDX GPL-2.0-only license tags where applicable
Hello, On 11/2/19 11:25, Roland Hieber wrote: > On Fri, Feb 08, 2019 at 10:09:19AM +0100, Ahmad Fatoum wrote: >> >> >> On 8/2/19 09:59, Roland Hieber wrote: >>> On Fri, Feb 08, 2019 at 06:48:26AM +0100, Oleksij Rempel wrote: Hi Roland, please remove deprecated license headers in same patch. >>> >>> I decided to leave them to record the original author's intent. There >>> are several variations on the GPL headers in the project, the one >>> extreme is the full GPL license header including a warranty disclaimer, >>> but the other extreme is only a "GPLv2" and nothing more. We can decide >>> on the project level to apply the warranty disclaimer. But by removing >>> the license headers from individual files, the original author intent is >>> lost – maybe the didn't want to include the disclaimer, maybe they >>> didn't care, in any case it is not in our possibility to decide over >>> their copyright matters and for most of the cases it is too late to >>> track some of the people down and ask them. >>> >>> This all becomes important when someone forks our files to a new >>> project. And if that someone does not know what the SPDX license tags >>> actually mean, it's better to have the original documentation on the >>> file level. >>> >>> I noticed that Linux usually removes the license headers and only keeps >>> the copyright lines, but I wasn't able to find any reason for that. Do >>> you have more insight here? >> >> (Obligatory IANAL) > > (Me neither) > >> With the copyright, the author states their right to deal as they >> see fit with the source code. For example they may relicense. Replacing the >> copyright with a SPDX-License-Identifier won't preserve this information. > > That sounds like an argument for leaving the copyright headers in the > individual files? Yes, leave copyright/authorship lines, but replace license text with SPDX-License-Identifier. > >> The license itself grants rights to others and, if it's a standard one, >> could be referenced by the Identifier, while the full text is reproduced >> only once at some central location (see my LICENSES directory patch below). > > There are two parts involved when applying the GPL. One part is the GPL > itself, which is written by the FSF, and is the generic license granting > rights and duties to users of the program for works that are licensed > under the GPL. The second part is the actual copyright statement, which > is written by the author of the (respective part of the) code, and which > must mention that a source file is actually licensed under the GPL. > This part usually, but not always, also contains a warranty disclaimer. > Although that second part is pre-formulated in the appendix "How to > Apply These Terms to Your New Programs" of the GPL, it can be seen in my > patch that the copyright statement historically has several different > variants, ranging from "this is GPLv2" to the full text that is > recommended in the GPL appendix (and also in the GPL FAQ [1]). It is the > author's sole right to choose the exact conditions in the copyright > statement on the file level, and I think by reducing those license > headers to only the copyright line transgresses that right. And, as I > said, the full copyright statement also serves as a fallback in case the > file is copied to a project that does not use the full SPDX process. I > also doubt that a single "SPDX-License-Identifier: GPL-2.0" line would > be sufficient to imply everything that is written in the full copyright > statement for every possible user of the source code. > > I welcome your patch for adding the LICENSES/* files, but I don't think > it solved the problem mentioned above, as LICENSES/preferred/GPL-2.0 > also only contains the text of the generic GPL, and not the authors' > copyright statement. > > [faq]: https://www.gnu.org/licenses/gpl-faq.en.html#NoticeInSourceFile > > - Roland > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH 1/6] include: add SPDX GPL-2.0-only license tags where applicable
On Fri, Feb 08, 2019 at 09:59:02AM +0100, Roland Hieber wrote: > I noticed that Linux usually removes the license headers and only keeps > the copyright lines, but I wasn't able to find any reason for that. Do > you have more insight here? I tried to google around a bit, and found several discussions, which all end in "SPDX is an industry-wide accepted standard" [1] and "SPDX-License-Identifiers are a legally binding shorthand" [2], but without further elaboration :-/ [1]: https://patchwork.kernel.org/patch/10045625/#21135079 [2]: e.g. here https://lore.kernel.org/patchwork/patch/854656/ or in the commit message of [1] too - Roland -- Roland Hieber | r.hie...@pengutronix.de | Pengutronix e.K. | https://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH 1/6] include: add SPDX GPL-2.0-only license tags where applicable
On Fri, Feb 08, 2019 at 10:09:19AM +0100, Ahmad Fatoum wrote: > > > On 8/2/19 09:59, Roland Hieber wrote: > > On Fri, Feb 08, 2019 at 06:48:26AM +0100, Oleksij Rempel wrote: > >> Hi Roland, > >> > >> please remove deprecated license headers in same patch. > > > > I decided to leave them to record the original author's intent. There > > are several variations on the GPL headers in the project, the one > > extreme is the full GPL license header including a warranty disclaimer, > > but the other extreme is only a "GPLv2" and nothing more. We can decide > > on the project level to apply the warranty disclaimer. But by removing > > the license headers from individual files, the original author intent is > > lost – maybe the didn't want to include the disclaimer, maybe they > > didn't care, in any case it is not in our possibility to decide over > > their copyright matters and for most of the cases it is too late to > > track some of the people down and ask them. > > > > This all becomes important when someone forks our files to a new > > project. And if that someone does not know what the SPDX license tags > > actually mean, it's better to have the original documentation on the > > file level. > > > > I noticed that Linux usually removes the license headers and only keeps > > the copyright lines, but I wasn't able to find any reason for that. Do > > you have more insight here? > > (Obligatory IANAL) (Me neither) > With the copyright, the author states their right to deal as they > see fit with the source code. For example they may relicense. Replacing the > copyright with a SPDX-License-Identifier won't preserve this information. That sounds like an argument for leaving the copyright headers in the individual files? > The license itself grants rights to others and, if it's a standard one, > could be referenced by the Identifier, while the full text is reproduced > only once at some central location (see my LICENSES directory patch below). There are two parts involved when applying the GPL. One part is the GPL itself, which is written by the FSF, and is the generic license granting rights and duties to users of the program for works that are licensed under the GPL. The second part is the actual copyright statement, which is written by the author of the (respective part of the) code, and which must mention that a source file is actually licensed under the GPL. This part usually, but not always, also contains a warranty disclaimer. Although that second part is pre-formulated in the appendix "How to Apply These Terms to Your New Programs" of the GPL, it can be seen in my patch that the copyright statement historically has several different variants, ranging from "this is GPLv2" to the full text that is recommended in the GPL appendix (and also in the GPL FAQ [1]). It is the author's sole right to choose the exact conditions in the copyright statement on the file level, and I think by reducing those license headers to only the copyright line transgresses that right. And, as I said, the full copyright statement also serves as a fallback in case the file is copied to a project that does not use the full SPDX process. I also doubt that a single "SPDX-License-Identifier: GPL-2.0" line would be sufficient to imply everything that is written in the full copyright statement for every possible user of the source code. I welcome your patch for adding the LICENSES/* files, but I don't think it solved the problem mentioned above, as LICENSES/preferred/GPL-2.0 also only contains the text of the generic GPL, and not the authors' copyright statement. [faq]: https://www.gnu.org/licenses/gpl-faq.en.html#NoticeInSourceFile - Roland -- Roland Hieber | r.hie...@pengutronix.de | Pengutronix e.K. | https://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH 1/6] include: add SPDX GPL-2.0-only license tags where applicable
On 8/2/19 09:59, Roland Hieber wrote: > On Fri, Feb 08, 2019 at 06:48:26AM +0100, Oleksij Rempel wrote: >> Hi Roland, >> >> please remove deprecated license headers in same patch. > > I decided to leave them to record the original author's intent. There > are several variations on the GPL headers in the project, the one > extreme is the full GPL license header including a warranty disclaimer, > but the other extreme is only a "GPLv2" and nothing more. We can decide > on the project level to apply the warranty disclaimer. But by removing > the license headers from individual files, the original author intent is > lost – maybe the didn't want to include the disclaimer, maybe they > didn't care, in any case it is not in our possibility to decide over > their copyright matters and for most of the cases it is too late to > track some of the people down and ask them. > > This all becomes important when someone forks our files to a new > project. And if that someone does not know what the SPDX license tags > actually mean, it's better to have the original documentation on the > file level. > > I noticed that Linux usually removes the license headers and only keeps > the copyright lines, but I wasn't able to find any reason for that. Do > you have more insight here? (Obligatory IANAL) With the copyright, the author states their right to deal as they see fit with the source code. For example they may relicense. Replacing the copyright with a SPDX-License-Identifier won't preserve this information. The license itself grants rights to others and, if it's a standard one, could be referenced by the Identifier, while the full text is reproduced only once at some central location (see my LICENSES directory patch below). Cheers Ahmad > > - Roland > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH 1/6] include: add SPDX GPL-2.0-only license tags where applicable
On Fri, Feb 08, 2019 at 06:48:26AM +0100, Oleksij Rempel wrote: > Hi Roland, > > please remove deprecated license headers in same patch. I decided to leave them to record the original author's intent. There are several variations on the GPL headers in the project, the one extreme is the full GPL license header including a warranty disclaimer, but the other extreme is only a "GPLv2" and nothing more. We can decide on the project level to apply the warranty disclaimer. But by removing the license headers from individual files, the original author intent is lost – maybe the didn't want to include the disclaimer, maybe they didn't care, in any case it is not in our possibility to decide over their copyright matters and for most of the cases it is too late to track some of the people down and ask them. This all becomes important when someone forks our files to a new project. And if that someone does not know what the SPDX license tags actually mean, it's better to have the original documentation on the file level. I noticed that Linux usually removes the license headers and only keeps the copyright lines, but I wasn't able to find any reason for that. Do you have more insight here? - Roland -- Roland Hieber | r.hie...@pengutronix.de | Pengutronix e.K. | https://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH 1/6] include: add SPDX GPL-2.0-only license tags where applicable
Hi Roland,
please remove deprecated license headers in same patch.
Am 07.02.19 um 23:39 schrieb Roland Hieber:
> Interpret "GPLv2" as "GPLv2 only".
>
> Signed-off-by: Roland Hieber
> ---
> include/aimage.h| 1 +
> include/aiodev.h| 1 +
> include/binfmt.h| 1 +
> include/bootstrap.h | 1 +
> include/bpkfs.h | 1 +
> include/ddr_spd.h | 1 +
> include/dhcp.h | 1 +
> include/digest.h| 1 +
> include/dma.h | 1 +
> include/firmware.h | 1 +
> include/getopt.h| 1 +
> include/local_mac_address.h | 1 +
> include/menu.h | 1 +
> include/of_graph.h | 1 +
> include/of_mtd.h| 1 +
> include/of_net.h| 1 +
> include/password.h | 1 +
> include/pbl.h | 1 +
> include/poller.h| 1 +
> include/shell.h | 1 +
> include/uimagefs.h | 1 +
> include/w1_mac_address.h| 1 +
> include/xymodem.h | 1 +
> 23 files changed, 23 insertions(+)
>
> diff --git a/include/aimage.h b/include/aimage.h
> index 9702b7d35c..0c7dda39ce 100644
> --- a/include/aimage.h
> +++ b/include/aimage.h
> @@ -1,15 +1,16 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> /*
> * (C) Copyright 2011 Jean-Christhophe PLAGNIOL-VILLARD
>
> *
> * Android boot image
> *
> * Under GPLv2 only
> */
>
> #ifndef __AIMAGE_H__
> #define __AIMAGE_H__
>
> #define BOOT_MAGIC "ANDROID!"
> #define BOOT_MAGIC_SIZE 8
> #define BOOT_NAME_SIZE 16
> #define BOOT_ARGS_SIZE 512
> diff --git a/include/aiodev.h b/include/aiodev.h
> index 5e38b4fab5..5f41554ad1 100644
> --- a/include/aiodev.h
> +++ b/include/aiodev.h
> @@ -1,15 +1,16 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> /*
> * core.c - Code implementing core functionality of AIODEV susbsystem
> *
> * Copyright (c) 2015 Sascha Hauer , Pengutronix
> * Copyright (c) 2015 Zodiac Inflight Innovation
> *
> * See file CREDITS for list of people who contributed to this
> * project.
> *
> * This program is free software; you can redistribute it and/or modify
> * it under the terms of the GNU General Public License version 2
> * as published by the Free Software Foundation.
> *
> * This program is distributed in the hope that it will be useful,
> * but WITHOUT ANY WARRANTY; without even the implied warranty of
> diff --git a/include/binfmt.h b/include/binfmt.h
> index 46b627e36d..b1fd2a72e8 100644
> --- a/include/binfmt.h
> +++ b/include/binfmt.h
> @@ -1,15 +1,16 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> /*
> * Copyright (C) 2012 Jean-Christophe PLAGNIOL-VILLARD
>
> *
> * GPL v2
> */
>
> #ifndef __BFMT_H__
> #define __BFMT_H__
>
> #include
> #include
>
> struct binfmt_hook {
> enum filetype type;
> int (*hook)(struct binfmt_hook *b, char *file, int argc, char **argv);
> diff --git a/include/bootstrap.h b/include/bootstrap.h
> index d3ee6be47c..6100f7be2f 100644
> --- a/include/bootstrap.h
> +++ b/include/bootstrap.h
> @@ -1,15 +1,16 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> /*
> * Copyright (C) 2012 Jean-Christophe PLAGNIOL-VILLARD
> *
> * Under GPLv2
> */
>
> #ifndef __BOOSTRAP_H__
> #define __BOOSTRAP_H__
>
> #include
>
> #define bootstrap_err(fmt, arg...) printf(fmt, ##arg)
>
> typedef void (*kernel_entry_func)(int zero, int arch, void *params);
> void bootstrap_boot(kernel_entry_func func, bool barebox);
> diff --git a/include/bpkfs.h b/include/bpkfs.h
> index ccb56c1419..49fbd5d48e 100644
> --- a/include/bpkfs.h
> +++ b/include/bpkfs.h
> @@ -1,15 +1,16 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> /*
> * Copyright (c) 2013 Jean-Christophe PLAGNIOL-VILLARD
>
> *
> * under GPLv2 only
> */
>
> #ifndef __BPKFS_H__
> #define __BPKFS_H__
>
> #include
> #include
>
> #define BPKFS_TYPE_BL0x50424c00
> #define BPKFS_TYPE_BLV 0x50424c56
> #define BPKFS_TYPE_DSC 0x44456343
> diff --git a/include/ddr_spd.h b/include/ddr_spd.h
> index 01fe73c615..18bb7c2751 100644
> --- a/include/ddr_spd.h
> +++ b/include/ddr_spd.h
> @@ -1,15 +1,16 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> /*
> * Copyright 2008 Freescale Semiconductor, Inc.
> *
> * This program is free software; you can redistribute it and/or
> * modify it under the terms of the GNU General Public License
> * Version 2 as published by the Free Software Foundation.
> */
>
> #ifndef _DDR_SPD_H_
> #define _DDR_SPD_H_
>
> /*
> * Format from "JEDEC Appendix X: Serial Presence Detects for DDR2 SDRAM",
> * SPD Revision 1.2
> */
> diff --git a/include/dhcp.h b/include/dhcp.h
> index 0dced8e9fa..55ffb10789 100644
> --- a/include/dhcp.h
> +++ b/include/dhcp.h
> @@ -1,15 +1,16 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> /*
> * Copyright (C) 2015 PHYTEC Messtechnik GmbH,
> * Author: Wadim Egorov
>
