Re: [PATCH v3 20/22] net: phy: Add basic driver for MV88E6XXX switches from Marvell

2018-10-15 Thread Sam Ravnborg
Hi Andrey. > > > + > > > + chip->miibus.read = mv88e6xxx_mdio_read; > > > + chip->miibus.write = mv88e6xxx_mdio_write; > > > > The function pointers are hardcoded here. > > But we have them in chip->info->ops - where we can > > have chip specific variants. > > I assume it would be more

Re: [PATCH v3 20/22] net: phy: Add basic driver for MV88E6XXX switches from Marvell

2018-10-15 Thread Andrey Smirnov
On Mon, Oct 15, 2018 at 2:19 PM Sam Ravnborg wrote: > > Hi Andrey. > > Some random nits while browsing the code. > > On Sun, Oct 14, 2018 at 07:21:23PM -0700, Andrey Smirnov wrote: > > Port a very abridged version of MV88E6XXX DSA driver from Linux > > kernel. Currently only internal MDIO bus