Re: [bareos-devel] race condition causing duplicate job names?

2019-12-29 Thread Anthony Vaccaro
Hi Frank and Philipp, Thanks for your feedback. I’ve sent a PR via github. Hope you both have a relaxing end of year holiday. Thanks for your work on bareos! Anthony On Sat, 28 Dec 2019 at 2:24 am, Frank Ueberschar < frank.uebersc...@bareos.com> wrote: > Anthony, > > Your proposal to have a

Re: [bareos-devel] race condition causing duplicate job names?

2019-12-27 Thread Frank Ueberschar
Anthony, Your proposal to have a local copy on the stack is solely the solution. Anything else would lock the mutex too long. I just saw your solution on Github. As Philipp said, we're happy to have your PR. Thanks and have a good start into 2020. Frank Am 27.12.19 um 10:49 schrieb

Re: [bareos-devel] race condition causing duplicate job names?

2019-12-27 Thread Philipp Storz
Hello Antony, thank you very much for your contribution and the detailed information. A pull request would be exactly the right thing to get your changes upstream. Because of the holiday season the response might take some time. Thank you very much and have a nice holiday season. Philipp Am

[bareos-devel] race condition causing duplicate job names?

2019-12-26 Thread Anthony Vaccaro
Hi all, I've been tracking down an issue we've been seeing on our bareos install, where restore jobs submitted at the same time end up with the same job name, which results in one of the jobs being rejected by the storage daemon and failing. I think i've found the issue in the source code,