[basedb-devel] ServicesUtil problem

[Woodbridge, Mark R]

Hi,

I might be misunderstanding the documentation but it appears that the Boolean 
flags that can be passed to the net.sf.basedb.info.QueryOptions constructor are 
ignored by net.sf.basedb.ws.server.ServicesUtil, as demonstrated by the failure 
of the following test:

@Test
public void servicesUtil() {
QueryOptions qOpts = new QueryOptions(false, null, null, null, 
null, null);
ItemQueryExperiment query = new 
ServicesUtil().getConfiguredItemQuery(Experiment.getQuery(), qOpts);
assertFalse(query.isIncluded(Include.MINE));
}

The attached patch should fix this problem, hopefully without breaking existing 
code.

Regards,

Mark.

--
Mark Woodbridge
CISBIC Data Management
Imperial College London


ServicesUtil.patch
Description: ServicesUtil.patch
--
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
___
basedb-devel mailing list
basedb-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/basedb-devel

Re: [basedb-devel] ServicesUtil problem

[Nicklas Nordborg]

Woodbridge, Mark R wrote:
 Hi,
 
  
 
 I might be misunderstanding the documentation but it appears that the 
 Boolean flags that can be passed to the net.sf.basedb.info.QueryOptions 
 constructor are ignored by net.sf.basedb.ws.server.ServicesUtil, as 
 demonstrated by the failure of the following test:

Thanks for reporting this. It seems like the query is already populated 
with some options (eg. Include.MINE is on by default). The 
ServicesUtil.getConfiguredItemQuery() is adding options that has been 
set to true, but is not removing options that has been set to false.

We'll try to fix it in BASE 2.14.2: http://base.thep.lu.se/ticket/1445

/Nicklas

--
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
___
basedb-devel mailing list
basedb-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/basedb-devel