Re: [Basket-devel] A patch for grabbing screen zone

2010-03-08 Thread Nicholas Sushkin
On Sunday 07 March 2010 10:01:44 jon.me...@gmail.com wrote: > Just pulled down your branch and I haven't seen any crashes after grabbing > a screen zone. > Looks good! > -Jon Confirming no crashes when compiled off of the gitorious branch. Great news, as I can start using basket again! Thanks a

Re: [Basket-devel] A patch for grabbing screen zone

2010-03-07 Thread Jon . Mease
Just pulled down your branch and I haven't seen any crashes after grabbing a screen zone. Looks good! -Jon On Mar 6, 2010 11:35pm, "Dr. Robert Marmorstein" wrote: Okay. I've merged the fix for KPassivePopup into my gitorious master branch. Please test and let me know if it fixes your i

Re: [Basket-devel] A patch for grabbing screen zone

2010-03-06 Thread Dr. Robert Marmorstein
Okay. I've merged the fix for KPassivePopup into my gitorious master branch. Please test and let me know if it fixes your issues. Robert On Friday 05 March 2010 3:15:52 pm Dr. Robert Marmorstein wrote: > Actually, I think the right approach is to use the static > KPassivePopup::message functio

Re: [Basket-devel] A patch for grabbing screen zone

2010-03-06 Thread Jon Mease
Thanks for the feedback Robert, yeah KPassivePopup::message function looks like exactly what we want. I'm fairly familiar with Qt but I'm just getting to know the KDE classes (there's certainly some neat stuff in there!). Thanks, -Jon -

Re: [Basket-devel] A patch for grabbing screen zone

2010-03-05 Thread Dr. Robert Marmorstein
Actually, I think the right approach is to use the static KPassivePopup::message function. One form of the function takes a QSystemTrayIcon* as a parent parameter (instead of a QWidget*), so I think that's what we should use. I'll try to commit it tonight. This would allow us to continue usin

[Basket-devel] A patch for grabbing screen zone

2010-03-05 Thread Jon Mease
Hello again, So I've looked over this a little more this morning and I think I have a solution (not necessarily the solution, that's up for discussion of course). I compared BNPView::showPassiveDroppedDelayed() to basket v1.0.3 and it's identical. The difference is that before when using KDE