On Sunday 13 December 2009 17:45:31 Albert Herranz wrote:
> The b43 driver includes a capability mechanism that open source firmwares
> (like OpenFWWF) can use to inform the driver about supported
> characteristics.
> The OpenFWWF firmware doesn't support yet QoS and reflects that via
> its capabilities word.
> QoS is enabled by default when b43 starts (unless modparam_qos is set to 0).
> If the capabilities word of the firmware loaded informs that QoS is not
> supported then QoS is disabled.
> 
> Unfortunately, due to an unidentified bug, this automatic disabling of
> QoS doesn't work properly. It works, though, if QoS is disabled from the very
> beginning.

Well, something in mac80211 was changed that breaks this.
mac80211 currently seems to assume that the number of queues does not change
after ieee80211_register, which was not the case previously. This breaks
the QoS disable, because b43 modifies the nr of queues variable in the
ieee80211_hw structure.

> This patch adds a config option to allow disabling QoS from the beginning.
> This is the only way to workaround the described problem when building the
> b43 driver in-kernel, as in that case modparam_qos can't be changed.
> 
> Signed-off-by: Albert Herranz <albert_herr...@yahoo.es>

Why are we currently adding all kind of workaround patches instead of fixing 
the bugs?
This bug's been there for months, so I don't see a reason to push out a 
workaround now.

-- 
Greetings, Michael.
_______________________________________________
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Reply via email to