Re: [Bcm43xx-dev] [PATCH] Fix for possible error in softmac version bcm43xx_wx_get_rangeparams

2006-01-11 Thread Michael Buesch
On Wednesday 11 January 2006 00:32, Carlo Marcelo Arenas Belon wrote: On Tue, Jan 10, 2006 at 02:43:10PM -0600, Larry Finger wrote: While reviewing the softmac version of r0utine bcm43xx_wx_get_rangeparams, I found the following code snippit: switch (bcm-current_core-phy-type)

[Bcm43xx-dev] [PATCH] Fix for possible error in softmac version bcm43xx_wx_get_rangeparams

2006-01-10 Thread Larry Finger
While reviewing the softmac version of r0utine bcm43xx_wx_get_rangeparams, I found the following code snippit: switch (bcm-current_core-phy-type) { case BCM43xx_PHYTYPE_A: case BCM43xx_PHYTYPE_G: range-num_bitrates += 4; range-bitrate[i++]

Re: [Bcm43xx-dev] [PATCH] Fix for possible error in softmac version bcm43xx_wx_get_rangeparams

2006-01-10 Thread Carlo Marcelo Arenas Belon
On Tue, Jan 10, 2006 at 02:43:10PM -0600, Larry Finger wrote: While reviewing the softmac version of r0utine bcm43xx_wx_get_rangeparams, I found the following code snippit: switch (bcm-current_core-phy-type) { case BCM43xx_PHYTYPE_A: case BCM43xx_PHYTYPE_G:

Re: [Bcm43xx-dev] [PATCH] Fix for possible error in softmac version bcm43xx_wx_get_rangeparams

2006-01-10 Thread Travis Friesen
Forgive my gross ignorance of code and 802.11, but somethign still does not seem right. Yes, I can see how it's beautifully optimized, what with the fall through and all, but it begs for a closer look. If we're using 802.11a, all the bitrates are set. Ok, I don't know much about 802.11a, but

[FIXED] Re: [Bcm43xx-dev] [PATCH] Fix for possible error in softmac version bcm43xx_wx_get_rangeparams

2006-01-10 Thread Stefano Brivio
On Tue, 10 Jan 2006 17:42:04 -0600 Travis Friesen [EMAIL PROTECTED] wrote: Forgive my gross ignorance of code and 802.11, but somethign still does not seem right. Yes, I can see how it's beautifully optimized, what with the fall through and all, but it begs for a closer look. Plus you