Re: [PATCH] b43: add config option to force QoS off

2009-12-15 Thread Johannes Berg
On Mon, 2009-12-14 at 22:43 +0100, Rafał Miłecki wrote: I believe we ieee80211_register_hw in b43 once but it may happen we reload firmware while having device still registered. Should we really ieee80211_unregister_hw and ieee80211_register_hw on every time we reload firmware (as we may load

Re: [PATCH] b43: add config option to force QoS off

2009-12-14 Thread Johannes Berg
On Sun, 2009-12-13 at 19:17 +0100, Albert Herranz wrote: Well, something in mac80211 was changed that breaks this. mac80211 currently seems to assume that the number of queues does not change after ieee80211_register, which was not the case previously. This breaks the QoS disable, because

Re: [PATCH] b43: add config option to force QoS off

2009-12-14 Thread Rafał Miłecki
2009/12/14 Johannes Berg johan...@sipsolutions.net: On Sun, 2009-12-13 at 19:17 +0100, Albert Herranz wrote: Well, something in mac80211 was changed that breaks this. mac80211 currently seems to assume that the number of queues does not change after ieee80211_register, which was not the

Re: [PATCH] b43: add config option to force QoS off

2009-12-13 Thread Michael Buesch
On Sunday 13 December 2009 17:45:31 Albert Herranz wrote: The b43 driver includes a capability mechanism that open source firmwares (like OpenFWWF) can use to inform the driver about supported characteristics. The OpenFWWF firmware doesn't support yet QoS and reflects that via its