Re: [PATCH] bcm43xx-mac80211: Fix specs typo for baseband attenuation

2007-07-26 Thread Larry Finger
John W. Linville wrote: On Thu, Jul 26, 2007 at 11:33:01AM -0500, Larry Finger wrote: A typo in the specs interchanges the branches in an if statement, which breaks operations for a BCM4306/rev 2 that has phy-analog == 1. @@ -1895,7 +1895,7 @@ void bcm43xx_phy_set_baseband_attenuatio

A problem with shared interrupts

2007-07-26 Thread Larry Finger
Michael, When I try the -mb tree on my old i386 notebook, I get an irq 11: nobody cared message and interrupts for the bcm43xx-mac80211 device are not initialized. The code in Linville's tree works. The only difference that seems to be important is the code returned when a shared interrupt not

Re: [PATCH] bcm43xx-mac80211: Fix specs typo for baseband attenuation

2007-07-26 Thread John W. Linville
On Thu, Jul 26, 2007 at 12:56:20PM -0500, Larry Finger wrote: John W. Linville wrote: On Thu, Jul 26, 2007 at 11:33:01AM -0500, Larry Finger wrote: A typo in the specs interchanges the branches in an if statement, which breaks operations for a BCM4306/rev 2 that has phy-analog == 1. @@

Re: [PATCH] bcm43xx-mac80211: Fix specs typo for baseband attenuation

2007-07-26 Thread Michael Buesch
On Thursday 26 July 2007 20:03:04 Larry Finger wrote: Michael Buesch wrote: Last time I checked this code it matched the specs. And that's not too long ago. Did the specs change? We had a complaint that a change in the V3 specs broke a BCM4306/rev 2 card using bcm43xx - it

Re: [PATCH] bcm43xx-mac80211: Fix specs typo for baseband attenuation

2007-07-26 Thread Larry Finger
Michael Buesch wrote: Last time I checked this code it matched the specs. And that's not too long ago. Did the specs change? We had a complaint that a change in the V3 specs broke a BCM4306/rev 2 card using bcm43xx - it received but did not transmit. I verified the breakage and found that

Re: [PATCH] bcm43xx-mac80211: Fix specs typo for baseband attenuation

2007-07-26 Thread John W. Linville
On Thu, Jul 26, 2007 at 11:33:01AM -0500, Larry Finger wrote: A typo in the specs interchanges the branches in an if statement, which breaks operations for a BCM4306/rev 2 that has phy-analog == 1. @@ -1895,7 +1895,7 @@ void bcm43xx_phy_set_baseband_attenuatio

BCM4318 ap problems

2007-07-26 Thread GNUtoo
hello, i have some problem with the ap mode: first i have a problem compiling hostapd 0.6.0 against the curent wireless-dev kernel: i686-pc-linux-gnu-gcc -O2 -march=pentium-m -pipe -DHOSTAPD_DUMP_STATE -I../src -I../src/crypto -I../src/utils -I../src/common -I/usr/include/madwifi

Re: A problem with shared interrupts

2007-07-26 Thread Larry Finger
Michael Buesch wrote: I neither think this is the correct solution, nor do I think that this is the way bcm43xx-softmac does it. This would always return HANDLED, right? regardless if the IRQ was for bcm43xx or not. I _do_ think that the bug is in the driver sharing the IRQ with bcm43xx.

Re: [PATCH] bcm43xx-mac80211: Fix specs typo for baseband attenuation

2007-07-26 Thread Michael Buesch
On Thursday 26 July 2007 21:26:01 John W. Linville wrote: On Thu, Jul 26, 2007 at 01:49:58PM -0500, Larry Finger wrote: John W. Linville wrote: Hmmm...well, if you asked to revert it on bcm43xx, why is it appropriate here? AFAIK, the V4 specs have always had the typo, thus there

Re: [PATCH] bcm43xx-mac80211: Fix specs typo for baseband attenuation

2007-07-26 Thread Michael Buesch
On Thursday 26 July 2007 18:33:01 Larry Finger wrote: A typo in the specs interchanges the branches in an if statement, which breaks operations for a BCM4306/rev 2 that has phy-analog == 1. Signed-off-by: Larry Finger[EMAIL PROTECTED] --- John and Michael, This patch is made for the

[PATCH] bcm43xx-mac80211: Fix specs typo for baseband attenuation

2007-07-26 Thread Larry Finger
A typo in the specs interchanges the branches in an if statement, which breaks operations for a BCM4306/rev 2 that has phy-analog == 1. Signed-off-by: Larry Finger[EMAIL PROTECTED] --- John and Michael, This patch is made for the wireless-dev tree after the bcm43xx-mac80211 directory has been

Re: [PATCH] bcm43xx-mac80211: Fix specs typo for baseband attenuation

2007-07-26 Thread Larry Finger
John W. Linville wrote: Hmmm...well, if you asked to revert it on bcm43xx, why is it appropriate here? AFAIK, the V4 specs have always had the typo, thus there was no patch introducing this error - it is original. On the other hand, the V3 specs were modified fairly late in the process,