Re: [PATCH] b43: Fix typo in firmware file name for 802.11 cores with rev 13
Michael Buesch wrote: > On Thursday 15 May 2008 21:53:48 Pavel Roskin wrote: >> On Thu, 2008-05-15 at 21:39 +0200, Michael Buesch wrote: >> This is 2.6.27 material. Although it is a bug in 2.6.25 and .26, it seems to have zero effect on the performance of the device and can be delayed. >>> Exactly. That's why I decided to delay it :P >> Actually, it it's a bug and there is a simple fix unlikely to break > > Oh well. "unlikely to break" is it in your opinion, only. > One fact is that current code does work fine. Another one is that the > right initvals, which would be used after the fix, are obviously untested. > Not exactly untested. I've been running for 2 days with this patch in and have seen no bad effects. My 4311/2 and the G part of 4312/2 are the only cards that will be affected. Larry ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH] b43: Fix typo in firmware file name for 802.11 cores with rev 13
On Thu, May 15, 2008 at 02:07:36PM -0500, [EMAIL PROTECTED] wrote: > When the patch for the BCM4311 rev 2 was prepared, I misread the specs > and coded the wrong file name for the initvals firmware. > > Signed-off-by: Larry Finger <[EMAIL PROTECTED]> > --- > > John, > > This is 2.6.27 material. Although it is a bug in 2.6.25 and .26, it > seems to have zero effect on the performance of the device and can > be delayed. Would you prefer to have it in 2.6.26 "just in case"? Or might that cause a problem somehow? John -- John W. Linville [EMAIL PROTECTED] ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH] b43: Fix typo in firmware file name for 802.11 cores with rev 13
On Thursday 15 May 2008 21:53:48 Pavel Roskin wrote: > On Thu, 2008-05-15 at 21:39 +0200, Michael Buesch wrote: > > > > This is 2.6.27 material. Although it is a bug in 2.6.25 and .26, it > > > seems to have zero effect on the performance of the device and can > > > be delayed. > > > > Exactly. That's why I decided to delay it :P > > Actually, it it's a bug and there is a simple fix unlikely to break Oh well. "unlikely to break" is it in your opinion, only. One fact is that current code does work fine. Another one is that the right initvals, which would be used after the fix, are obviously untested. -- Greetings Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH] b43: Fix typo in firmware file name for 802.11 cores with rev 13
On Thu, 2008-05-15 at 21:39 +0200, Michael Buesch wrote: > > This is 2.6.27 material. Although it is a bug in 2.6.25 and .26, it > > seems to have zero effect on the performance of the device and can > > be delayed. > > Exactly. That's why I decided to delay it :P Actually, it it's a bug and there is a simple fix unlikely to break anything, it should go to 2.6.26. The whole point of having release candidates is fixing bugs. If nothing else, the fix should be applied out of respect to the users of 2.6.26 who will be wondering where to get "lp0initvals13". It's just a suggestion, I'm not trying to start a flamewar :-) -- Regards, Pavel Roskin ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH] b43: Fix typo in firmware file name for 802.11 cores with rev 13
On Thursday 15 May 2008 21:07:36 [EMAIL PROTECTED] wrote: > When the patch for the BCM4311 rev 2 was prepared, I misread the specs > and coded the wrong file name for the initvals firmware. You didn't misread it. The specs changed recently. And I think the bsinitvals also have to be rechecked. I'll do the right patch later, which also takes care of the LP-PHY > Signed-off-by: Larry Finger <[EMAIL PROTECTED]> > --- > > John, > > This is 2.6.27 material. Although it is a bug in 2.6.25 and .26, it > seems to have zero effect on the performance of the device and can > be delayed. Exactly. That's why I decided to delay it :P > Larry > > Index: wireless-testing/drivers/net/wireless/b43/main.c > === > --- wireless-testing.orig/drivers/net/wireless/b43/main.c > +++ wireless-testing/drivers/net/wireless/b43/main.c > @@ -1960,7 +1960,7 @@ static int b43_request_firmware(struct b > if ((rev >= 5) && (rev <= 10)) > filename = "b0g0initvals5"; > else if (rev >= 13) > - filename = "lp0initvals13"; > + filename = "b0g0initvals13"; > else > goto err_no_initvals; > break; > > -- Greetings Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
[PATCH] b43: Fix typo in firmware file name for 802.11 cores with rev 13
When the patch for the BCM4311 rev 2 was prepared, I misread the specs and coded the wrong file name for the initvals firmware. Signed-off-by: Larry Finger <[EMAIL PROTECTED]> --- John, This is 2.6.27 material. Although it is a bug in 2.6.25 and .26, it seems to have zero effect on the performance of the device and can be delayed. Larry Index: wireless-testing/drivers/net/wireless/b43/main.c === --- wireless-testing.orig/drivers/net/wireless/b43/main.c +++ wireless-testing/drivers/net/wireless/b43/main.c @@ -1960,7 +1960,7 @@ static int b43_request_firmware(struct b if ((rev >= 5) && (rev <= 10)) filename = "b0g0initvals5"; else if (rev >= 13) - filename = "lp0initvals13"; + filename = "b0g0initvals13"; else goto err_no_initvals; break; ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: 4311 v2 Bail - 2.6.26-rc2
> > We really need a raw monitor frame capture. > > Not sure how I go about that one? > > I have an external RTL8187 device I can stick into monitor mode? But > then it wouldn't be associated/encryption keys... > > Tips anyone? In this case, adding a monitor interface to your local b43 machine (with iw: http://wireless.kernel.org/en/users/Documentation/iw) might be preferable. johannes signature.asc Description: This is a digitally signed message part ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: 4311 v2 Bail - 2.6.26-rc2
Hello, Johannes Berg wrote: > We really need a raw monitor frame capture. Not sure how I go about that one? I have an external RTL8187 device I can stick into monitor mode? But then it wouldn't be associated/encryption keys... Tips anyone? Cheers, Dan. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: bcm 4315
[EMAIL PROTECTED] wrote: > Here are what seem to be the pertinent portions of dmesg output. Let me know > if you want the whole thing and I'll send it directly. > > I don't know what all that corrupt SPROM CRC stuff is all about. I followed > the directions to extract the firmware to /lib/firmware using b43-fwcutter. > Not sure if that's the same thing, though. > > Linux version 2.6.24-gentoo-r4 ([EMAIL PROTECTED]) (gcc version 4.1.2 (Gentoo > 4.1.2 p1.1)) #1 SMP Wed May 14 18:11:04 EDT 2008 > [snip] > PCI: Setting latency timer of device :02:00.0 to 64 > ssb: Core 0 found: ChipCommon (cc 0x800, rev 0x16, vendor 0x4243) > ssb: Core 1 found: IEEE 802.11 (cc 0x812, rev 0x0F, vendor 0x4243) > ssb: Core 2 found: PCMCIA (cc 0x80D, rev 0x0A, vendor 0x4243) > ssb: Core 3 found: PCI-E (cc 0x820, rev 0x09, vendor 0x4243) > ssb: WARNING: Invalid SPROM CRC (corrupt SPROM) > ssb: Unsupported SPROM revision 255 detected. Will extract v1 > WARNING: at drivers/ssb/main.c:883 ssb_tmslow_reject_bitmask() > Pid: 5404, comm: modprobe Not tainted 2.6.24-gentoo-r4 #1 > [] [] [] [] [] > [] [] [] [] [] > [] [] [] [] [] > [] [] [] [] [] > [] [] [] [] [] > [] [] === > ssb: Sonics Silicon Backplane found on PCI device :02:00.0 > [snip] > > lspci -nnv output (for completeness) > > 02:00.0 Network controller [0280]: Broadcom Corporation BCM4310 USB > Controller [14e4:4315] (rev 01) I also have one of these devices that are reported as a BCM4310 USB. It has an LP-PHY, and is not supported by any current driver. It also has a rev 8 SPROM and we do not know where the information is stored in the PROM. In fact, I am working on the reverse engineering in order to write the specifications so that the driver can be modified. As much as I hate to make this recommendation, your only recourse is to use ndiswrapper and the Windows driver. I was fortunate enough to have a BCM4311/2 on the shelf, which I used to replace the BCM4310 - at least for the moment. Larry ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
