Re: [PATCH] b43: Fix MAC control and microcode init

2008-01-25 Thread Johannes Berg
This also adds a longer delay for waiting for the microcode to initialize itself. It seems that the current timeout is sufficient on all available devices, but there's no real reason why we shouldn't wait for up to one second. Slow embedded devices might exist. Your decision, but I very much

Re: [PATCH] b43: Fix MAC control and microcode init

2008-01-25 Thread Michael Buesch
On Thursday 24 January 2008 10:13:01 Johannes Berg wrote: This also adds a longer delay for waiting for the microcode to initialize itself. It seems that the current timeout is sufficient on all available devices, but there's no real reason why we shouldn't wait for up to one second.

[PATCH] b43: Fix MAC control and microcode init

2008-01-22 Thread Michael Buesch
This zeros out all microcode related memory before loading the microcode. This also fixes initialization of the MAC control register. The _only_ place where we overwrite the contents of the MAC control register is at the beginning of b43_chip_init(). All other places must do read() - mask/set -