[PATCH] b43: Fix typo in firmware file name for 802.11 cores with rev 13
When the patch for the BCM4311 rev 2 was prepared, I misread the specs and coded the wrong file name for the initvals firmware. Signed-off-by: Larry Finger [EMAIL PROTECTED] --- John, This is 2.6.27 material. Although it is a bug in 2.6.25 and .26, it seems to have zero effect on the performance of the device and can be delayed. Larry Index: wireless-testing/drivers/net/wireless/b43/main.c === --- wireless-testing.orig/drivers/net/wireless/b43/main.c +++ wireless-testing/drivers/net/wireless/b43/main.c @@ -1960,7 +1960,7 @@ static int b43_request_firmware(struct b if ((rev = 5) (rev = 10)) filename = b0g0initvals5; else if (rev = 13) - filename = lp0initvals13; + filename = b0g0initvals13; else goto err_no_initvals; break; ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH] b43: Fix typo in firmware file name for 802.11 cores with rev 13
On Thursday 15 May 2008 21:07:36 [EMAIL PROTECTED] wrote: When the patch for the BCM4311 rev 2 was prepared, I misread the specs and coded the wrong file name for the initvals firmware. You didn't misread it. The specs changed recently. And I think the bsinitvals also have to be rechecked. I'll do the right patch later, which also takes care of the LP-PHY Signed-off-by: Larry Finger [EMAIL PROTECTED] --- John, This is 2.6.27 material. Although it is a bug in 2.6.25 and .26, it seems to have zero effect on the performance of the device and can be delayed. Exactly. That's why I decided to delay it :P Larry Index: wireless-testing/drivers/net/wireless/b43/main.c === --- wireless-testing.orig/drivers/net/wireless/b43/main.c +++ wireless-testing/drivers/net/wireless/b43/main.c @@ -1960,7 +1960,7 @@ static int b43_request_firmware(struct b if ((rev = 5) (rev = 10)) filename = b0g0initvals5; else if (rev = 13) - filename = lp0initvals13; + filename = b0g0initvals13; else goto err_no_initvals; break; -- Greetings Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH] b43: Fix typo in firmware file name for 802.11 cores with rev 13
On Thu, 2008-05-15 at 21:39 +0200, Michael Buesch wrote: This is 2.6.27 material. Although it is a bug in 2.6.25 and .26, it seems to have zero effect on the performance of the device and can be delayed. Exactly. That's why I decided to delay it :P Actually, it it's a bug and there is a simple fix unlikely to break anything, it should go to 2.6.26. The whole point of having release candidates is fixing bugs. If nothing else, the fix should be applied out of respect to the users of 2.6.26 who will be wondering where to get lp0initvals13. It's just a suggestion, I'm not trying to start a flamewar :-) -- Regards, Pavel Roskin ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH] b43: Fix typo in firmware file name for 802.11 cores with rev 13
On Thursday 15 May 2008 21:53:48 Pavel Roskin wrote: On Thu, 2008-05-15 at 21:39 +0200, Michael Buesch wrote: This is 2.6.27 material. Although it is a bug in 2.6.25 and .26, it seems to have zero effect on the performance of the device and can be delayed. Exactly. That's why I decided to delay it :P Actually, it it's a bug and there is a simple fix unlikely to break Oh well. unlikely to break is it in your opinion, only. One fact is that current code does work fine. Another one is that the right initvals, which would be used after the fix, are obviously untested. -- Greetings Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH] b43: Fix typo in firmware file name for 802.11 cores with rev 13
On Thu, May 15, 2008 at 02:07:36PM -0500, [EMAIL PROTECTED] wrote: When the patch for the BCM4311 rev 2 was prepared, I misread the specs and coded the wrong file name for the initvals firmware. Signed-off-by: Larry Finger [EMAIL PROTECTED] --- John, This is 2.6.27 material. Although it is a bug in 2.6.25 and .26, it seems to have zero effect on the performance of the device and can be delayed. Would you prefer to have it in 2.6.26 just in case? Or might that cause a problem somehow? John -- John W. Linville [EMAIL PROTECTED] ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH] b43: Fix typo in firmware file name for 802.11 cores with rev 13
Michael Buesch wrote: On Thursday 15 May 2008 21:53:48 Pavel Roskin wrote: On Thu, 2008-05-15 at 21:39 +0200, Michael Buesch wrote: This is 2.6.27 material. Although it is a bug in 2.6.25 and .26, it seems to have zero effect on the performance of the device and can be delayed. Exactly. That's why I decided to delay it :P Actually, it it's a bug and there is a simple fix unlikely to break Oh well. unlikely to break is it in your opinion, only. One fact is that current code does work fine. Another one is that the right initvals, which would be used after the fix, are obviously untested. Not exactly untested. I've been running for 2 days with this patch in and have seen no bad effects. My 4311/2 and the G part of 4312/2 are the only cards that will be affected. Larry ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
