Re: [PATCH] b43: silence a bogus gcc warning
On Sunday 11 November 2007 10:27:03 Frank Lichtenheld wrote: > On Sat, Nov 10, 2007 at 05:27:43PM +0100, Michael Buesch wrote: > > On Saturday 10 November 2007 16:25:33 John W. Linville wrote: > > > On Sat, Nov 10, 2007 at 04:14:03PM +0100, Michael Buesch wrote: > > > > From: Frank Lichtenheld <[EMAIL PROTECTED]> > > > > > > > > inititalise ret to 0 to avoid the following bogus warning: > > > > CC [M] drivers/net/wireless/b43/debugfs.o > > > > drivers/net/wireless/b43/debugfs.c: In function ‘b43_debugfs_read’: > > > > drivers/net/wireless/b43/debugfs.c:355: warning: ‘ret’ may be used > > > > uninitialized in this function > > > > > > > > Signed-off-by: Frank Lichtenheld <[EMAIL PROTECTED]> > > > > Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> > > > > > > Isn't this what uninitialized_var() is for? > > Erh, I didn't actually knew that existed, sorry. > OTOH in this case it is actually longer to write. > > > I'd be OK with that, too. > > Should I send a changed patch? Yes. -- Greetings Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH] b43: silence a bogus gcc warning
On Saturday 10 November 2007 16:25:33 John W. Linville wrote: > On Sat, Nov 10, 2007 at 04:14:03PM +0100, Michael Buesch wrote: > > From: Frank Lichtenheld <[EMAIL PROTECTED]> > > > > inititalise ret to 0 to avoid the following bogus warning: > > CC [M] drivers/net/wireless/b43/debugfs.o > > drivers/net/wireless/b43/debugfs.c: In function ‘b43_debugfs_read’: > > drivers/net/wireless/b43/debugfs.c:355: warning: ‘ret’ may be used > > uninitialized in this function > > > > Signed-off-by: Frank Lichtenheld <[EMAIL PROTECTED]> > > Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> > > Isn't this what uninitialized_var() is for? > I'd be OK with that, too. -- Greetings Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH] b43: silence a bogus gcc warning
On Sat, Nov 10, 2007 at 04:14:03PM +0100, Michael Buesch wrote: > From: Frank Lichtenheld <[EMAIL PROTECTED]> > > inititalise ret to 0 to avoid the following bogus warning: > CC [M] drivers/net/wireless/b43/debugfs.o > drivers/net/wireless/b43/debugfs.c: In function ‘b43_debugfs_read’: > drivers/net/wireless/b43/debugfs.c:355: warning: ‘ret’ may be used > uninitialized in this function > > Signed-off-by: Frank Lichtenheld <[EMAIL PROTECTED]> > Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Isn't this what uninitialized_var() is for? -- John W. Linville [EMAIL PROTECTED] ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
[PATCH] b43: silence a bogus gcc warning
From: Frank Lichtenheld <[EMAIL PROTECTED]> inititalise ret to 0 to avoid the following bogus warning: CC [M] drivers/net/wireless/b43/debugfs.o drivers/net/wireless/b43/debugfs.c: In function ‘b43_debugfs_read’: drivers/net/wireless/b43/debugfs.c:355: warning: ‘ret’ may be used uninitialized in this function Signed-off-by: Frank Lichtenheld <[EMAIL PROTECTED]> Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> --- drivers/net/wireless/b43/debugfs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/b43/debugfs.c b/drivers/net/wireless/b43/debugfs.c index 734e70e..d8ac058 100644 --- a/drivers/net/wireless/b43/debugfs.c +++ b/drivers/net/wireless/b43/debugfs.c @@ -352,7 +352,7 @@ static ssize_t b43_debugfs_read(struct file *file, char __user *userbuf, struct b43_wldev *dev; struct b43_debugfs_fops *dfops; struct b43_dfs_file *dfile; - ssize_t ret; + ssize_t ret = 0; char *buf; const size_t bufsize = 1024 * 128; const size_t buforder = get_order(bufsize); -- 1.5.3.4 --- -- Greetings Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
