Re: [PATCH 2/2] b43: Add lpphy_clear_tx_power_offsets to improve TX Power handling

2009-09-16 Thread Gábor Stefanik
You are essentially implementing dead code at this point - this will only ever be called if hardware-accelerated TX power control is enabled - and HW TX power control is unsupported, even for G-PHYs. On Wed, Sep 16, 2009 at 9:37 PM, Thomas Ilnseher il...@gmx.de wrote: This patch adds the

Re: [PATCH 2/2] b43: Add lpphy_clear_tx_power_offsets to improve TX Power handling

2009-09-16 Thread Gábor Stefanik
2009/9/16 Thomas Ilnseher il...@gmx.de: Am Mittwoch, den 16.09.2009, 21:40 +0200 schrieb Gábor Stefanik: You are essentially implementing dead code at this point - this will only ever be called if hardware-accelerated TX power control is enabled - and HW TX power control is unsupported, even

Re: [PATCH 2/2] b43: Add lpphy_clear_tx_power_offsets to improve TX Power handling

2009-09-16 Thread Michael Buesch
On Wednesday 16 September 2009 22:17:55 Thomas Ilnseher wrote: Am Mittwoch, den 16.09.2009, 21:40 +0200 schrieb Gábor Stefanik: You are essentially implementing dead code at this point - this will only ever be called if hardware-accelerated TX power control is enabled - and HW TX power

Re: [PATCH 2/2] b43: Add lpphy_clear_tx_power_offsets to improve TX Power handling

2009-09-16 Thread Thomas Ilnseher
Put a printk here to see if this branch is getting hit. (BTW, are you loading b43 with the hwpctl modparam? That enables experimental HW TX power control support, which might explain what you were seeing.) Hi Gabor, I'm stupid. I applied 3 Patches, the analog switch patch, and the other