Re: [PATCH 2/6] b43: N-PHY: add RSSI functions: poll and set 2055 vcm

2010-01-11 Thread Michael Buesch
On Monday 11 January 2010 03:38:53 Larry Finger wrote: > Yes, my fault. The specs are now corrected so that these statements are > > ((s8)((s[1] >> 8) & 0x3F) << 2) >> 2 > > I think that is right. No it is not. You need to do this: (s8)(((s[1] >> 8) & 0x3F) << 2) >> 2 Alternatively add another

Re: [PATCH 2/6] b43: N-PHY: add RSSI functions: poll and set 2055 vcm

2010-01-10 Thread Larry Finger
On 01/10/2010 04:32 PM, Michael Buesch wrote: > On Sunday 10 January 2010 23:13:20 Rafał Miłecki wrote: >> +buf[0] += (s8)(((s[0] & 0x3F) << 2) >> 2); >> +buf[1] += (s8)s[0] >> 8) & 0x3F) << 2) >> 2); >> +buf[2] += (s8)(((s[1] & 0x3F) << 2) >> 2); >> +

Re: [PATCH 2/6] b43: N-PHY: add RSSI functions: poll and set 2055 vcm

2010-01-10 Thread Michael Buesch
On Monday 11 January 2010 01:27:48 Larry Finger wrote: > On 01/10/2010 04:32 PM, Michael Buesch wrote: > > On Sunday 10 January 2010 23:13:20 Rafał Miłecki wrote: > >> + buf[0] += (s8)(((s[0] & 0x3F) << 2) >> 2); > >> + buf[1] += (s8)s[0] >> 8) & 0x3F) << 2) >> 2); > >> +

Re: [PATCH 2/6] b43: N-PHY: add RSSI functions: poll and set 2055 vcm

2010-01-10 Thread Larry Finger
On 01/10/2010 04:32 PM, Michael Buesch wrote: > On Sunday 10 January 2010 23:13:20 Rafał Miłecki wrote: >> +buf[0] += (s8)(((s[0] & 0x3F) << 2) >> 2); >> +buf[1] += (s8)s[0] >> 8) & 0x3F) << 2) >> 2); >> +buf[2] += (s8)(((s[1] & 0x3F) << 2) >> 2); >> +

Re: [PATCH 2/6] b43: N-PHY: add RSSI functions: poll and set 2055 vcm

2010-01-10 Thread Michael Buesch
On Sunday 10 January 2010 23:13:20 Rafał Miłecki wrote: > + buf[0] += (s8)(((s[0] & 0x3F) << 2) >> 2); > + buf[1] += (s8)s[0] >> 8) & 0x3F) << 2) >> 2); > + buf[2] += (s8)(((s[1] & 0x3F) << 2) >> 2); > + buf[3] += (s8)s[1] >> 8) & 0x3F) << 2)

[PATCH 2/6] b43: N-PHY: add RSSI functions: poll and set 2055 vcm

2010-01-10 Thread Rafał Miłecki
Signed-off-by: Rafał Miłecki --- drivers/net/wireless/b43/phy_n.c | 96 ++ 1 files changed, 96 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c index a44fca1..d7e408b 100644 --- a/drivers/net/w