Re: [RFC PATCH] b43: Implement LP-PHY baseband table initialization

2009-08-10 Thread Gábor Stefanik
2009/8/10 Larry Finger larry.fin...@lwfinger.net: Gábor Stefanik wrote: Implement LP-PHY baseband table init for all revisions. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- Sorry for the size; it's difficult to cut short changes like this (most of the patch is just table

Re: [RFC PATCH] b43: Implement LP-PHY baseband table initialization

2009-08-10 Thread Michael Buesch
On Monday 10 August 2009 03:00:46 Gábor Stefanik wrote: +static const u16 lpphy_sw_control_table[] = { + 0x0128, + 0x0128, + 0x0009, + 0x0009, + 0x0028, + 0x0028, Is it possible to use more than one value per line for all these tables? Make sure to make best use of

Re: [RFC PATCH] b43: Implement LP-PHY baseband table initialization

2009-08-10 Thread Gábor Stefanik
2009/8/10 Michael Buesch m...@bu3sch.de: On Monday 10 August 2009 03:00:46 Gábor Stefanik wrote: +static const u16 lpphy_sw_control_table[] = { +     0x0128, +     0x0128, +     0x0009, +     0x0009, +     0x0028, +     0x0028, Is it possible to use more than one value per line for all

Re: [RFC PATCH] b43: Implement LP-PHY baseband table initialization

2009-08-10 Thread Michael Buesch
On Monday 10 August 2009 14:49:31 Gábor Stefanik wrote: 2009/8/10 Michael Buesch m...@bu3sch.de: On Monday 10 August 2009 03:00:46 Gábor Stefanik wrote: +static const u16 lpphy_sw_control_table[] = { +     0x0128, +     0x0128, +     0x0009, +     0x0009, +     0x0028, +    

Re: [RFC PATCH] b43: Implement LP-PHY baseband table initialization

2009-08-10 Thread Holger Schurig
Well, I converted the tables directly from the Wikitext on bcm-v4.sipsolutions.net using regex searchreplace - if you know a good regex to convert the tables to use multiple values on each line, please post it. An emacs macro ? Or use any other editor with an macro capability. --

Re: [RFC PATCH] b43: Implement LP-PHY baseband table initialization

2009-08-10 Thread Larry Finger
Gábor Stefanik wrote: 2009/8/10 Larry Finger larry.fin...@lwfinger.net: Gábor Stefanik wrote: Implement LP-PHY baseband table init for all revisions. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- Sorry for the size; it's difficult to cut short changes like this (most of the

Re: [RFC PATCH] b43: Implement LP-PHY baseband table initialization

2009-08-10 Thread Gábor Stefanik
2009/8/10 Larry Finger larry.fin...@lwfinger.net: Gábor Stefanik wrote: 2009/8/10 Larry Finger larry.fin...@lwfinger.net: Gábor Stefanik wrote: Implement LP-PHY baseband table init for all revisions. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- Sorry for the size; it's

Re: [RFC PATCH] b43: Implement LP-PHY baseband table initialization

2009-08-10 Thread Larry Finger
Gábor Stefanik wrote: 2009/8/10 Larry Finger larry.fin...@lwfinger.net: Yes, that would work for the 2.4 GHz band, and I guess there could be similar routines or macros to split the 5 GHz band into low, medium and high channels. AFAIK there is no need to do that - using current_band for

Re: [RFC PATCH] b43: Implement LP-PHY baseband table initialization

2009-08-10 Thread Peter Stuge
Gábor Stefanik wrote: +     0x0128, +     0x0128, +     0x0009, +     0x0009, +     0x0028, +     0x0028, Is it possible to use more than one value per line for all these tables? if you know a good regex to convert the tables to use multiple values on each line, please post

Re: [RFC PATCH] b43: Implement LP-PHY baseband table initialization

2009-08-10 Thread Michael Buesch
On Monday 10 August 2009 14:52:49 Michael Buesch wrote: On Monday 10 August 2009 14:49:31 Gábor Stefanik wrote: 2009/8/10 Michael Buesch m...@bu3sch.de: On Monday 10 August 2009 03:00:46 Gábor Stefanik wrote: +static const u16 lpphy_sw_control_table[] = { +     0x0128, +     0x0128,

Re: [RFC PATCH] b43: Implement LP-PHY baseband table initialization

2009-08-09 Thread Larry Finger
Gábor Stefanik wrote: Implement LP-PHY baseband table init for all revisions. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- Sorry for the size; it's difficult to cut short changes like this (most of the patch is just table data). Please review, there may always be bugs that I