[RFC V2] b43: A patch for control of the radio LED using rfkill

2008-09-18 Thread Larry Finger
The changes below, along with Henriques patch [PATCH] rfkill: update LEDs for all state changes, and the reversion of commit bc19d6e make the wireless LED toggle correctly. This version passes UNBLOCKED to rfkill when the hardware switch enables the radio. Most of this material comes from

Re: [RFC V2] b43: A patch for control of the radio LED using rfkill

2008-09-18 Thread Larry Finger
Henrique de Moraes Holschuh wrote: IMHO if tx power off is handled by the wireless device driver through the software rfkill line, it DOES MEAN the radio goes into rfkill SOFT_BLOCK. As long as the rfkill class is kept syncronized with reality through the use of rfkill_force_state(), this

Re: [RFC V2] b43: A patch for control of the radio LED using rfkill

2008-09-18 Thread Larry Finger
Henrique de Moraes Holschuh wrote: The problem is in the should. Maybe something else than b43 (like firmware) changed the radio software rfkill bit, and it does not match what mac80211 and userland requested anymore. What you need to pass to rfkill_force_state() is what the radio is

Re: [RFC V2] b43: A patch for control of the radio LED using rfkill

2008-09-18 Thread Michael Buesch
On Thursday 18 September 2008 16:24:05 Henrique de Moraes Holschuh wrote: On Thu, 18 Sep 2008, Larry Finger wrote: The changes below, along with Henriques patch [PATCH] rfkill: update LEDs for all state changes, and the reversion of commit bc19d6e make the wireless LED toggle correctly.

Re: [RFC V2] b43: A patch for control of the radio LED using rfkill

2008-09-18 Thread Michael Buesch
On Thursday 18 September 2008 18:49:01 Larry Finger wrote: Henrique de Moraes Holschuh wrote: The problem is in the should. Maybe something else than b43 (like firmware) changed the radio software rfkill bit, and it does not match what mac80211 and userland requested anymore.

Re: [RFC V2] b43: A patch for control of the radio LED using rfkill

2008-09-18 Thread Michael Buesch
On Thursday 18 September 2008 16:48:36 Henrique de Moraes Holschuh wrote: On Thu, 18 Sep 2008, Ivo van Doorn wrote: On Thursday 18 September 2008, Henrique de Moraes Holschuh wrote: On Thu, 18 Sep 2008, Larry Finger wrote: The changes below, along with Henriques patch [PATCH] rfkill: