Re: PCI config register 0x40

2009-12-19 Thread Michael Buesch
On Saturday 19 December 2009 07:26:10 Larry Finger wrote: Michael, As you may recall, I dumped writes to the PCI config space for both b43 and the wl driver. I found that wl wrote to address 0x40. In looking around other drivers, I found the following fragment in ipw2100: /* We

Re: PCI config register 0x40

2009-12-19 Thread Larry Finger
On 12/19/2009 04:11 AM, Michael Buesch wrote: Well, if 0x40 is used as RETRY_TIMEOUT in ipw, that doesn't mean it's the same in b43. Is the 0x40 register standardized in any way? According to the Wikipedia article on PCI configuration space registers, only up to 0x3F is standardized. There

Re: PCI config register 0x40

2009-12-19 Thread Larry Finger
On 12/19/2009 04:11 AM, Michael Buesch wrote: And if you do a patch, don't put it into ssb. Put it into b43. One further question about putting the patch into b43. Apparently, register 0x40 is not preserved across a suspend/resume to disk. In all the drivers that use this code, 0x40 is

Fatal DMA error problem with netbook and BCM4312 - another test

2009-12-19 Thread Larry Finger
Hi, If possible, please test this patch starting from a cold boot. It is a variation of something we tried earlier, but enough different to try it. Thanks, Larry In exploring the cause of DMA errors for BCM4312 devices on Atom processors, other drivers that work write to PCI configuration

Re: PCI config register 0x40

2009-12-19 Thread Michael Buesch
On Saturday 19 December 2009 17:11:30 Larry Finger wrote: On 12/19/2009 04:11 AM, Michael Buesch wrote: And if you do a patch, don't put it into ssb. Put it into b43. One further question about putting the patch into b43. Apparently, register 0x40 is not preserved across a suspend/resume

Re: Fatal DMA error problem with netbook and BCM4312 - another test

2009-12-19 Thread Chris Vine
On Sat, 19 Dec 2009 10:43:29 -0600 Larry Finger larry.fin...@lwfinger.net wrote: Hi, If possible, please test this patch starting from a cold boot. It is a variation of something we tried earlier, but enough different to try it. Thanks, Larry I applied this to 2.6.32.2 and it didn't

Re: Fatal DMA error problem with netbook and BCM4312 - another test

2009-12-19 Thread Andrew Benton
On 19/12/09 19:55, Chris Vine wrote: On Sat, 19 Dec 2009 10:43:29 -0600 Larry Fingerlarry.fin...@lwfinger.net wrote: Hi, If possible, please test this patch starting from a cold boot. It is a variation of something we tried earlier, but enough different to try it. Thanks, Larry I

Re: Fatal DMA error problem with netbook and BCM4312 - another test

2009-12-19 Thread Larry Finger
On 12/19/2009 05:11 PM, Andrew Benton wrote: On 19/12/09 19:55, Chris Vine wrote: I applied this to 2.6.32.2 and it didn't help with the DMA errors I am afraid. Chris Same here, the patch didn't prevent the DMA errors, however, I did notice that it only reported the error once, it

Re: Fatal DMA error problem with netbook and BCM4312 - another test

2009-12-19 Thread William Bourque
Larry Finger wrote: Hi, If possible, please test this patch starting from a cold boot. It is a variation of something we tried earlier, but enough different to try it. Thanks, Larry A little late but I just tested and I have the same bug. However, unlike Andrew, the error keep

Re: Fatal DMA error problem with netbook and BCM4312 - another test

2009-12-19 Thread Larry Finger
On 12/19/2009 10:15 PM, William Bourque wrote: Larry Finger wrote: Hi, If possible, please test this patch starting from a cold boot. It is a variation of something we tried earlier, but enough different to try it. Thanks, Larry A little late but I just tested and I have the same

[PATCH] b43: Clear PCI configuration reg. 0x41 to avoid interference with C3 processor state

2009-12-19 Thread Larry Finger
In exploring the cause of DMA errors for BCM4312 devices on Atom processors, other drivers that work write to PCI configuration register 0x40. The code fragment below was found in the open-code portion of the Broadcom hybrid wl driver. It is also used in the ipw2100 and ath9k drivers. In the

Re: [PATCH] b43: Clear PCI configuration reg. 0x41 to avoid interference with C3 processor state

2009-12-19 Thread Luis R. Rodriguez
On Sat, Dec 19, 2009 at 9:01 PM, Larry Finger larry.fin...@lwfinger.net wrote: In exploring the cause of DMA errors for BCM4312 devices on Atom processors, other drivers that work write to PCI configuration register 0x40. The code fragment below was found in the open-code portion of the