Re: [patch 6/6] b43: New firmware file format

2007-08-24 Thread Johannes Berg 
On Tue, 2007-08-21 at 16:13 -0400, John W. Linville wrote:

  otherwise it oopses when the file can't be loaded.
 
 ACK...here is a patch, in case you are lazy... :-)

Any reason you didn't push this fix this along with the patch?

johannes


signature.asc
Description: This is a digitally signed message part
___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Re: [patch 6/6] b43: New firmware file format

2007-08-24 Thread Michael Buesch 
On Thursday 23 August 2007 22:49:46 Johannes Berg wrote:
 On Tue, 2007-08-21 at 16:13 -0400, John W. Linville wrote:
 
   otherwise it oopses when the file can't be loaded.
  
  ACK...here is a patch, in case you are lazy... :-)
 
 Any reason you didn't push this fix this along with the patch?

Hm? This fix is on its way into the tree.


-- 
Greetings Michael.
___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Re: [patch 6/6] b43: New firmware file format

2007-08-21 Thread Johannes Berg 
On Sun, 2007-08-19 at 01:48 +0200, Michael Buesch wrote:

 @@ -1598,8 +1601,29 @@ static int do_request_fw(struct b43_wlde
   b43err(dev-wl, Firmware file \%s\ not found 
  or load failed.\n, path);

+   return err;

   }
 + if ((*fw)-size  sizeof(struct b43_fw_header))
 + goto err_format;

otherwise it oopses when the file can't be loaded.

johannes


signature.asc
Description: This is a digitally signed message part
___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Re: [patch 6/6] b43: New firmware file format

2007-08-21 Thread John W. Linville 
On Tue, Aug 21, 2007 at 05:46:40PM +0200, Johannes Berg wrote:
 On Sun, 2007-08-19 at 01:48 +0200, Michael Buesch wrote:
 
  @@ -1598,8 +1601,29 @@ static int do_request_fw(struct b43_wlde
  b43err(dev-wl, Firmware file \%s\ not found 
 or load failed.\n, path);
 
 + return err;
 
  }
  +   if ((*fw)-size  sizeof(struct b43_fw_header))
  +   goto err_format;
 
 otherwise it oopses when the file can't be loaded.

ACK...here is a patch, in case you are lazy... :-)

diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
index dcf7edc..d8693cf 100644
--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c
@@ -1600,6 +1600,7 @@ static int do_request_fw(struct b43_wldev *dev,
if (err) {
b43err(dev-wl, Firmware file \%s\ not found 
   or load failed.\n, path);
+   return err;
}
if ((*fw)-size  sizeof(struct b43_fw_header))
goto err_format;
-- 
John W. Linville
[EMAIL PROTECTED]
___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev